#1 Persistent memory for AI coding agents based on real-world benchmarks
TypeScript agentmemoryagentsaiclaudeclaudecodecodexcopilotcursorgenaiharnesshermesmemoryompopenclawopencodepi
fix(mcp): say when a write only reached the local fallback store (#1563)
Dmitrii Zhukov5f440859c966
diff --git a/src/mcp/in-memory-kv.ts b/src/mcp/in-memory-kv.tsindex 0dacebf1..3076498f 100644--- a/src/mcp/in-memory-kv.ts+++ b/src/mcp/in-memory-kv.ts@@ -42,8 +42,8 @@ export class InMemoryKV {return entries ? (Array.from(entries.values()) as T[]) : [];}- persist(): void {- if (!this.persistPath) return;+ persist(): boolean {+ if (!this.persistPath) return false;try {const dir = dirname(this.persistPath);if (!existsSync(dir)) mkdirSync(dir, { recursive: true });@@ -52,10 +52,12 @@ export class InMemoryKV {data[scope] = Object.fromEntries(entries);}writeFileSync(this.persistPath, JSON.stringify(data), "utf-8");+ return true;} catch (err) {process.stderr.write(`[@agentmemory/mcp] Persist failed: ${err instanceof Error ? err.message : String(err)}\n`,);+ return false;}}}diff --git a/src/mcp/standalone.ts b/src/mcp/standalone.tsindex e256fc45..8fd7f58e 100644--- a/src/mcp/standalone.ts+++ b/src/mcp/standalone.ts@@ -320,6 +320,16 @@ async function handleProxy(}}+function localFallbackNotice(persisted: boolean) {+ const store = persisted+ ? "the local fallback file, which the server does not read"+ : "this process's in-memory fallback store, which is lost when the process exits";+ return {+ storage: "local",+ warning: `agentmemory server at ${displayAgentmemoryUrl()} did not confirm this call, so it ran against ${store}.`,+ };+}+async function handleLocal(v: Validated,kvInstance: InMemoryKV,@@ -344,8 +354,8 @@ async function handleLocal(...(v.project !== undefined && { project: v.project }),...((v.agentId ?? getAgentId()) !== undefined && { agentId: v.agentId ?? getAgentId() }),});- kvInstance.persist();- return textResponse({ saved: id });+ const persisted = kvInstance.persist();+ return textResponse({ saved: id, ...localFallbackNotice(persisted) });}case "memory_recall":@@ -422,11 +432,12 @@ async function handleLocal(deleted++;}}- kvInstance.persist();+ const persisted = kvInstance.persist();return textResponse({deleted,requested: (v.memoryIds || []).length,reason: v.reason,+ ...localFallbackNotice(persisted),});}diff --git a/test/mcp-standalone-proxy.test.ts b/test/mcp-standalone-proxy.test.tsindex 959b04f6..ec5ed4f2 100644--- a/test/mcp-standalone-proxy.test.ts+++ b/test/mcp-standalone-proxy.test.ts@@ -390,7 +390,8 @@ describe("@agentmemory/mcp standalone — server proxy", () => {return new Response("not found", { status: 404 });});try {- await handleToolCall("memory_save", { content: "force-proxy" });+ const result = await handleToolCall("memory_save", { content: "force-proxy" });+ expect(JSON.parse(result.content[0].text)).toEqual({ id: "m-1", action: "created" });expect(calls.some((u) => u.endsWith("/agentmemory/livez"))).toBe(false);expect(calls.some((u) => u.endsWith("/agentmemory/remember"))).toBe(true);} finally {diff --git a/test/mcp-standalone.test.ts b/test/mcp-standalone.test.tsindex e9096cdd..7d3edd5a 100644--- a/test/mcp-standalone.test.ts+++ b/test/mcp-standalone.test.ts@@ -447,6 +447,98 @@ describe("handleToolCall", () => {expect(parsed.deleted).toBe(1);expect(parsed.requested).toBe(2);});++ describe("local fallback writes", () => {+ const serverUrl = "http://127.0.0.1:3999";+ const originalUrl = process.env["AGENTMEMORY_URL"];++ beforeEach(() => {+ process.env["AGENTMEMORY_URL"] = serverUrl;+ });++ afterEach(() => {+ if (originalUrl === undefined) delete process.env["AGENTMEMORY_URL"];+ else process.env["AGENTMEMORY_URL"] = originalUrl;+ });++ it("memory_save tells the caller the memory went to the local file, not the server", async () => {+ const kv = new InMemoryKV("/tmp/test-fallback.json");+ const result = await handleToolCall("memory_save", { content: "fallback save" }, kv);+ const parsed = JSON.parse(result.content[0].text);+ expect(parsed.saved).toMatch(/^mem_/);+ expect(parsed.storage).toBe("local");+ expect(parsed.warning).toContain(serverUrl);+ expect(parsed.warning).not.toContain("/tmp/test-fallback.json");+ expect(parsed.warning).not.toContain("lost");+ expect(writeFileSync).toHaveBeenCalledTimes(1);+ });++ it("memory_save says the memory is lost on exit when there is no local file", async () => {+ const kv = new InMemoryKV();+ const parsed = JSON.parse(+ (await handleToolCall("memory_save", { content: "no file" }, kv)).content[0].text,+ );+ expect(parsed.storage).toBe("local");+ expect(parsed.warning).toContain(serverUrl);+ expect(parsed.warning).toContain("lost when");+ });++ it("memory_save says the memory is lost on exit when writing the local file failed", async () => {+ vi.mocked(writeFileSync).mockImplementationOnce(() => {+ throw new Error("EACCES");+ });+ const kv = new InMemoryKV("/tmp/test-fallback.json");+ const parsed = JSON.parse(+ (await handleToolCall("memory_save", { content: "unwritable" }, kv)).content[0].text,+ );+ expect(parsed.storage).toBe("local");+ expect(parsed.warning).toContain("lost when");+ expect(writeFileSync).toHaveBeenCalledTimes(1);+ });++ it("memory_save marks the result local when the server stops answering mid-session", async () => {+ setLivezProbe(async () => ({ ok: true, status: 200, statusText: "OK" }));+ (globalThis as { fetch: typeof fetch }).fetch = vi.fn(async () => {+ throw new DOMException("The operation was aborted due to timeout", "TimeoutError");+ }) as unknown as typeof fetch;+ const kv = new InMemoryKV("/tmp/test-fallback.json");+ const parsed = JSON.parse(+ (await handleToolCall("memory_save", { content: "hung server" }, kv)).content[0].text,+ );+ expect(parsed.saved).toMatch(/^mem_/);+ expect(parsed.storage).toBe("local");+ expect(parsed.warning).toContain(serverUrl);+ });++ it("memory_governance_delete marks the result local", async () => {+ const kv = new InMemoryKV("/tmp/test-fallback.json");+ const parsed = JSON.parse(+ (await handleToolCall(+ "memory_governance_delete",+ { memoryIds: ["mem_on_server"] },+ kv,+ )).content[0].text,+ );+ expect(parsed.deleted).toBe(0);+ expect(parsed.storage).toBe("local");+ expect(parsed.warning).toContain(serverUrl);+ expect(parsed.warning).not.toContain("lost");+ expect(writeFileSync).toHaveBeenCalledTimes(1);+ });++ it("memory_governance_delete says the change is lost on exit when there is no local file", async () => {+ const kv = new InMemoryKV();+ const parsed = JSON.parse(+ (await handleToolCall(+ "memory_governance_delete",+ { memoryIds: ["mem_on_server"] },+ kv,+ )).content[0].text,+ );+ expect(parsed.storage).toBe("local");+ expect(parsed.warning).toContain("lost when");+ });+ });});describe("initialize protocol version negotiation", () => {