Skip to content

#1 Persistent memory for AI coding agents based on real-world benchmarks

fix: address CodeRabbit review findings across 8 files

Rohit Ghumare813e8d679e87
diff --git a/src/eval/metrics-store.ts b/src/eval/metrics-store.ts
index 5831261a..1d381ff9 100644
--- a/src/eval/metrics-store.ts
+++ b/src/eval/metrics-store.ts
@@ -4,6 +4,7 @@ import { KV } from "../state/schema.js";
export class MetricsStore {
private cache = new Map<string, FunctionMetrics>();
+ private qualityCallCounts = new Map<string, number>();
constructor(private kv: StateKV) {}
@@ -15,7 +16,7 @@ export class MetricsStore {
): Promise<void> {
let m = this.cache.get(functionId);
if (!m) {
- m = await this.kv.get<FunctionMetrics>(KV.metrics, functionId) ?? {
+ m = (await this.kv.get<FunctionMetrics>(KV.metrics, functionId)) ?? {
functionId,
totalCalls: 0,
successCount: 0,
@@ -34,7 +35,11 @@ export class MetricsStore {
m.failureCount += 1;
}
if (qualityScore !== undefined) {
- m.avgQualityScore = (m.avgQualityScore * prev + qualityScore) / m.totalCalls;
+ const prevQualityCalls = this.qualityCallCounts.get(functionId) || 0;
+ m.avgQualityScore =
+ (m.avgQualityScore * prevQualityCalls + qualityScore) /
+ (prevQualityCalls + 1);
+ this.qualityCallCounts.set(functionId, prevQualityCalls + 1);
}
this.cache.set(functionId, m);
@@ -42,12 +47,19 @@ export class MetricsStore {
}
async get(functionId: string): Promise<FunctionMetrics | null> {
- return this.cache.get(functionId) ??
- await this.kv.get<FunctionMetrics>(KV.metrics, functionId);
+ return (
+ this.cache.get(functionId) ??
+ (await this.kv.get<FunctionMetrics>(KV.metrics, functionId))
+ );
}
async getAll(): Promise<FunctionMetrics[]> {
- if (this.cache.size > 0) return Array.from(this.cache.values());
- return this.kv.list<FunctionMetrics>(KV.metrics).catch(() => []);
+ const kvMetrics = await this.kv
+ .list<FunctionMetrics>(KV.metrics)
+ .catch(() => []);
+ const merged = new Map<string, FunctionMetrics>();
+ for (const m of kvMetrics) merged.set(m.functionId, m);
+ for (const [id, m] of this.cache) merged.set(id, m);
+ return Array.from(merged.values());
}
}
diff --git a/src/functions/dedup.ts b/src/functions/dedup.ts
index 63f594d2..23f044a3 100644
--- a/src/functions/dedup.ts
+++ b/src/functions/dedup.ts
@@ -14,12 +14,14 @@ export class DedupMap {
constructor() {
this.cleanupTimer = setInterval(() => this.cleanup(), CLEANUP_INTERVAL_MS);
+ this.cleanupTimer.unref();
}
computeHash(sessionId: string, toolName: string, toolInput: unknown): string {
- const input = typeof toolInput === "string"
- ? toolInput.slice(0, 500)
- : JSON.stringify(toolInput ?? "").slice(0, 500);
+ const input =
+ typeof toolInput === "string"
+ ? toolInput.slice(0, 500)
+ : JSON.stringify(toolInput ?? "").slice(0, 500);
const raw = `${sessionId}:${toolName}:${input}`;
return createHash("sha256").update(raw).digest("hex");
}
diff --git a/src/functions/remember.ts b/src/functions/remember.ts
index 7f5588a3..b63a0307 100644
--- a/src/functions/remember.ts
+++ b/src/functions/remember.ts
@@ -68,14 +68,22 @@ export function registerRememberFunction(sdk: ISdk, kv: StateKV): void {
deleted++;
}
- if (data.observationIds?.length && data.sessionId) {
+ if (
+ data.sessionId &&
+ data.observationIds &&
+ data.observationIds.length > 0
+ ) {
for (const obsId of data.observationIds) {
await kv.delete(KV.observations(data.sessionId), obsId);
deleted++;
}
}
- if (data.sessionId && !data.observationIds) {
+ if (
+ data.sessionId &&
+ (!data.observationIds || data.observationIds.length === 0) &&
+ !data.memoryId
+ ) {
const observations = await kv.list<{ id: string }>(
KV.observations(data.sessionId),
);
diff --git a/src/functions/summarize.ts b/src/functions/summarize.ts
index 17e2c96c..a06068b7 100644
--- a/src/functions/summarize.ts
+++ b/src/functions/summarize.ts
@@ -103,6 +103,18 @@ export function registerSummarizeFunction(
"mem::summarize",
);
+ if (!validation.valid) {
+ const latencyMs = Date.now() - startMs;
+ if (metricsStore) {
+ await metricsStore.record("mem::summarize", latencyMs, false);
+ }
+ ctx.logger.warn("Summary validation failed", {
+ sessionId: data.sessionId,
+ errors: validation.result.errors,
+ });
+ return { success: false, error: "validation_failed" };
+ }
+
const qualityScore = scoreSummary(summaryForValidation);
await kv.set(KV.summaries, data.sessionId, summary);
diff --git a/src/health/monitor.ts b/src/health/monitor.ts
index 5cd6e0ba..d8fdcbd7 100644
--- a/src/health/monitor.ts
+++ b/src/health/monitor.ts
@@ -4,12 +4,14 @@ import type { StateKV } from "../state/kv.js";
import { KV } from "../state/schema.js";
import { evaluateHealth } from "./thresholds.js";
-let connectionState = "connected";
-
export function registerHealthMonitor(
sdk: ISdk,
kv: StateKV,
): { stop: () => void } {
+ let connectionState = "connected";
+ let prevCpuUsage = process.cpuUsage();
+ let prevCpuTime = Date.now();
+
if (typeof sdk.on === "function") {
sdk.on("connection_state", (state: string) => {
connectionState = state;
@@ -18,19 +20,30 @@ export function registerHealthMonitor(
async function collectHealth(): Promise<HealthSnapshot> {
const mem = process.memoryUsage();
- const cpu = process.cpuUsage();
+ const currentCpu = process.cpuUsage();
+ const now = Date.now();
const uptime = process.uptime();
+ const elapsedMs = now - prevCpuTime;
+ const userDelta = currentCpu.user - prevCpuUsage.user;
+ const systemDelta = currentCpu.system - prevCpuUsage.system;
+ const cpuPercent =
+ elapsedMs > 0
+ ? ((userDelta + systemDelta) / 1000 / elapsedMs) * 100
+ : 0;
+ prevCpuUsage = currentCpu;
+ prevCpuTime = now;
+
const startMark = performance.now();
await new Promise((resolve) => setImmediate(resolve));
const eventLoopLagMs = performance.now() - startMark;
let workers: HealthSnapshot["workers"] = [];
try {
- const result = await sdk.trigger<unknown, { workers?: HealthSnapshot["workers"] }>(
- "engine::workers::list",
- {},
- );
+ const result = await sdk.trigger<
+ unknown,
+ { workers?: HealthSnapshot["workers"] }
+ >("engine::workers::list", {});
if (result?.workers) workers = result.workers;
} catch {}
@@ -44,9 +57,9 @@ export function registerHealthMonitor(
external: mem.external,
},
cpu: {
- userMicros: cpu.user,
- systemMicros: cpu.system,
- percent: 0,
+ userMicros: currentCpu.user,
+ systemMicros: currentCpu.system,
+ percent: Math.round(cpuPercent * 100) / 100,
},
eventLoopLagMs,
uptimeSeconds: uptime,
@@ -72,6 +85,8 @@ export function registerHealthMonitor(
};
}
-export async function getLatestHealth(kv: StateKV): Promise<HealthSnapshot | null> {
+export async function getLatestHealth(
+ kv: StateKV,
+): Promise<HealthSnapshot | null> {
return kv.get<HealthSnapshot>(KV.health, "latest");
}
diff --git a/src/health/thresholds.ts b/src/health/thresholds.ts
index 373b4264..e64b848d 100644
--- a/src/health/thresholds.ts
+++ b/src/health/thresholds.ts
@@ -27,7 +27,10 @@ export function evaluateHealth(
let critical = false;
let degraded = false;
- if (snapshot.connectionState === "disconnected" || snapshot.connectionState === "failed") {
+ if (
+ snapshot.connectionState === "disconnected" ||
+ snapshot.connectionState === "failed"
+ ) {
alerts.push(`connection_${snapshot.connectionState}`);
critical = true;
} else if (snapshot.connectionState === "reconnecting") {
@@ -36,7 +39,9 @@ export function evaluateHealth(
}
if (snapshot.eventLoopLagMs > cfg.eventLoopLagCriticalMs) {
- alerts.push(`event_loop_lag_critical_${Math.round(snapshot.eventLoopLagMs)}ms`);
+ alerts.push(
+ `event_loop_lag_critical_${Math.round(snapshot.eventLoopLagMs)}ms`,
+ );
critical = true;
} else if (snapshot.eventLoopLagMs > cfg.eventLoopLagWarnMs) {
alerts.push(`event_loop_lag_warn_${Math.round(snapshot.eventLoopLagMs)}ms`);
@@ -51,9 +56,10 @@ export function evaluateHealth(
degraded = true;
}
- const memPercent = snapshot.memory.heapTotal > 0
- ? (snapshot.memory.rss / snapshot.memory.heapTotal) * 100
- : 0;
+ const memPercent =
+ snapshot.memory.heapTotal > 0
+ ? (snapshot.memory.heapUsed / snapshot.memory.heapTotal) * 100
+ : 0;
if (memPercent > cfg.memoryCriticalPercent) {
alerts.push(`memory_critical_${Math.round(memPercent)}%`);
critical = true;
diff --git a/src/providers/index.ts b/src/providers/index.ts
index 8649b320..7d54c2a9 100644
--- a/src/providers/index.ts
+++ b/src/providers/index.ts
@@ -5,19 +5,29 @@ import { OpenRouterProvider } from "./openrouter.js";
import { ResilientProvider } from "./resilient.js";
import { getEnvVar } from "../config.js";
+function requireEnvVar(key: string): string {
+ const value = getEnvVar(key);
+ if (!value) {
+ throw new Error(
+ `Missing required environment variable: ${key}. Set it in ~/.agentmemory/.env or as an environment variable.`,
+ );
+ }
+ return value;
+}
+
export function createProvider(config: ProviderConfig): ResilientProvider {
let base: MemoryProvider;
switch (config.provider) {
case "anthropic":
base = new AnthropicProvider(
- getEnvVar("ANTHROPIC_API_KEY")!,
+ requireEnvVar("ANTHROPIC_API_KEY"),
config.model,
config.maxTokens,
);
break;
case "gemini":
base = new OpenRouterProvider(
- getEnvVar("GEMINI_API_KEY")!,
+ requireEnvVar("GEMINI_API_KEY"),
config.model,
config.maxTokens,
"https://generativelanguage.googleapis.com/v1beta/openai/chat/completions",
@@ -25,7 +35,7 @@ export function createProvider(config: ProviderConfig): ResilientProvider {
break;
case "openrouter":
base = new OpenRouterProvider(
- getEnvVar("OPENROUTER_API_KEY")!,
+ requireEnvVar("OPENROUTER_API_KEY"),
config.model,
config.maxTokens,
"https://openrouter.ai/api/v1/chat/completions",
diff --git a/src/triggers/api.ts b/src/triggers/api.ts
index 3ed5f059..25cf1a14 100644
--- a/src/triggers/api.ts
+++ b/src/triggers/api.ts
@@ -37,32 +37,27 @@ export function registerApiTriggers(
metricsStore?: MetricsStore,
provider?: ResilientProvider | { circuitState?: unknown },
): void {
- sdk.registerFunction(
- { id: "api::health" },
- async (): Promise<Response> => {
- const health = await getLatestHealth(kv);
- const functionMetrics = metricsStore
- ? await metricsStore.getAll()
- : [];
- const circuitBreaker =
- provider && "circuitState" in provider ? provider.circuitState : null;
+ sdk.registerFunction({ id: "api::health" }, async (): Promise<Response> => {
+ const health = await getLatestHealth(kv);
+ const functionMetrics = metricsStore ? await metricsStore.getAll() : [];
+ const circuitBreaker =
+ provider && "circuitState" in provider ? provider.circuitState : null;
- const status = health?.status || "healthy";
- const statusCode = status === "critical" ? 503 : 200;
+ const status = health?.status || "healthy";
+ const statusCode = status === "critical" ? 503 : 200;
- return {
- status_code: statusCode,
- body: {
- status,
- service: "agentmemory",
- version: "0.3.0",
- health: health || null,
- functionMetrics,
- circuitBreaker,
- },
- };
- },
- );
+ return {
+ status_code: statusCode,
+ body: {
+ status,
+ service: "agentmemory",
+ version: "0.3.0",
+ health: health || null,
+ functionMetrics,
+ circuitBreaker,
+ },
+ };
+ });
sdk.registerTrigger({
type: "http",
function_id: "api::health",
@@ -356,12 +351,11 @@ export function registerApiTriggers(
sdk.registerFunction(
{ id: "api::evict" },
- async (
- req: ApiRequest<{ dryRun?: boolean }>,
- ): Promise<Response> => {
+ async (req: ApiRequest<{ dryRun?: boolean }>): Promise<Response> => {
const authErr = checkAuth(req, secret);
if (authErr) return authErr;
- const dryRun = req.query_params?.["dryRun"] === "true" || req.body?.dryRun;
+ const dryRun =
+ req.query_params?.["dryRun"] === "true" || req.body?.dryRun === true;
const result = await sdk.trigger("mem::evict", { dryRun });
return { status_code: 200, body: result };
},