#1 Persistent memory for AI coding agents based on real-world benchmarks
TypeScript agentmemoryagentsaiclaudeclaudecodecodexcopilotcursorgenaiharnesshermesmemoryompopenclawopencodepi
test(hooks): decouple resolveProject tests from checkout directory name (#1138)
Dmitrii Zhukova7114c7b6817
diff --git a/test/hook-project.test.ts b/test/hook-project.test.tsindex 66e25f18..37d0e424 100644--- a/test/hook-project.test.ts+++ b/test/hook-project.test.ts@@ -1,17 +1,40 @@-import { describe, it, expect, beforeEach, afterEach } from "vitest";-import { mkdtempSync, rmSync } from "node:fs";+import { describe, it, expect, beforeAll, afterAll, beforeEach, afterEach, vi } from "vitest";+import { execFileSync } from "node:child_process";+import { mkdirSync, mkdtempSync, realpathSync, rmSync } from "node:fs";import { tmpdir } from "node:os";-import { join } from "node:path";+import { basename, dirname, join } from "node:path";import { resolveProject } from "../src/hooks/_project.js";+// The checkout directory is not necessarily named "agentmemory" — contributors clone+// into forks, worktrees and arbitrary paths — so the git-toplevel assertions run against+// a throwaway repo whose name we control instead of against process.cwd().+const REPO_NAME = "amem-fixture-repo";+describe("resolveProject — hook project basename resolver", () => {const originalEnv = process.env.AGENTMEMORY_PROJECT_NAME;+ let tmpRoot: string;+ let repoDir: string;+ let nestedDir: string;++ beforeAll(() => {+ tmpRoot = mkdtempSync(join(tmpdir(), "amem-project-"));+ repoDir = join(tmpRoot, REPO_NAME);+ nestedDir = join(repoDir, "src", "hooks");+ mkdirSync(nestedDir, { recursive: true });+ execFileSync("git", ["init", "--quiet"], { cwd: repoDir, stdio: "ignore" });+ });++ afterAll(() => {+ rmSync(tmpRoot, { recursive: true, force: true });+ });+beforeEach(() => {delete process.env.AGENTMEMORY_PROJECT_NAME;});afterEach(() => {+ vi.restoreAllMocks();if (originalEnv === undefined) {delete process.env.AGENTMEMORY_PROJECT_NAME;} else {@@ -22,7 +45,7 @@ describe("resolveProject — hook project basename resolver", () => {it("AGENTMEMORY_PROJECT_NAME env wins over everything", () => {process.env.AGENTMEMORY_PROJECT_NAME = "my-override";expect(resolveProject("/var/log")).toBe("my-override");- expect(resolveProject(process.cwd())).toBe("my-override");+ expect(resolveProject(repoDir)).toBe("my-override");});it("trims whitespace on env override", () => {@@ -32,35 +55,46 @@ describe("resolveProject — hook project basename resolver", () => {it("ignores empty env override", () => {process.env.AGENTMEMORY_PROJECT_NAME = " ";- const repoBasename = "agentmemory";- expect(resolveProject(process.cwd())).toBe(repoBasename);+ expect(resolveProject(repoDir)).toBe(REPO_NAME);});it("returns git toplevel basename when cwd is inside a repo", () => {- const top = resolveProject(process.cwd());- expect(top).toBe("agentmemory");+ expect(resolveProject(repoDir)).toBe(REPO_NAME);});it("returns git toplevel basename from a nested subdir", () => {- const nested = join(process.cwd(), "src", "hooks");- expect(resolveProject(nested)).toBe("agentmemory");+ expect(resolveProject(nestedDir)).toBe(REPO_NAME);});it("falls back to basename(cwd) when not in a git repo", () => {- const dir = mkdtempSync(join(tmpdir(), "amem-noproj-"));+ // mkdtemp lands under os.tmpdir(), which is not always outside a repository —+ // TMPDIR pointed at a working directory makes git walk up and find one, and the+ // fallback under test never runs. Ceiling the upward search at the parent so the+ // directory is genuinely repo-less. The ceiling must be a resolved path: git+ // compares it after resolving symlinks, and on macOS tmpdir() is one.+ const dir = realpathSync(mkdtempSync(join(tmpdir(), "amem-noproj-")));+ const priorCeiling = process.env.GIT_CEILING_DIRECTORIES;+ process.env.GIT_CEILING_DIRECTORIES = dirname(dir);try {- expect(resolveProject(dir)).toBe(dir.split("/").pop());+ expect(resolveProject(dir)).toBe(basename(dir));} finally {+ if (priorCeiling === undefined) {+ delete process.env.GIT_CEILING_DIRECTORIES;+ } else {+ process.env.GIT_CEILING_DIRECTORIES = priorCeiling;+ }rmSync(dir, { recursive: true, force: true });}});it("defaults to process.cwd() when no cwd argument given", () => {- expect(resolveProject()).toBe("agentmemory");+ vi.spyOn(process, "cwd").mockReturnValue(repoDir);+ expect(resolveProject()).toBe(REPO_NAME);});it("defaults to process.cwd() when cwd argument is empty", () => {- expect(resolveProject("")).toBe("agentmemory");- expect(resolveProject(" ")).toBe("agentmemory");+ vi.spyOn(process, "cwd").mockReturnValue(repoDir);+ expect(resolveProject("")).toBe(REPO_NAME);+ expect(resolveProject(" ")).toBe(REPO_NAME);});});