Skip to content

#1 Persistent memory for AI coding agents based on real-world benchmarks

fix: defensive null guards on Memory.sessionIds (#684)

Rohit Ghumaree39d9627927a
diff --git a/src/functions/export-import.ts b/src/functions/export-import.ts
index 39c6036d..ed15ef59 100644
--- a/src/functions/export-import.ts
+++ b/src/functions/export-import.ts
@@ -375,6 +375,10 @@ export function registerExportImportFunction(sdk: ISdk, kv: StateKV): void {
continue;
}
}
+ // Older exports + hand-edited dumps can omit this field.
+ if (!Array.isArray(memory.sessionIds)) {
+ memory.sessionIds = [];
+ }
await kv.set(KV.memories, memory.id, memory);
stats.memories++;
}
diff --git a/src/functions/remember.ts b/src/functions/remember.ts
index a19d6b0a..5735b4f2 100644
--- a/src/functions/remember.ts
+++ b/src/functions/remember.ts
@@ -142,7 +142,7 @@ export function registerRememberFunction(sdk: ISdk, kv: StateKV): void {
}
await vectorIndexAddGuarded(
memory.id,
- memory.sessionIds[0] ?? "memory",
+ memory.sessionIds?.[0] ?? "memory",
memory.title + " " + memory.content,
{ kind: "memory", logId: memory.id },
);
diff --git a/src/functions/search.ts b/src/functions/search.ts
index ffe3bec5..655ea93d 100644
--- a/src/functions/search.ts
+++ b/src/functions/search.ts
@@ -261,7 +261,7 @@ export async function rebuildIndex(kv: StateKV): Promise<number> {
idx.add(memoryToObservation(memory))
await enqueue({
id: memory.id,
- sessionId: memory.sessionIds[0] ?? 'memory',
+ sessionId: memory.sessionIds?.[0] ?? 'memory',
text: memory.title + ' ' + memory.content,
context: { kind: "memory", logId: memory.id },
})
diff --git a/src/index.ts b/src/index.ts
index 3428139f..96391640 100644
--- a/src/index.ts
+++ b/src/index.ts
@@ -482,7 +482,7 @@ async function main() {
if (bm25Index.has(memory.id)) continue;
bm25Index.add({
id: memory.id,
- sessionId: memory.sessionIds[0] ?? "memory",
+ sessionId: memory.sessionIds?.[0] ?? "memory",
timestamp: memory.createdAt,
type: "decision",
title: memory.title,
diff --git a/src/state/memory-utils.ts b/src/state/memory-utils.ts
index a353694e..aa0bcc5b 100644
--- a/src/state/memory-utils.ts
+++ b/src/state/memory-utils.ts
@@ -11,7 +11,7 @@ import type { CompressedObservation, Memory } from "../types.js";
export function memoryToObservation(memory: Memory): CompressedObservation {
return {
id: memory.id,
- sessionId: memory.sessionIds[0] ?? "memory",
+ sessionId: memory.sessionIds?.[0] ?? "memory",
timestamp: memory.createdAt,
type: "decision",
title: memory.title,