#1 Persistent memory for AI coding agents based on real-world benchmarks
TypeScript agentmemoryagentsaiclaudeclaudecodecodexcopilotcursorgenaiharnesshermesmemoryompopenclawopencodepi
fix: keep routine logs off MCP stdout (#1522)
Som Samantraye6d5136ee7cf
diff --git a/plugin/scripts/plugin-bridge.mjs b/plugin/scripts/plugin-bridge.mjsindex c77ea4e1..160dbb80 100644--- a/plugin/scripts/plugin-bridge.mjs+++ b/plugin/scripts/plugin-bridge.mjs@@ -82,6 +82,7 @@ function resolveEnvOrEmpty(name) {}//#endregion//#region src/mcp/transport.ts+let activeStdioTransports = 0;var JsonRpcError = class extends Error {constructor(code, message) {super(message);@@ -234,6 +235,7 @@ function createMessageParser(onMessage, writeErr = (msg) => process.stderr.writefunction createStdioTransport(handler) {let parser = null;let queue = Promise.resolve();+ let active = false;const writeResponse = (response) => {const formatted = formatResponse(response, parser?.isFramed() ?? false);if (typeof formatted === "string") {@@ -245,6 +247,10 @@ function createStdioTransport(handler) {const onData = (chunk) => parser?.push(chunk);return {start() {+ if (active) return;+ active = true;+ activeStdioTransports += 1;+ process.env["AGENTMEMORY_MCP_STDIO__"] = "1";parser = createMessageParser((message) => {queue = queue.then(() => processLine(message, handler, writeResponse));queue.catch((err) => {@@ -255,6 +261,11 @@ function createStdioTransport(handler) {},stop() {process.stdin.off("data", onData);+ if (active) {+ active = false;+ activeStdioTransports -= 1;+ if (activeStdioTransports === 0) delete process.env["AGENTMEMORY_MCP_STDIO__"];+ }parser = null;}};diff --git a/src/logger.ts b/src/logger.tsindex 4d7a0936..605e9424 100644--- a/src/logger.ts+++ b/src/logger.ts@@ -15,9 +15,13 @@ function fmt(level: string, msg: string, fields: Fields): string {function emit(level: string, msg: string, fields: Fields): void {try {- process.stderr.write(fmt(level, msg, fields) + "\n");+ const line = fmt(level, msg, fields) + "\n";+ if (level === "error" || process.env["AGENTMEMORY_MCP_STDIO__"] === "1") {+ process.stderr.write(line);+ }+ else process.stdout.write(line);} catch {- // stderr is unavailable in some weird test/worker contexts — swallow+ // stdout or stderr is unavailable in some test/worker contexts — swallow// so no log line can ever crash a handler.}}diff --git a/src/mcp/transport.ts b/src/mcp/transport.tsindex 4f1d40df..1982b8f9 100644--- a/src/mcp/transport.ts+++ b/src/mcp/transport.ts@@ -17,6 +17,8 @@ export type RequestHandler = (params: Record<string, unknown>,) => Promise<unknown>;+let activeStdioTransports = 0;+export class JsonRpcError extends Error {constructor(public readonly code: number, message: string) {super(message);@@ -234,6 +236,7 @@ export function createStdioTransport(handler: RequestHandler): {} {let parser: StdioMessageParser | null = null;let queue = Promise.resolve();+ let active = false;const writeResponse = (response: JsonRpcResponse) => {const formatted = formatResponse(response, parser?.isFramed() ?? false);@@ -250,6 +253,10 @@ export function createStdioTransport(handler: RequestHandler): {return {start() {+ if (active) return;+ active = true;+ activeStdioTransports += 1;+ process.env["AGENTMEMORY_MCP_STDIO__"] = "1";parser = createMessageParser((message) => {queue = queue.then(() => processLine(message, handler, writeResponse));void queue.catch((err) => {@@ -264,6 +271,13 @@ export function createStdioTransport(handler: RequestHandler): {},stop() {process.stdin.off("data", onData);+ if (active) {+ active = false;+ activeStdioTransports -= 1;+ if (activeStdioTransports === 0) {+ delete process.env["AGENTMEMORY_MCP_STDIO__"];+ }+ }parser = null;},};diff --git a/test/logger.test.ts b/test/logger.test.tsnew file mode 100644index 00000000..8a1b05fc--- /dev/null+++ b/test/logger.test.ts@@ -0,0 +1,49 @@+import { afterEach, describe, expect, it, vi } from "vitest";+import { logger } from "../src/logger.js";+import { createStdioTransport } from "../src/mcp/transport.js";++describe("logger output streams", () => {+ afterEach(() => {+ delete process.env["AGENTMEMORY_MCP_STDIO__"];+ vi.restoreAllMocks();+ });++ it("writes info and warning messages to stdout and errors to stderr", () => {+ const stdoutWrite = vi.spyOn(process.stdout, "write").mockImplementation(() => true);+ const stderrWrite = vi.spyOn(process.stderr, "write").mockImplementation(() => true);++ logger.info("captured", { id: "memory-1" });+ logger.warn("retrying");+ logger.error("failed");++ expect(stdoutWrite.mock.calls.map(([line]) => line)).toEqual([+ '[agentmemory] info captured {"id":"memory-1"}\n',+ "[agentmemory] warn retrying\n",+ ]);+ expect(stderrWrite.mock.calls.map(([line]) => line)).toEqual([+ "[agentmemory] error failed\n",+ ]);+ });++ it("keeps routine logs off stdout while MCP stdio is active", () => {+ const stdoutWrite = vi.spyOn(process.stdout, "write").mockImplementation(() => true);+ const stderrWrite = vi.spyOn(process.stderr, "write").mockImplementation(() => true);+ const firstTransport = createStdioTransport(async () => ({}));+ const secondTransport = createStdioTransport(async () => ({}));+ firstTransport.start();+ secondTransport.start();++ logger.info("request handled");+ logger.warn("request retried");+ firstTransport.stop();+ logger.warn("second transport active");+ secondTransport.stop();+ logger.info("worker log");++ expect(stdoutWrite).toHaveBeenCalledTimes(1);+ expect(stdoutWrite).toHaveBeenCalledWith("[agentmemory] info worker log\n");+ expect(stderrWrite).toHaveBeenNthCalledWith(1, "[agentmemory] info request handled\n");+ expect(stderrWrite).toHaveBeenNthCalledWith(2, "[agentmemory] warn request retried\n");+ expect(stderrWrite).toHaveBeenNthCalledWith(3, "[agentmemory] warn second transport active\n");+ });+});