Skip to content

#1 Persistent memory for AI coding agents based on real-world benchmarks

fix(hooks): stop exiting before the observe request is sent (#1456)

Rohit Ghumaree975353e0e41
diff --git a/plugin/scripts/notification.mjs b/plugin/scripts/notification.mjs
index dcf2e393..8d340ccf 100755
--- a/plugin/scripts/notification.mjs
+++ b/plugin/scripts/notification.mjs
@@ -81,7 +81,7 @@ async function main() {
}),
signal: AbortSignal.timeout(2e3)
}).catch(() => {});
- setTimeout(() => process.exit(0), 500).unref();
+ setTimeout(() => process.exit(0), 2e3).unref();
}
main().catch(() => process.exit(0));
//#endregion
diff --git a/plugin/scripts/post-tool-failure.mjs b/plugin/scripts/post-tool-failure.mjs
index a33f5c1b..3a7a22e4 100755
--- a/plugin/scripts/post-tool-failure.mjs
+++ b/plugin/scripts/post-tool-failure.mjs
@@ -120,7 +120,7 @@ async function main() {
}),
signal: AbortSignal.timeout(3e3)
}).catch(() => {});
- setTimeout(() => process.exit(0), 500).unref();
+ setTimeout(() => process.exit(0), 3e3).unref();
}
main().catch(() => process.exit(0));
//#endregion
diff --git a/plugin/scripts/post-tool-use.mjs b/plugin/scripts/post-tool-use.mjs
index 8345354c..b1b8b55b 100755
--- a/plugin/scripts/post-tool-use.mjs
+++ b/plugin/scripts/post-tool-use.mjs
@@ -142,7 +142,7 @@ async function main() {
}),
signal: AbortSignal.timeout(3e3)
}).catch(() => {});
- setTimeout(() => process.exit(0), 500).unref();
+ setTimeout(() => process.exit(0), 3e3).unref();
}
function toolOutput(data) {
if (data.tool_response !== void 0) return data.tool_response;
diff --git a/plugin/scripts/prompt-submit.mjs b/plugin/scripts/prompt-submit.mjs
index 53daba26..ecf9e527 100755
--- a/plugin/scripts/prompt-submit.mjs
+++ b/plugin/scripts/prompt-submit.mjs
@@ -70,7 +70,7 @@ async function main() {
}),
signal: AbortSignal.timeout(3e3)
}).catch(() => {});
- setTimeout(() => process.exit(0), 500).unref();
+ setTimeout(() => process.exit(0), 3e3).unref();
}
main().catch(() => process.exit(0));
//#endregion
diff --git a/plugin/scripts/subagent-start.mjs b/plugin/scripts/subagent-start.mjs
index 722f0c7f..22a279bb 100755
--- a/plugin/scripts/subagent-start.mjs
+++ b/plugin/scripts/subagent-start.mjs
@@ -76,7 +76,7 @@ async function main() {
}),
signal: AbortSignal.timeout(TIMEOUT_MS)
}).catch(() => {});
- setTimeout(() => process.exit(0), 500).unref();
+ setTimeout(() => process.exit(0), TIMEOUT_MS).unref();
}
main().catch(() => process.exit(0));
//#endregion
diff --git a/plugin/scripts/subagent-stop.mjs b/plugin/scripts/subagent-stop.mjs
index 8927c1af..9f17b145 100755
--- a/plugin/scripts/subagent-stop.mjs
+++ b/plugin/scripts/subagent-stop.mjs
@@ -77,7 +77,7 @@ async function main() {
}),
signal: AbortSignal.timeout(2e3)
}).catch(() => {});
- setTimeout(() => process.exit(0), 500).unref();
+ setTimeout(() => process.exit(0), 2e3).unref();
}
main().catch(() => process.exit(0));
//#endregion
diff --git a/plugin/scripts/task-completed.mjs b/plugin/scripts/task-completed.mjs
index 613a9cd9..089ccd2e 100755
--- a/plugin/scripts/task-completed.mjs
+++ b/plugin/scripts/task-completed.mjs
@@ -76,7 +76,7 @@ async function main() {
}),
signal: AbortSignal.timeout(2e3)
}).catch(() => {});
- setTimeout(() => process.exit(0), 500).unref();
+ setTimeout(() => process.exit(0), 2e3).unref();
}
main().catch(() => process.exit(0));
//#endregion
diff --git a/src/hooks/notification.ts b/src/hooks/notification.ts
index 4c6a1063..e961ef68 100644
--- a/src/hooks/notification.ts
+++ b/src/hooks/notification.ts
@@ -58,7 +58,7 @@ async function main() {
}),
signal: AbortSignal.timeout(2000),
}).catch(() => {});
- setTimeout(() => process.exit(0), 500).unref();
+ setTimeout(() => process.exit(0), 2000).unref();
}
main().catch(() => process.exit(0));
diff --git a/src/hooks/post-tool-failure.ts b/src/hooks/post-tool-failure.ts
index 427e32cd..10a83d58 100644
--- a/src/hooks/post-tool-failure.ts
+++ b/src/hooks/post-tool-failure.ts
@@ -66,7 +66,7 @@ async function main() {
}),
signal: AbortSignal.timeout(3000),
}).catch(() => {});
- setTimeout(() => process.exit(0), 500).unref();
+ setTimeout(() => process.exit(0), 3000).unref();
}
main().catch(() => process.exit(0));
diff --git a/src/hooks/post-tool-use.ts b/src/hooks/post-tool-use.ts
index 05aed993..5a84966a 100644
--- a/src/hooks/post-tool-use.ts
+++ b/src/hooks/post-tool-use.ts
@@ -65,7 +65,7 @@ async function main() {
}),
signal: AbortSignal.timeout(3000),
}).catch(() => {});
- setTimeout(() => process.exit(0), 500).unref();
+ setTimeout(() => process.exit(0), 3000).unref();
}
function toolOutput(data: Record<string, unknown>): unknown {
diff --git a/src/hooks/prompt-submit.ts b/src/hooks/prompt-submit.ts
index 91527b74..0e83dee1 100644
--- a/src/hooks/prompt-submit.ts
+++ b/src/hooks/prompt-submit.ts
@@ -49,7 +49,7 @@ async function main() {
}),
signal: AbortSignal.timeout(3000),
}).catch(() => {});
- setTimeout(() => process.exit(0), 500).unref();
+ setTimeout(() => process.exit(0), 3000).unref();
}
main().catch(() => process.exit(0));
diff --git a/src/hooks/subagent-start.ts b/src/hooks/subagent-start.ts
index 18cfe5e3..c5972f45 100644
--- a/src/hooks/subagent-start.ts
+++ b/src/hooks/subagent-start.ts
@@ -62,7 +62,7 @@ async function main() {
}),
signal: AbortSignal.timeout(TIMEOUT_MS),
}).catch(() => {});
- setTimeout(() => process.exit(0), 500).unref();
+ setTimeout(() => process.exit(0), TIMEOUT_MS).unref();
}
main().catch(() => process.exit(0));
diff --git a/src/hooks/subagent-stop.ts b/src/hooks/subagent-stop.ts
index d071bb36..092ef64b 100644
--- a/src/hooks/subagent-stop.ts
+++ b/src/hooks/subagent-stop.ts
@@ -59,7 +59,7 @@ async function main() {
}),
signal: AbortSignal.timeout(2000),
}).catch(() => {});
- setTimeout(() => process.exit(0), 500).unref();
+ setTimeout(() => process.exit(0), 2000).unref();
}
main().catch(() => process.exit(0));
diff --git a/src/hooks/task-completed.ts b/src/hooks/task-completed.ts
index 724b2594..865e36dd 100644
--- a/src/hooks/task-completed.ts
+++ b/src/hooks/task-completed.ts
@@ -57,7 +57,7 @@ async function main() {
}),
signal: AbortSignal.timeout(2000),
}).catch(() => {});
- setTimeout(() => process.exit(0), 500).unref();
+ setTimeout(() => process.exit(0), 2000).unref();
}
main().catch(() => process.exit(0));
diff --git a/test/hook-exit-timing.test.ts b/test/hook-exit-timing.test.ts
new file mode 100644
index 00000000..dd20cba9
--- /dev/null
+++ b/test/hook-exit-timing.test.ts
@@ -0,0 +1,48 @@
+import { describe, it, expect } from "vitest";
+import { readFileSync, readdirSync } from "node:fs";
+import { join } from "node:path";
+
+const hooksDir = join(__dirname, "..", "src", "hooks");
+
+function numericValue(source: string, token: string): number {
+ if (/^\d+$/.test(token)) return Number(token);
+ const match = source.match(new RegExp(`const ${token} = (\\d+);`));
+ if (!match) throw new Error(`cannot resolve ${token}`);
+ return Number(match[1]);
+}
+
+describe("hook exit timing", () => {
+ const hooks = readdirSync(hooksDir)
+ .filter((name) => name.endsWith(".ts") && !name.startsWith("_"))
+ .map((name) => ({ name, source: readFileSync(join(hooksDir, name), "utf-8") }))
+ .filter(({ source }) => /setTimeout\(\(\) => process\.exit\(0\), [\w]+\)\.unref\(\)/.test(source));
+
+ it("finds the hooks that post observations", () => {
+ expect(hooks.map((h) => h.name)).toEqual(
+ expect.arrayContaining([
+ "notification.ts",
+ "post-tool-failure.ts",
+ "post-tool-use.ts",
+ "prompt-submit.ts",
+ "subagent-start.ts",
+ "subagent-stop.ts",
+ "task-completed.ts",
+ ]),
+ );
+ });
+
+ it.each([
+ "notification.ts",
+ "post-tool-failure.ts",
+ "post-tool-use.ts",
+ "prompt-submit.ts",
+ "subagent-start.ts",
+ "subagent-stop.ts",
+ "task-completed.ts",
+ ])("%s does not exit before its observe request can finish", (name) => {
+ const hook = hooks.find((h) => h.name === name)!;
+ const exitCap = hook.source.match(/setTimeout\(\(\) => process\.exit\(0\), (\w+)\)\.unref\(\)/)![1];
+ const abort = hook.source.match(/AbortSignal\.timeout\((\w+)\)/)![1];
+ expect(numericValue(hook.source, exitCap)).toBeGreaterThanOrEqual(numericValue(hook.source, abort));
+ });
+});