Skip to content

Agent Mesh

bridge: decode agent cards into the SDK type instead of a hand-kept mirror

Tomas Tormo2511ad208316
diff --git a/cmd/sam-a2a-bridge/a2a.go b/cmd/sam-a2a-bridge/a2a.go
index e066208c..124d2a05 100644
--- a/cmd/sam-a2a-bridge/a2a.go
+++ b/cmd/sam-a2a-bridge/a2a.go
@@ -85,30 +85,28 @@ func handleGetAgentCard(ctx context.Context, cfg bridgeConfig, p getAgentCardPar
}
defer func() { _ = resp.Body.Close() }()
- // Wire keys match a2a-go v2.5.0's a2a.AgentCard/AgentCapabilities/AgentSkill json tags exactly.
- var wire struct {
- Name string `json:"name"`
- Description string `json:"description"`
- Version string `json:"version"`
- DefaultInputModes []string `json:"defaultInputModes"`
- DefaultOutputModes []string `json:"defaultOutputModes"`
- Capabilities struct {
- Streaming bool `json:"streaming"`
- } `json:"capabilities"`
- Skills []agentCardSkill `json:"skills"`
- }
- if err := json.NewDecoder(resp.Body).Decode(&wire); err != nil {
+ var card a2a.AgentCard
+ if err := json.NewDecoder(resp.Body).Decode(&card); err != nil {
return agentCardSummary{}, fmt.Errorf("agent card is not valid JSON: %w", err)
}
- return agentCardSummary{
- Name: wire.Name,
- Description: wire.Description,
- Version: wire.Version,
- DefaultInputModes: wire.DefaultInputModes,
- DefaultOutputModes: wire.DefaultOutputModes,
- Streaming: wire.Capabilities.Streaming,
- Skills: wire.Skills,
- }, nil
+ summary := agentCardSummary{
+ Name: card.Name,
+ Description: card.Description,
+ Version: card.Version,
+ DefaultInputModes: card.DefaultInputModes,
+ DefaultOutputModes: card.DefaultOutputModes,
+ Streaming: card.Capabilities.Streaming,
+ }
+ for _, skill := range card.Skills {
+ summary.Skills = append(summary.Skills, agentCardSkill{
+ ID: skill.ID,
+ Name: skill.Name,
+ Description: skill.Description,
+ Tags: skill.Tags,
+ Examples: skill.Examples,
+ })
+ }
+ return summary, nil
}
type sendAgentTaskParams struct {
diff --git a/cmd/sam-a2a-bridge/a2a_test.go b/cmd/sam-a2a-bridge/a2a_test.go
index 461ec3df..ac258448 100644
--- a/cmd/sam-a2a-bridge/a2a_test.go
+++ b/cmd/sam-a2a-bridge/a2a_test.go
@@ -318,7 +318,8 @@ func TestGetAgentCardTrims(t *testing.T) {
card := `{"name":"echo-agent","description":"echoes","version":"1.2.0",` +
`"defaultInputModes":["text/plain","application/pdf"],"defaultOutputModes":["text/plain"],` +
`"capabilities":{"streaming":false,"pushNotifications":true},` +
- `"securitySchemes":{"oauth":{"type":"oauth2"}},"provider":{"organization":"acme"},` +
+ `"securitySchemes":{"corp":{"apiKeySecurityScheme":{"location":"cookie","name":"session"}}},` +
+ `"provider":{"organization":"acme"},` +
`"skills":[{"id":"echo","name":"Echo","description":"repeats input",` +
`"tags":["test"],"examples":["say hi"]}]}`
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
@@ -349,7 +350,7 @@ func TestGetAgentCardTrims(t *testing.T) {
t.Error("streaming must reflect the card (false)")
}
raw, _ := json.Marshal(got)
- if strings.Contains(string(raw), "oauth") || strings.Contains(string(raw), "acme") {
+ if strings.Contains(string(raw), "session") || strings.Contains(string(raw), "acme") {
t.Fatalf("trim failed, security/provider material leaked: %s", raw)
}
}