Skip to content

Agent Mesh

kind: replace the RELEASE env with a --release-name flag

Tomas Tormo420855f177fb
diff --git a/development/deploy-kind-service.sh b/development/deploy-kind-service.sh
index 0a0c08f2..3f7cfc2e 100755
--- a/development/deploy-kind-service.sh
+++ b/development/deploy-kind-service.sh
@@ -1,11 +1,11 @@
#!/usr/bin/env bash
# Build, load and install a service into the kind mesh from a directory holding
# a Dockerfile and a charts/sam-node values.yaml (e.g. development/examples/calc-mcp).
-# Extra args pass to helm (e.g. --set replicaCount=3); RELEASE overrides the
-# release name to deploy the same directory as several nodes.
+# --release-name deploys the same directory as several nodes; anything else
+# after the directory passes to helm (e.g. --set replicaCount=3).
set -euo pipefail
-[[ $# -ge 1 ]] || { echo "usage: $(basename "$0") <service-dir> [helm args...]" >&2; exit 1; }
+[[ $# -ge 1 ]] || { echo "usage: $(basename "$0") <service-dir> [--release-name <name>] [helm args...]" >&2; exit 1; }
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
PROJECT_ROOT="$(cd "${SCRIPT_DIR}/.." && pwd)"
@@ -13,7 +13,16 @@ PROJECT_ROOT="$(cd "${SCRIPT_DIR}/.." && pwd)"
DIR="$(cd "$1" && pwd)"; shift
[[ -f "${DIR}/values.yaml" ]] || { echo "no values.yaml in ${DIR}" >&2; exit 1; }
NAME="$(basename "${DIR}")"
-RELEASE="${RELEASE:-${NAME}}"
+
+RELEASE="${NAME}"
+HELM_ARGS=()
+while [[ $# -gt 0 ]]; do
+ case "$1" in
+ --release-name) [[ $# -ge 2 ]] || { echo "--release-name needs a value" >&2; exit 1; }; RELEASE="$2"; shift 2 ;;
+ --release-name=*) RELEASE="${1#*=}"; shift ;;
+ *) HELM_ARGS+=("$1"); shift ;;
+ esac
+done
HELM="helm"
if ! command -v helm >/dev/null 2>&1; then
@@ -26,5 +35,5 @@ docker build -t "${NAME}:local" "${DIR}"
kind load docker-image --name sam-kind "${NAME}:local"
"${HELM}" --kube-context kind-sam-kind -n sam-kind upgrade --install "${RELEASE}" "${PROJECT_ROOT}/charts/sam-node" \
-f "${PROJECT_ROOT}/development/kind/sam-node.values.yaml" \
- -f "${DIR}/values.yaml" "$@"
+ -f "${DIR}/values.yaml" ${HELM_ARGS[@]+"${HELM_ARGS[@]}"}
kubectl --context kind-sam-kind -n sam-kind rollout status "deployment/${RELEASE}-sam-node" --timeout=180s
diff --git a/site/content/docs/development/kubernetes-deployment.md b/site/content/docs/development/kubernetes-deployment.md
index 3cb4e5a9..588da9d3 100644
--- a/site/content/docs/development/kubernetes-deployment.md
+++ b/site/content/docs/development/kubernetes-deployment.md
@@ -80,7 +80,7 @@ and extra args pass through to helm:
./development/deploy-kind-service.sh development/examples/code-reviewer-pool/reviewer --set replicaCount=3
./development/deploy-kind-service.sh ~/src/my-service
# same service as a second, differently-labeled node:
-RELEASE=calc-b ./development/deploy-kind-service.sh development/examples/calc-mcp \
+./development/deploy-kind-service.sh development/examples/calc-mcp --release-name calc-b \
--set-json 'extraArgs=["--discovery-interval=200ms","--labels=region=us-east-1"]'
```