Skip to content

Agent Mesh

refactor(warm-pool): move reviewer + manager under code-reviewer-pool/

Tomas Tormo9ee6ad3f6e9b
diff --git a/development/examples/pool-manager-mcp/Dockerfile b/development/examples/code-reviewer-pool/manager/Dockerfile
similarity index 100%
rename from development/examples/pool-manager-mcp/Dockerfile
rename to development/examples/code-reviewer-pool/manager/Dockerfile
diff --git a/development/examples/pool-manager-mcp/package.json b/development/examples/code-reviewer-pool/manager/package.json
similarity index 85%
rename from development/examples/pool-manager-mcp/package.json
rename to development/examples/code-reviewer-pool/manager/package.json
index 6888aaf2..26c089af 100644
--- a/development/examples/pool-manager-mcp/package.json
+++ b/development/examples/code-reviewer-pool/manager/package.json
@@ -1,5 +1,5 @@
{
- "name": "pool-manager-mcp",
+ "name": "manager",
"version": "1.0.0",
"private": true,
"type": "module",
diff --git a/development/examples/pool-manager-mcp/sam-node-config.yaml b/development/examples/code-reviewer-pool/manager/sam-node-config.yaml
similarity index 100%
rename from development/examples/pool-manager-mcp/sam-node-config.yaml
rename to development/examples/code-reviewer-pool/manager/sam-node-config.yaml
diff --git a/development/examples/pool-manager-mcp/server.mjs b/development/examples/code-reviewer-pool/manager/server.mjs
similarity index 100%
rename from development/examples/pool-manager-mcp/server.mjs
rename to development/examples/code-reviewer-pool/manager/server.mjs
diff --git a/development/examples/code-reviewer-mcp/Dockerfile b/development/examples/code-reviewer-pool/reviewer/Dockerfile
similarity index 93%
rename from development/examples/code-reviewer-mcp/Dockerfile
rename to development/examples/code-reviewer-pool/reviewer/Dockerfile
index 065ebe8e..b1a70d0b 100644
--- a/development/examples/code-reviewer-mcp/Dockerfile
+++ b/development/examples/code-reviewer-pool/reviewer/Dockerfile
@@ -9,7 +9,7 @@ RUN npm install
# Dev-only: replace <API_KEY> with a Google AI Studio free-tier key before `make kind`.
# Keep the edit local so it is never committed:
-# git update-index --skip-worktree development/examples/code-reviewer-mcp/Dockerfile
+# git update-index --skip-worktree development/examples/code-reviewer-pool/reviewer/Dockerfile
ENV GEMINI_API_KEY=<API_KEY>
ENV GEMINI_CLI_TRUST_WORKSPACE=true
diff --git a/development/examples/code-reviewer-pool/reviewer/docker-compose.yaml b/development/examples/code-reviewer-pool/reviewer/docker-compose.yaml
new file mode 100644
index 00000000..4eb5ee57
--- /dev/null
+++ b/development/examples/code-reviewer-pool/reviewer/docker-compose.yaml
@@ -0,0 +1,30 @@
+# Runs a sam-node (pulled from the internet) plus the Gemini-backed code-reviewer.
+# Copy .env.example to .env and fill in the values before `docker compose up`.
+services:
+ code-reviewer:
+ # Your private GHCR image. `docker compose build` tags it here so you can push it.
+ image: ${CODE_REVIEWER_IMAGE:-ghcr.io/kaisoz/gemini-code-reviewer-mcp:latest}
+ build: .
+ environment:
+ GEMINI_API_KEY: ${GEMINI_API_KEY:?set GEMINI_API_KEY in .env}
+ GEMINI_CLI_TRUST_WORKSPACE: "true"
+ expose:
+ - "7779"
+
+ sam-node:
+ image: ${SAM_NODE_IMAGE:-ghcr.io/google/sam-node:latest}
+ depends_on:
+ - code-reviewer
+ command:
+ - run
+ - --data-dir=/data
+ - --bind-addr=0.0.0.0:8080
+ - --api-token=${SAM_API_TOKEN:?set SAM_API_TOKEN in .env}
+ - --config=/config/sam-node.yaml
+ volumes:
+ - ./sam-node.yaml:/config/sam-node.yaml:ro
+ - ${SAM_DATA_DIR:-./sam-data}:/data # your pre-enrolled identity folder
+ ports:
+ - "8080:8080" # control-plane / MCP API
+ - "5001:5001/udp" # libp2p
+ - "5002:5002" # libp2p
diff --git a/development/examples/code-reviewer-pool/reviewer/env.example b/development/examples/code-reviewer-pool/reviewer/env.example
new file mode 100644
index 00000000..e57d9780
--- /dev/null
+++ b/development/examples/code-reviewer-pool/reviewer/env.example
@@ -0,0 +1,16 @@
+# Copy to .env and fill in.
+
+# Google AI Studio key the reviewer's gemini CLI uses.
+GEMINI_API_KEY=
+
+# Static Bearer token for the sam-node control-plane API.
+SAM_API_TOKEN=devtoken
+
+# Private code-reviewer image (built/pushed by you).
+CODE_REVIEWER_IMAGE=ghcr.io/kaisoz/code-reviewer-mcp:latest
+
+# sam-node image pulled from the internet.
+SAM_NODE_IMAGE=ghcr.io/google/sam-node:latest
+
+# Host folder holding the node's enrolled identity.
+SAM_DATA_DIR=./sam-data
diff --git a/development/examples/code-reviewer-mcp/package.json b/development/examples/code-reviewer-pool/reviewer/package.json
similarity index 85%
rename from development/examples/code-reviewer-mcp/package.json
rename to development/examples/code-reviewer-pool/reviewer/package.json
index c1232f9c..00ce49e3 100644
--- a/development/examples/code-reviewer-mcp/package.json
+++ b/development/examples/code-reviewer-pool/reviewer/package.json
@@ -1,5 +1,5 @@
{
- "name": "code-reviewer-mcp",
+ "name": "reviewer",
"version": "1.0.0",
"private": true,
"type": "module",
diff --git a/development/examples/code-reviewer-mcp/review_server.mjs b/development/examples/code-reviewer-pool/reviewer/review_server.mjs
similarity index 100%
rename from development/examples/code-reviewer-mcp/review_server.mjs
rename to development/examples/code-reviewer-pool/reviewer/review_server.mjs
diff --git a/development/examples/code-reviewer-mcp/sam-node-config.yaml b/development/examples/code-reviewer-pool/reviewer/sam-node-config.yaml
similarity index 100%
rename from development/examples/code-reviewer-mcp/sam-node-config.yaml
rename to development/examples/code-reviewer-pool/reviewer/sam-node-config.yaml
diff --git a/development/examples/code-reviewer-pool/reviewer/sam-node.yaml b/development/examples/code-reviewer-pool/reviewer/sam-node.yaml
new file mode 100644
index 00000000..bac090fe
--- /dev/null
+++ b/development/examples/code-reviewer-pool/reviewer/sam-node.yaml
@@ -0,0 +1,9 @@
+version: "v1alpha1"
+attenuation:
+ policies: []
+services:
+ - type: "mcp"
+ name: "code-reviewer"
+ description: "Reviews code snippets via a Gemini-backed agent"
+ # Reach the reviewer by its compose service name, not 127.0.0.1.
+ target_url: "http://code-reviewer:7779/mcp"
diff --git a/development/examples/warm-pool/README.md b/development/examples/warm-pool/README.md
index 1d968a24..f988ae04 100644
--- a/development/examples/warm-pool/README.md
+++ b/development/examples/warm-pool/README.md
@@ -42,17 +42,17 @@ dispatcher (fine for a single-manager pool).
1. **Set a Gemini key** for the reviewer image (free AI Studio key is fine):
```
- git update-index --skip-worktree development/examples/code-reviewer-mcp/Dockerfile
+ git update-index --skip-worktree development/examples/code-reviewer-pool/reviewer/Dockerfile
# edit ENV GEMINI_API_KEY=<API_KEY> in that Dockerfile
```
2. Mesh layout ships in `development/kind/mesh-config.yaml`:
```yaml
node-a: # in-cluster bare node
- node-b: code-reviewer-mcp # worker
- node-c: code-reviewer-mcp # worker
- node-d: code-reviewer-mcp # worker
- node-e: pool-manager-mcp # manager
+ node-b: code-reviewer-pool/reviewer # worker
+ node-c: code-reviewer-pool/reviewer # worker
+ node-d: code-reviewer-pool/reviewer # worker
+ node-e: code-reviewer-pool/manager # manager
```
3. Bring the mesh up and start a **local caller node** — this is the orchestrator
diff --git a/development/kind/mesh-config.yaml b/development/kind/mesh-config.yaml
index 78ac5ab5..9369416a 100644
--- a/development/kind/mesh-config.yaml
+++ b/development/kind/mesh-config.yaml
@@ -1,9 +1,9 @@
# node -> service. A blank value means a bare node (no service, e.g. a caller).
-# The service value is a folder name under development/examples/.
+# The service value is a folder path under development/examples/.
# node-a is the orchestrator entry; node-b/c/d form a warm reviewer pool;
# node-e runs the pool-manager that leases those workers out.
node-a:
-node-b: code-reviewer-mcp
-node-c: code-reviewer-mcp
-node-d: code-reviewer-mcp
-node-e: pool-manager-mcp
+node-b: code-reviewer-pool/reviewer
+node-c: code-reviewer-pool/reviewer
+node-d: code-reviewer-pool/reviewer
+node-e: code-reviewer-pool/manager
diff --git a/development/kind/run.sh b/development/kind/run.sh
index 758ad115..18ba40ad 100755
--- a/development/kind/run.sh
+++ b/development/kind/run.sh
@@ -31,16 +31,17 @@ render_and_apply() {
local CONFIG_ARG="" CONFIG_MOUNT="" SIDECAR="" CONFIG_VOLUME=""
if [[ -n "$svc" ]]; then
local dir="${PROJECT_ROOT}/development/examples/${svc}"
+ local name="$(basename "$svc")"
[[ -d "$dir" ]] || { echo "service '${svc}' (node ${node}) not found in development/examples/" >&2; exit 1; }
- echo "Building service image ${svc}:${IMAGE_TAG}…"
- docker build -t "${svc}:${IMAGE_TAG}" "$dir"
- kind load docker-image --name "${CLUSTER}" "${svc}:${IMAGE_TAG}"
+ echo "Building service image ${name}:${IMAGE_TAG}…"
+ docker build -t "${name}:${IMAGE_TAG}" "$dir"
+ kind load docker-image --name "${CLUSTER}" "${name}:${IMAGE_TAG}"
kubectl --context "${KCTX}" -n "${NAMESPACE}" create configmap "${node}-config" \
--from-file=sam-node.yaml="${dir}/sam-node-config.yaml" \
--dry-run=client -o yaml | kubectl --context "${KCTX}" apply -f -
CONFIG_ARG=' - "--config=/etc/sam/sam-node.yaml"'
CONFIG_MOUNT=$' - name: config\n mountPath: /etc/sam'
- SIDECAR=$' - name: '"${svc}"$'\n image: '"${svc}:${IMAGE_TAG}"$'\n imagePullPolicy: IfNotPresent'
+ SIDECAR=$' - name: '"${name}"$'\n image: '"${name}:${IMAGE_TAG}"$'\n imagePullPolicy: IfNotPresent'
CONFIG_VOLUME=$' - name: config\n configMap:\n name: '"${node}-config"
fi
NODE="$node" CONFIG_ARG="$CONFIG_ARG" CONFIG_MOUNT="$CONFIG_MOUNT" SIDECAR="$SIDECAR" CONFIG_VOLUME="$CONFIG_VOLUME" \
diff --git a/site/content/docs/development/kubernetes-deployment.md b/site/content/docs/development/kubernetes-deployment.md
index 0f531fdc..b79cc0b8 100644
--- a/site/content/docs/development/kubernetes-deployment.md
+++ b/site/content/docs/development/kubernetes-deployment.md
@@ -54,7 +54,7 @@ When a node has a service, `make kind-up` builds the service image from its `Doc
### Adding and Testing a New Service
-A service is any backend a node advertises to the mesh. Its kind is set by the `type` field in `sam-node-config.yaml`. SAM currently supports `mcp` (an MCP server) and `inference` (an LLM inference endpoint). The repository ships example MCP services under `development/examples/` (`calc-mcp`, `greeter-mcp`, `code-reviewer-mcp`, and `everything-mcp`) which are the easiest starting point. Using `calc-mcp` as a template:
+A service is any backend a node advertises to the mesh. Its kind is set by the `type` field in `sam-node-config.yaml`. SAM currently supports `mcp` (an MCP server) and `inference` (an LLM inference endpoint). The repository ships example MCP services under `development/examples/` (`calc-mcp`, `greeter-mcp`, `code-reviewer-pool/reviewer`, and `everything-mcp`) which are the easiest starting point. Using `calc-mcp` as a template:
1. **Create the service folder** `development/examples/my-mcp/` with:
- The service backend (e.g. `my_server.py`) listening on a local port, plus a `Dockerfile` and any `requirements.txt`.