Build and run agents you can see, understand and trust.
Python agentchatbotlarge-language-modelsllmllm-agentmcpmulti-agentmulti-modalreact-agentrealtime-agentvoice-agentvoice-assistant
fix(workspace): deregister stateless MCPs from sandbox gateway (#2777)
qbc140d6afefee5
diff --git a/src/agentscope/workspace/_base.py b/src/agentscope/workspace/_base.pyindex c80965633..dbff9e778 100644--- a/src/agentscope/workspace/_base.py+++ b/src/agentscope/workspace/_base.py@@ -792,9 +792,9 @@ class WorkspaceBase:async def _close_mcp_instance(instance: MCPClient) -> None:"""Close one live handle, downgrading failures to warnings.- Stateless clients hold no connection, so they are skipped.+ Unconnected clients (e.g. local stateless ones) are skipped."""- if not (instance.is_stateful and instance.is_connected):+ if not instance.is_connected:returntry:await instance.close()diff --git a/tests/workspace_daytona_test.py b/tests/workspace_daytona_test.pyindex 2ef6cb080..2cbea32f6 100644--- a/tests/workspace_daytona_test.py+++ b/tests/workspace_daytona_test.py@@ -41,7 +41,7 @@ from agentscope.app.storage import (SessionConfig,SessionRecord,)-from agentscope.mcp import MCPClient, StdioMCPConfig+from agentscope.mcp import HttpMCPConfig, MCPClient, StdioMCPConfigfrom agentscope.message import (Base64Source,DataBlock,@@ -1136,6 +1136,50 @@ class TestDaytonaWorkspaceBuiltinToolsMock(IsolatedAsyncioTestCase):data = json.loads(raw.decode("utf-8"))self.assertEqual(data["mcps"]["a"]["s"], [])+ async def test_stateless_mcp_remove_then_readd(self) -> None:+ """Removing a stateless MCP deregisters it from the gateway."""+ mcp = MCPClient(+ name="demo",+ mcp_config=HttpMCPConfig(url="http://mcp.example/mcp"),+ is_stateful=False,+ )+ await self.workspace.add_mcp(mcp, agent_id="a", session_id="s")+ first = self.workspace._mcp_instances[("a", "s")]["demo"]++ await self.workspace.remove_mcp("demo", agent_id="a", session_id="s")+ await self.workspace.add_mcp(mcp, agent_id="a", session_id="s")++ self.assertTrue(first.closed)+ live = self.workspace._mcp_instances[("a", "s")]+ self.assertListEqual(list(live), ["demo"])+ self.assertIsNot(live["demo"], first)+ raw = await self.workspace._backend.read_file("/home/daytona/.mcp")+ self.assertDictEqual(+ json.loads(raw.decode("utf-8")),+ {+ "version": 2,+ "mcps": {+ "a": {+ "s": [+ {+ "name": "demo",+ "mcp_config": {+ "type": "http_mcp",+ "url": "http://mcp.example/mcp",+ "headers": None,+ "timeout": 30.0,+ },+ "is_stateful": False,+ "enable_tools": None,+ "disable_tools": None,+ "execution_timeout": None,+ },+ ],+ },+ },+ },+ )+async def test_remove_missing_mcp_is_noop(self) -> None:"""Removing an unknown MCP leaves persisted config unchanged."""await self.workspace.remove_mcp("missing", agent_id="a")