Skip to content

Build and run agents you can see, understand and trust.

fix(model): honor caller-provided Gemini config (#3231)

ffffff55562cd22f97b9
diff --git a/src/agentscope/model/_gemini/_model.py b/src/agentscope/model/_gemini/_model.py
index 9c41b76ce..1eba8481a 100644
--- a/src/agentscope/model/_gemini/_model.py
+++ b/src/agentscope/model/_gemini/_model.py
@@ -285,7 +285,7 @@ class GeminiChatModel(ChatModelBase):
"""
formatted_messages = await self.formatter.format(messages)
- config: dict[str, Any] = {**config_kwargs}
+ config: dict[str, Any] = {}
if self.parameters.max_tokens is not None:
config["max_output_tokens"] = self.parameters.max_tokens
@@ -307,6 +307,9 @@ class GeminiChatModel(ChatModelBase):
"thinking_budget": 0,
}
+ # Per-call config takes precedence over model-level defaults.
+ config.update(config_kwargs)
+
fmt_tools, fmt_tool_choice = self._format_tools(tools, tool_choice)
if fmt_tools is not None:
diff --git a/tests/model_gemini_test.py b/tests/model_gemini_test.py
index df5fde2f4..ea87c3f88 100644
--- a/tests/model_gemini_test.py
+++ b/tests/model_gemini_test.py
@@ -152,6 +152,47 @@ class TestGeminiNonStream(IsolatedAsyncioTestCase):
),
)
+ async def test_call_config_overrides_parameter_defaults(self) -> None:
+ """Per-call config overrides model-level defaults."""
+ self.model.parameters.max_tokens = 1024
+ self.model.parameters.temperature = 0.2
+ self.model.parameters.top_p = 0.3
+ self.mock_client.aio.models.generate_content = AsyncMock(
+ return_value=_mock_completion([_make_part(text="ok")]),
+ )
+
+ default_config = {
+ "max_output_tokens": 1024,
+ "temperature": 0.2,
+ "top_p": 0.3,
+ "thinking_config": {
+ "include_thoughts": False,
+ "thinking_budget": 0,
+ },
+ }
+ cases = {
+ "max_output_tokens": 2048,
+ "temperature": 0.8,
+ "top_p": 0.9,
+ "thinking_config": {
+ "include_thoughts": True,
+ "thinking_budget": 8192,
+ },
+ }
+
+ for key, value in cases.items():
+ with self.subTest(key=key):
+ await self.model([], **{key: value})
+
+ call_args = (
+ self.mock_client.aio.models.generate_content.call_args
+ )
+ sent_config = call_args.kwargs["config"]
+ self.assertEqual(
+ sent_config,
+ {**default_config, key: value},
+ )
+
async def test_tool_call_response(self) -> None:
"""Non-stream tool call response creates ToolCallBlocks."""
parts = [