Skip to content

Build and run agents you can see, understand and trust.

feat(model): make DashScope thinking_enable tri-state (#3192)

konlue867ad8397064
diff --git a/src/agentscope/model/_dashscope/_model.py b/src/agentscope/model/_dashscope/_model.py
index d07bd01d7..d9b524def 100644
--- a/src/agentscope/model/_dashscope/_model.py
+++ b/src/agentscope/model/_dashscope/_model.py
@@ -50,10 +50,13 @@ class DashScopeChatModel(ChatModelBase):
gt=0,
)
- thinking_enable: bool = Field(
- default=False,
+ thinking_enable: bool | None = Field(
+ default=None,
title="Thinking",
- description="The thinking enable for the LLM output.",
+ description=(
+ "Whether to enable or disable thinking mode. When unset, "
+ "DashScope uses its default behavior for the model."
+ ),
)
thinking_budget: int | None = Field(
diff --git a/tests/model_dashscope_test.py b/tests/model_dashscope_test.py
index 18d560a87..4d2dc775e 100644
--- a/tests/model_dashscope_test.py
+++ b/tests/model_dashscope_test.py
@@ -252,6 +252,59 @@ class TestDashScopeNonStream(IsolatedAsyncioTestCase):
),
)
+ async def test_thinking_enable_not_sent_when_unset(self) -> None:
+ """Unset thinking leaves the server default unchanged."""
+ self.model = DashScopeChatModel(
+ credential=DashScopeCredential(api_key="test"),
+ model="qwen3-max",
+ stream=False,
+ )
+ self.model.client = self.mock_client
+ mock_create = AsyncMock(
+ return_value=_mock_completion(text="Hello!"),
+ )
+ self.mock_client.chat.completions.create = mock_create
+
+ await self.model([])
+
+ self.assertEqual(
+ (
+ self.model.parameters.thinking_enable,
+ mock_create.await_args.kwargs,
+ ),
+ (
+ None,
+ {
+ "model": "qwen3-max",
+ "messages": [],
+ "stream": False,
+ "extra_body": {},
+ },
+ ),
+ )
+
+ async def test_thinking_enable_explicit_false_is_sent(self) -> None:
+ """Explicitly disabling thinking is forwarded to the API."""
+ self.model.parameters = DashScopeChatModel.Parameters(
+ thinking_enable=False,
+ )
+ mock_create = AsyncMock(
+ return_value=_mock_completion(text="Hello!"),
+ )
+ self.mock_client.chat.completions.create = mock_create
+
+ await self.model([])
+
+ self.assertEqual(
+ mock_create.await_args.kwargs,
+ {
+ "model": "qwen3-max",
+ "messages": [],
+ "stream": False,
+ "extra_body": {"enable_thinking": False},
+ },
+ )
+
async def test_extra_body_is_not_mutated(self) -> None:
"""Model defaults do not mutate the caller-owned extra body."""
mock_create = AsyncMock(