Skip to content

Build and run agents you can see, understand and trust.

fix(memory): deduplicate selected files before limiting retrieval (#2776)

Sunhya38821287f35
diff --git a/src/agentscope/middleware/_longterm_memory/_agentic_memory/_middleware.py b/src/agentscope/middleware/_longterm_memory/_agentic_memory/_middleware.py
index e3af35a85..814d6e85e 100644
--- a/src/agentscope/middleware/_longterm_memory/_agentic_memory/_middleware.py
+++ b/src/agentscope/middleware/_longterm_memory/_agentic_memory/_middleware.py
@@ -754,9 +754,11 @@ class AgenticMemoryMiddleware(MiddlewareBase):
structured_model=_MemorySelection,
)
- # 3. Validate: discard hallucinated filenames.
+ # 3. Discard hallucinated filenames and count each memory only once.
raw_selected: list[str] = res.content.get("selected_files", [])
- selected = [f for f in raw_selected if f in valid_filenames][:5]
+ selected = list(
+ dict.fromkeys(f for f in raw_selected if f in valid_filenames),
+ )[:5]
if not selected:
return None
diff --git a/tests/middleware_filesystem_memory_test.py b/tests/middleware_filesystem_memory_test.py
index e6fddb21f..0672a1478 100644
--- a/tests/middleware_filesystem_memory_test.py
+++ b/tests/middleware_filesystem_memory_test.py
@@ -287,7 +287,7 @@ def _write_memory_file(
"""
path = os.path.join(memory_dir, filename)
os.makedirs(os.path.dirname(path), exist_ok=True)
- with open(path, "w", encoding="utf-8") as f:
+ with open(path, "w", encoding="utf-8", newline="\n") as f:
f.write(
"---\n"
f"name: {filename}\n"
@@ -566,6 +566,47 @@ class AgenticMemoryMiddlewareTest(IsolatedAsyncioTestCase):
],
)
+ async def test_agent_deduplicates_selected_memory_filenames(self) -> None:
+ """Duplicate selections should not consume the retrieval budget."""
+ memory_dir = os.path.join(self.temp_dir, "Memory")
+ os.makedirs(memory_dir)
+ for name in ["a", "b"]:
+ _write_memory_file(
+ memory_dir,
+ f"{name}.md",
+ f"Memory {name}",
+ "project",
+ f"Fact {name}.",
+ )
+
+ model = _RecordingMockModel()
+ model.set_structured_response(
+ _structured_response(["a.md"] * 5 + ["b.md"]),
+ )
+ model.set_responses([_tool_response(), _text_response("done")])
+ middleware = AgenticMemoryMiddleware(workdir=self.temp_dir)
+ agent = self._make_agent(
+ model,
+ middleware,
+ toolkit=Toolkit(tools=[_DummyTool()]),
+ )
+
+ await agent.reply(UserMsg("user", "recall my project"))
+ a_path, b_path = (
+ os.path.join(memory_dir, _) for _ in ["a.md", "b.md"]
+ )
+ self.assertListEqual(
+ _hint_texts(agent),
+ [
+ f"Memory (saved today): {a_path}:\n\n"
+ "---\nname: a.md\ndescription: Memory a\ntype: project\n"
+ "---\n\nFact a.\n\n\n---\n\n"
+ f"Memory (saved today): {b_path}:\n\n"
+ "---\nname: b.md\ndescription: Memory b\ntype: project\n"
+ "---\n\nFact b.\n",
+ ],
+ )
+
async def test_agent_does_not_inject_hint_when_no_file_selected(
self,
) -> None: