Skip to content

Build and run agents you can see, understand and trust.

fix(reme): fix the error when creating `ReMePersonalLongTermMemory` using `OpenAITextEmebdding` (#929)

清吾c7266f666e52
diff --git a/src/agentscope/memory/_reme/_reme_long_term_memory_base.py b/src/agentscope/memory/_reme/_reme_long_term_memory_base.py
index bb92d5989..4e9c27800 100644
--- a/src/agentscope/memory/_reme/_reme_long_term_memory_base.py
+++ b/src/agentscope/memory/_reme/_reme_long_term_memory_base.py
@@ -233,11 +233,12 @@ class ReMeLongTermMemoryBase(LongTermMemoryBase, metaclass=ABCMeta):
embedding_api_key = embedding_model.api_key
elif isinstance(embedding_model, OpenAITextEmbedding):
- embedding_api_base = getattr(
+ base_url = getattr(
embedding_model.client,
"base_url",
None,
)
+ embedding_api_base = str(base_url) if base_url else None
embedding_api_key = getattr(
embedding_model.client,
"api_key",
@@ -259,6 +260,11 @@ class ReMeLongTermMemoryBase(LongTermMemoryBase, metaclass=ABCMeta):
f"embedding_model.default.model_name={embedding_model_name}",
)
+ dimensions = embedding_model.dimensions
+ config_args.append(
+ f'embedding_model.default.params={{"dimensions": {dimensions}}}',
+ )
+
# Attempt to import and initialize ReMe
# If import fails, set app to None and issue a warning
# This allows the class to be instantiated even without
diff --git a/tests/memory_reme_test.py b/tests/memory_reme_test.py
index b6325cc4f..1c05cdd13 100644
--- a/tests/memory_reme_test.py
+++ b/tests/memory_reme_test.py
@@ -52,6 +52,7 @@ class TestReMeMemory(IsolatedAsyncioTestCase):
self.mock_embedding_model = MagicMock(spec=DashScopeTextEmbedding)
self.mock_embedding_model.model_name = "text-embedding-v4"
self.mock_embedding_model.api_key = "test_embedding_key"
+ self.mock_embedding_model.dimensions = 1024
# Set the memory class based on MEMORY_TYPE
self.memory_type = MEMORY_TYPE