Skip to content

Build and run agents you can see, understand and trust.

[HOTFIX] Fix Gemini formatter local file mime_type from 'image/*' to proper media category (#736)

idontwanttosayawordc96c67869e08
diff --git a/src/agentscope/formatter/_gemini_formatter.py b/src/agentscope/formatter/_gemini_formatter.py
index b94880457..c9cbd5674 100644
--- a/src/agentscope/formatter/_gemini_formatter.py
+++ b/src/agentscope/formatter/_gemini_formatter.py
@@ -26,13 +26,15 @@ def _to_gemini_inline_data(url: str) -> dict:
parsed_url = urlparse(url)
extension = url.split(".")[-1].lower()
+ # Pre-calculate media type from extension (image/audio/video).
+ typ = None
+ for k, v in GeminiChatFormatter.supported_extensions.items():
+ if extension in v:
+ typ = k
+ break
+
if not os.path.exists(url) and parsed_url.scheme != "":
# Web url
- typ = None
- for k, v in GeminiChatFormatter.supported_extensions.items():
- if extension in v:
- typ = k
- break
if typ is None:
raise TypeError(
f"Unsupported file extension: {extension}, expected "
@@ -47,12 +49,18 @@ def _to_gemini_inline_data(url: str) -> dict:
elif os.path.exists(url):
# Local file
+ if typ is None:
+ raise TypeError(
+ f"Unsupported file extension: {extension}, expected "
+ f"{GeminiChatFormatter.supported_extensions}",
+ )
+
with open(url, "rb") as f:
data = base64.b64encode(f.read()).decode("utf-8")
return {
"data": data,
- "mime_type": f"image/{extension}",
+ "mime_type": f"{typ}/{extension}",
}
raise ValueError(
diff --git a/tests/formatter_gemini_test.py b/tests/formatter_gemini_test.py
index bdce9a4c6..a502accc5 100644
--- a/tests/formatter_gemini_test.py
+++ b/tests/formatter_gemini_test.py
@@ -245,7 +245,7 @@ class TestGeminiFormatter(IsolatedAsyncioTestCase):
{
"inline_data": {
"data": "ZmFrZSBhdWRpbyBjb250ZW50",
- "mime_type": "image/mp3",
+ "mime_type": "audio/mp3",
},
},
],
@@ -338,7 +338,7 @@ class TestGeminiFormatter(IsolatedAsyncioTestCase):
{
"inline_data": {
"data": "ZmFrZSBhdWRpbyBjb250ZW50",
- "mime_type": "image/mp3",
+ "mime_type": "audio/mp3",
},
},
{
@@ -476,7 +476,7 @@ class TestGeminiFormatter(IsolatedAsyncioTestCase):
{
"inline_data": {
"data": "ZmFrZSBhdWRpbyBjb250ZW50",
- "mime_type": "image/mp3",
+ "mime_type": "audio/mp3",
},
},
{