Skip to content

Build and run agents you can see, understand and trust.

feat(app): make the tool offload timeout configurable via create_app (#3606)

Felix Shifc3445e32fd5
diff --git a/src/agentscope/app/_app.py b/src/agentscope/app/_app.py
index 097495114..6e79097f6 100644
--- a/src/agentscope/app/_app.py
+++ b/src/agentscope/app/_app.py
@@ -129,6 +129,7 @@ def create_app(
extra_middlewares: list[FastAPIMiddleware] | None = None,
extra_agent_middlewares: AgentMiddlewareFactory | None = None,
extra_agent_tools: AgentToolFactory | None = None,
+ tool_offload_timeout_secs: float | None = 10.0,
custom_subagent_templates: list[SubAgentTemplate] | None = None,
custom_agent_cls: Type[Agent] | None = None,
resource_access_policy: ResourceAccessPolicyBase | None = None,
@@ -341,6 +342,7 @@ def create_app(
app.state.knowledge_base_manager = knowledge_base_manager
app.state.extra_agent_middlewares = extra_agent_middlewares
app.state.extra_agent_tools = extra_agent_tools
+ app.state.tool_offload_timeout_secs = tool_offload_timeout_secs
app.state.custom_agent_cls = custom_agent_cls
app.state.resource_access_policy = (
resource_access_policy or DenyAllResourceAccessPolicy()
diff --git a/src/agentscope/app/_lifespan.py b/src/agentscope/app/_lifespan.py
index 4bc7592c3..31e8a7e5c 100644
--- a/src/agentscope/app/_lifespan.py
+++ b/src/agentscope/app/_lifespan.py
@@ -176,6 +176,7 @@ async def lifespan(app: FastAPI) -> AsyncIterator[None]:
extra_agent_tools=app.state.extra_agent_tools,
custom_subagent_templates=app.state.custom_subagent_templates,
custom_agent_cls=app.state.custom_agent_cls,
+ tool_offload_timeout_secs=app.state.tool_offload_timeout_secs,
channel_clients=channel_clients,
)
app.state.chat_service = chat_service
diff --git a/src/agentscope/app/_service/_chat.py b/src/agentscope/app/_service/_chat.py
index 2c82b87df..97009acf1 100644
--- a/src/agentscope/app/_service/_chat.py
+++ b/src/agentscope/app/_service/_chat.py
@@ -170,6 +170,7 @@ class ChatService:
custom_agent_cls: type[Agent] | None = None,
extra_projectors: list[EventProjector] | None = None,
channel_clients: "ChannelClients | None" = None,
+ tool_offload_timeout_secs: float | None = 10.0,
) -> None:
"""Initialize chat service.
@@ -245,6 +246,9 @@ class ChatService:
self._access = resource_access_service
self._knowledge_base_manager = knowledge_base_manager
self._extra_agent_middlewares = extra_agent_middlewares
+ # ``None`` keeps slow tools inside the same reply instead of offloading
+ # them after the default 10 s cut-off (see #3330).
+ self._tool_offload_timeout_secs = tool_offload_timeout_secs
# Probed once (the service is built once per lifespan) so legacy
# three-argument factories keep working without the per-turn cost.
self._middlewares_take_workspace = False
@@ -1094,13 +1098,17 @@ class ChatService:
message_bus=self._message_bus,
session_id=session_id,
),
- ToolOffloadMiddleware(
- bg_manager=self._background_task_manager,
- message_bus=self._message_bus,
- user_id=user_id,
- agent_id=agent_id,
- ),
]
+ if self._tool_offload_timeout_secs is not None:
+ middlewares.append(
+ ToolOffloadMiddleware(
+ bg_manager=self._background_task_manager,
+ message_bus=self._message_bus,
+ user_id=user_id,
+ agent_id=agent_id,
+ timeout_secs=self._tool_offload_timeout_secs,
+ ),
+ )
# Equip the member middleware for loop control
if isinstance(team_ctx, _WorkerContext):
middlewares.append(