Solution for long term memory for agent coding CLIs and to facilitate handoff between different agent vendors
Rust
fix(hooks): write the capture-mode opt-in atomically
Samir Hanna Verza0e4642b7b8d2
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex fa2a7355..ce902bcf 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -88,6 +88,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0`docs/okf.md` and `docs/MIGRATION-2.0.md`.### Fixed+- `install-hooks` now writes the capture-mode opt-in atomically. It was+ written in place, and every reader maps an unrecognised value onto+ `denylist` — the less private mode — so a crash, a full disk or a killed+ `ai-memory upgrade` mid-write left a truncated file that silently reverted+ an `--capture-mode allowlist` opt-in to capture-by-default, which is exactly+ what `persist_capture_mode` documents it must never do. The fallback itself+ is correct and stays; the torn write that triggered it is gone. Now routed+ through the same `write_atomic` (tmp + fsync + rename) the rest of the CLI+ already uses, per the project's atomic-writes invariant.- `status` no longer overstates missing embeddings: empty-body pages —which no embedder can ever cover and the backfill skips by rule — areexcluded from the "latest pages missing" figure and reported on theirdiff --git a/crates/ai-memory-cli/src/commands/install_hooks.rs b/crates/ai-memory-cli/src/commands/install_hooks.rsindex 63b57e10..0bdcb6e4 100644--- a/crates/ai-memory-cli/src/commands/install_hooks.rs+++ b/crates/ai-memory-cli/src/commands/install_hooks.rs@@ -703,7 +703,11 @@ fn persist_capture_mode(data_dir: &Path, requested: Option<CaptureModeArg>) -> R};fs::create_dir_all(data_dir).with_context(|| format!("creating data dir {}", data_dir.display()))?;- fs::write(&path, format!("{value}\n"))+ // Atomically, because every reader maps an unrecognised value onto+ // `denylist`: a torn write would not corrupt the opt-in, it would silently+ // revert it to capture-by-default (`CONTRIBUTING.md`, "Atomic file writes+ // only").+ ai_memory_wiki::write_atomic(&path, format!("{value}\n").as_bytes()).with_context(|| format!("writing {}", path.display()))?;Ok(value.to_string())}@@ -5025,6 +5029,52 @@ mod tests {);}+ /// #446's opt-in is stored as a bare word, and every reader maps anything+ /// it does not recognise onto `denylist` — the *less* private mode. That+ /// fallback is deliberate and tested+ /// (`hook.rs`: `unreadable_or_unknown_mode_falls_back_to_denylist_not_allowlist`);+ /// what must never happen is the truncated file that triggers it. An+ /// in-place write truncates before it writes, so a crash, a full disk or a+ /// killed `upgrade` mid-write leaves exactly that — and the next hook run+ /// reads it as capture-by-default, silently undoing the opt-in the doc+ /// comment on `persist_capture_mode` promises to preserve.+ ///+ /// Replacement rather than truncation is the property that rules the window+ /// out, and it is observable: a rename gives the path a new inode, an+ /// in-place rewrite keeps the old one. This fails against `fs::write`.+ #[cfg(unix)]+ #[test]+ fn rewriting_the_capture_mode_replaces_the_file_rather_than_truncating_it() {+ use std::os::unix::fs::MetadataExt;++ let tmp = tempfile::tempdir().unwrap();+ let path = tmp.path().join(crate::commands::hook::CAPTURE_MODE_FILE);++ persist_capture_mode(tmp.path(), Some(CaptureModeArg::Allowlist)).unwrap();+ let before = fs::metadata(&path).unwrap().ino();++ persist_capture_mode(tmp.path(), Some(CaptureModeArg::Denylist)).unwrap();+ let after = fs::metadata(&path).unwrap().ino();++ assert_ne!(+ before, after,+ "the capture mode must be replaced by rename, not rewritten in \+ place: an in-place write is observable truncated, and a truncated \+ file reads back as denylist"+ );++ let leftovers: Vec<String> = fs::read_dir(tmp.path())+ .unwrap()+ .flatten()+ .map(|entry| entry.file_name().to_string_lossy().into_owned())+ .filter(|name| name.starts_with(".ai-memory-tmp."))+ .collect();+ assert!(+ leftovers.is_empty(),+ "the staging tempfile must not survive the write: {leftovers:?}"+ );+ }+#[test]fn absent_file_reports_the_historical_default() {let tmp = tempfile::tempdir().unwrap();