Skip to content

Solution for long term memory for agent coding CLIs and to facilitate handoff between different agent vendors

Rust

Merge main and align lint expiry handling

AkitaOnRails1dae19cc6a98
diff --cc CHANGELOG.md
index b8525d71,2a4107a2..fee7fa0b
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@@ -12,10 -12,11 +12,16 @@@ version in [`docs/changelog/`](docs/cha
## [Unreleased]
### Fixed
+- Fixed `memory_lint` reporting findings for TTL-expired pages. The lint pass
+ now omits expired pages before evaluating episodic staleness, rule suggestions,
+ duplicate titles, and vector or LLM contradiction candidates, preventing
+ findings for expired pages that are pending forget-sweep deletion.
++ ([#1390](https://github.com/akitaonrails/ai-memory/pull/1390))
+ - Fixed curator reporting TTL-expired pages as cold episodic candidates,
+ stale slots, or title collisions. The curator now filters out expired pages
+ before evaluating episodic retention scores, and uses `list_unexpired_pages`
+ when evaluating slot staleness and title uniqueness.
+ ([#1389](https://github.com/akitaonrails/ai-memory/pull/1389))
- Resolved percent-encoded ordinary Markdown link paths before indexing and web-route encoding, preserving spaces and Unicode filenames without double decoding or changing project scope. ([#1382](https://github.com/akitaonrails/ai-memory/pull/1382))
- Preserved indexed Markdown links with escaped or nested brackets in their labels, including links exported in OKF bundles and reindexed after import. ([#1380](https://github.com/akitaonrails/ai-memory/pull/1380))
- Fixed `open_feedback_findings` reporting feedback attached to TTL-expired
diff --cc crates/ai-memory-consolidate/src/lint.rs
index 8e507abb,6e0453d4..a9e71b26
--- a/crates/ai-memory-consolidate/src/lint.rs
+++ b/crates/ai-memory-consolidate/src/lint.rs
@@@ -375,9 -375,6 +375,9 @@@ fn rule_based_findings(candidates: &[De
std::collections::HashMap::new();
for c in candidates {
- if c.expires_at_us.is_some_and(|us| us <= now_us) {
++ if candidate_is_expired(c, now_us) {
+ continue;
+ }
// Stale: episodic, older than the lambda-derived threshold, zero accesses.
#[allow(clippy::cast_precision_loss)]
let age_days = (now_us - c.updated_at_us) as f64 / US_PER_DAY;
@@@ -476,6 -473,6 +476,10 @@@
out
}
++fn candidate_is_expired(candidate: &DecayCandidate, now_us: i64) -> bool {
++ candidate.expires_at_us.is_some_and(|us| us <= now_us)
++}
++
// ── A5: zero-LLM contradiction detection (cosine-similarity band) ──────────
/// Default lower edge (inclusive) of the likely-contradiction cosine-similarity
@@@ -602,7 -598,6 +606,7 @@@ async fn detected_contradiction_pass
.iter()
.filter(|c| matches!(c.tier, Tier::Semantic | Tier::Procedural))
.filter(|c| !c.path.as_str().starts_with("_lint/"))
- .filter(|c| !c.expires_at_us.is_some_and(|us| us <= now_us))
++ .filter(|c| !candidate_is_expired(c, now_us))
.collect();
eligible.sort_by(|a, b| {
a.access_count
@@@ -669,7 -663,6 +673,7 @@@ async fn contradiction_pass
let mut subset: Vec<&DecayCandidate> = candidates
.iter()
.filter(|c| matches!(c.tier, Tier::Semantic | Tier::Procedural))
- .filter(|c| !c.expires_at_us.is_some_and(|us| us <= now_us))
++ .filter(|c| !candidate_is_expired(c, now_us))
.collect();
if subset.len() < 2 {
return Ok(Vec::new());
@@@ -1093,75 -1086,6 +1097,104 @@@ mod tests
);
}
+ #[test]
+ fn rule_pass_skips_expired_pages() {
+ let past = Timestamp::now().as_microsecond() - 1_000_000;
+ let very_old = Timestamp::now().as_microsecond() - (90 * 86_400_000_000i64);
+ let expired_episodic = DecayCandidate {
+ id: ai_memory_core::PageId::new(),
+ path: ai_memory_core::PagePath::new("sessions/old.md").unwrap(),
+ tier: Tier::Episodic,
+ pinned: false,
+ updated_at_us: very_old,
+ access_count: 0,
+ last_accessed_at_us: None,
+ frontmatter_json: "{}".into(),
+ expires_at_us: Some(past),
+ salience: None,
+ compacted_at_us: None,
+ };
+ let expired_rule = DecayCandidate {
+ id: ai_memory_core::PageId::new(),
+ path: ai_memory_core::PagePath::new("_rules/expired.md").unwrap(),
+ tier: Tier::Semantic,
+ pinned: false,
+ updated_at_us: very_old,
+ access_count: 0,
+ last_accessed_at_us: None,
+ frontmatter_json: r#"{"kind": "rule"}"#.into(),
+ expires_at_us: Some(past),
+ salience: None,
+ compacted_at_us: None,
+ };
+ let live_page = DecayCandidate {
+ id: ai_memory_core::PageId::new(),
+ path: ai_memory_core::PagePath::new("concepts/live.md").unwrap(),
+ tier: Tier::Semantic,
+ pinned: false,
+ updated_at_us: Timestamp::now().as_microsecond(),
+ access_count: 1,
+ last_accessed_at_us: None,
+ frontmatter_json: r#"{"title": "Shared Title"}"#.into(),
+ expires_at_us: None,
+ salience: None,
+ compacted_at_us: None,
+ };
+ let expired_duplicate = DecayCandidate {
+ id: ai_memory_core::PageId::new(),
+ path: ai_memory_core::PagePath::new("concepts/expired-dupe.md").unwrap(),
+ tier: Tier::Semantic,
+ pinned: false,
+ updated_at_us: very_old,
+ access_count: 0,
+ last_accessed_at_us: None,
+ frontmatter_json: r#"{"title": "Shared Title"}"#.into(),
+ expires_at_us: Some(past),
+ salience: None,
+ compacted_at_us: None,
+ };
- let candidates = vec![
- expired_episodic,
- expired_rule,
- live_page,
- expired_duplicate,
- ];
++ let candidates = vec![expired_episodic, expired_rule, live_page, expired_duplicate];
+ let findings = rule_based_findings(&candidates, STALE_DAYS);
+ assert!(
+ findings.is_empty(),
+ "expired pages must not produce stale, rule_suggestion, or duplicate findings: {findings:?}"
+ );
+ }
+
++ #[test]
++ fn expiry_filter_keeps_future_ttl_and_excludes_the_boundary() {
++ let now_us = Timestamp::now().as_microsecond();
++ let candidate = DecayCandidate {
++ id: ai_memory_core::PageId::new(),
++ path: ai_memory_core::PagePath::new("concepts/ttl.md").unwrap(),
++ tier: Tier::Semantic,
++ pinned: false,
++ updated_at_us: now_us,
++ access_count: 0,
++ last_accessed_at_us: None,
++ frontmatter_json: "{}".into(),
++ expires_at_us: None,
++ salience: None,
++ compacted_at_us: None,
++ };
++
++ assert!(!candidate_is_expired(&candidate, now_us));
++ assert!(!candidate_is_expired(
++ &DecayCandidate {
++ expires_at_us: Some(now_us + 1),
++ ..candidate.clone()
++ },
++ now_us
++ ));
++ assert!(candidate_is_expired(
++ &DecayCandidate {
++ expires_at_us: Some(now_us),
++ ..candidate
++ },
++ now_us
++ ));
++ }
++
// ── LintFinding tolerant deserialization ─────────────────────────────
/// The old prompt used `summary`/`detail` instead of `message` and
diff --cc crates/ai-memory-consolidate/tests/suite/contradiction_lint.rs
index 9860f802,7e0f6a19..037c1777
--- a/crates/ai-memory-consolidate/tests/suite/contradiction_lint.rs
+++ b/crates/ai-memory-consolidate/tests/suite/contradiction_lint.rs
@@@ -322,56 -322,3 +322,46 @@@ async fn no_embeddings_is_a_clean_no_op
without_coord.findings
);
}
+
+/// An expired semantic page in the contradiction band must not produce a
+/// contradiction finding against an active page.
+#[tokio::test]
+async fn contradiction_pass_skips_expired_pages() {
+ let fx = seed_fixture().await;
- let live = write_semantic(
- &fx,
- "concepts/live-claim.md",
- "The retry budget is 5.",
- )
- .await;
- let expired = write_semantic(
- &fx,
- "concepts/expired-claim.md",
- "The retry budget is 3.",
- )
- .await;
++ let live = write_semantic(&fx, "concepts/live-claim.md", "The retry budget is 5.").await;
++ let expired = write_semantic(&fx, "concepts/expired-claim.md", "The retry budget is 3.").await;
+ seed_embedding(&fx, live, &[1.0, 0.0]);
+ seed_embedding(&fx, expired, &[0.6, 0.8]);
+
+ {
+ let conn = rusqlite::Connection::open(fx.tmp.path().join("db/memory.sqlite")).unwrap();
+ conn.pragma_update(None, "busy_timeout", 5_000).unwrap();
+ conn.execute(
+ "UPDATE pages SET expires_at = 1 \
+ WHERE workspace_id = ?1 AND project_id = ?2 AND path = ?3 AND is_latest = 1",
+ params![
+ fx.ws.as_bytes(),
+ fx.proj.as_bytes(),
+ "concepts/expired-claim.md"
+ ],
+ )
+ .unwrap();
+ }
+
+ let report = run_lint(
+ &fx.store.reader,
+ &fx.wiki,
+ None,
+ fx.ws,
+ fx.proj,
+ options(coord()),
+ )
+ .await
+ .unwrap();
+
+ assert!(
+ !report.findings.iter().any(|f| f.kind == "contradiction"),
+ "expired pages must not produce contradiction findings: {:?}",
+ report.findings
+ );
+}