Skip to content

Solution for long term memory for agent coding CLIs and to facilitate handoff between different agent vendors

Rust

fix(install-hooks): validate --as-user against the resolved token

Yi-111-a2871123169f5
diff --git a/CHANGELOG.md b/CHANGELOG.md
index bf0c92f3..33158f34 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]
+### Fixed
+- `install-hooks --apply --as-user <user> --auth-token <key>` no longer fails
+ with `--as-user '<user>' requires --auth-token` when the token was supplied.
+ The guard was handed the *rendered* credential, which is deliberately `None`
+ on the #552 secure path (the token is persisted under the data dir for the
+ hooks to read), so the recommended multi-user install command in
+ `docs/users.md` and `install-hooks --help` bailed on every native install
+ while reporting the token as absent. It now validates the resolved token.
+ `install-hooks` without `--as-user` was unaffected, and `--as-user` with no
+ token anywhere still bails. (#993)
+
## [2.4.2] - 2026-09-29
### Changed
diff --git a/crates/ai-memory-cli/src/commands/install_hooks.rs b/crates/ai-memory-cli/src/commands/install_hooks.rs
index 513a3778..f61535bf 100644
--- a/crates/ai-memory-cli/src/commands/install_hooks.rs
+++ b/crates/ai-memory-cli/src/commands/install_hooks.rs
@@ -454,7 +454,13 @@ pub fn run(config: &Config, mut args: InstallHooksArgs) -> Result<()> {
// to. Mismatch between `--as-user` and the actual token's owner is
// the operator's concern; we don't reach back to the server to
// verify (keeps install-hooks offline-capable).
- validate_as_user(args.as_user.as_deref(), auth)?;
+ //
+ // Validate against the resolved token, not the rendered one. `auth` is
+ // deliberately `None` on the #552 secure path — the token was persisted
+ // under the data dir for the hooks to read — so passing it here made
+ // `--apply --as-user X --auth-token T` bail on the very combination
+ // docs/users.md recommends, with a message saying the token was absent.
+ validate_as_user(args.as_user.as_deref(), auth_token_owned.as_deref())?;
if let Some(user) = args.as_user.as_deref().filter(|s| !s.trim().is_empty()) {
eprintln!("[ai-memory] hooks installing for user: {user}");
}
@@ -7996,6 +8002,53 @@ model = "gpt-5"
);
}
+ /// #993 regression guard: `--apply --as-user X --auth-token T` is the
+ /// command docs/users.md tells operators to run, and it failed on every
+ /// native install. The guard was handed the rendered credential, which is
+ /// `None` precisely when the token was persisted (#552), so it reported the
+ /// token as missing while the token sat under the data dir. The unit tests
+ /// on `validate_as_user` itself could not see it — the wiring was wrong,
+ /// not the function.
+ #[test]
+ fn apply_with_as_user_succeeds_when_the_token_is_persisted() {
+ let home = TempDir::new().unwrap();
+ let cfg_dir = TempDir::new().unwrap();
+ let settings = cfg_dir.path().join("settings.json");
+ std::fs::write(&settings, "{}").unwrap();
+
+ let config = crate::config::Config::load(None, Some(home.path().to_path_buf())).unwrap();
+
+ let args = InstallHooksArgs {
+ agent: AgentChoice::ClaudeCode,
+ apply: true,
+ server_url: Some("http://127.0.0.1:49374".to_string()),
+ auth_token: Some("ALICE-KEY-993".to_string()),
+ as_user: Some("alice".to_string()),
+ config_file: Some(settings.clone()),
+ hooks_dir: Some(
+ std::path::PathBuf::from(env!("CARGO_MANIFEST_DIR")).join("../../hooks"),
+ ),
+ ..default_hook_args()
+ };
+
+ // The whole point of the fix: persisting the token must not turn a
+ // present `--auth-token` into an "absent" one for the `--as-user` guard.
+ run(&config, args).expect("install-hooks --apply --as-user with a token must succeed");
+
+ // And the attribution it promised is real: the token is on disk for the
+ // hooks, and still absent from the agent's own config.
+ assert_eq!(
+ crate::config::read_hook_auth_token(&config.data_dir).as_deref(),
+ Some("ALICE-KEY-993"),
+ "alice's key must be persisted where the hook reads it"
+ );
+ let rendered = std::fs::read_to_string(&settings).unwrap();
+ assert!(
+ !rendered.contains("ALICE-KEY-993"),
+ "the bearer must not reach the agent config: {rendered}"
+ );
+ }
+
/// F5 (docker-wrapper audit), the regression guard: when the bearer
/// *cannot* be persisted under the data dir, `--apply` must still install
/// working hooks by embedding the credential inline instead of aborting the