Solution for long term memory for agent coding CLIs and to facilitate handoff between different agent vendors
Rust
fix(embed): reject malformed embedding values
AkitaOnRails521548c8be8b
diff --git a/crates/ai-memory-llm/src/embedding.rs b/crates/ai-memory-llm/src/embedding.rsindex 1714b233..19025d64 100644--- a/crates/ai-memory-llm/src/embedding.rs+++ b/crates/ai-memory-llm/src/embedding.rs@@ -150,11 +150,16 @@ fn parse_openai_embedding_values(body: &str, status: u16) -> LlmResult<Vec<f32>>512,),})?;- let mut out = Vec::new();+ let mut out = Vec::with_capacity(emb.len());for n in emb {- if let Some(f) = n.as_f64() {- out.push(f as f32);- }+ let f = n.as_f64().ok_or_else(|| LlmError::Provider {+ status,+ body: truncate_with_ellipsis(+ &format!("non-numeric embedding value in data[0]; body={body}"),+ 512,+ ),+ })?;+ out.push(f as f32);}if !out.is_empty() {return Ok(out);@@ -489,4 +494,11 @@ mod tests {let err = parse_openai_embedding_values(body, 502).unwrap_err();assert!(matches!(err, LlmError::Provider { status: 502, .. }));}++ #[test]+ fn parse_openai_embedding_rejects_non_numeric_values() {+ let body = r#"{"data":[{"embedding":[0.1,"oops",0.3]}]}"#;+ let err = parse_openai_embedding_values(body, 200).unwrap_err();+ assert!(matches!(err, LlmError::Provider { status: 200, .. }));+ }}