Skip to content

Solution for long term memory for agent coding CLIs and to facilitate handoff between different agent vendors

Rust

fix(web): make the OKF upgrade dialog keyboard accessible

Peterson Salme696325348c7e
diff --git a/CHANGELOG.md b/CHANGELOG.md
index fee7fa0b..36a13d7b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -12,6 +12,9 @@ version in [`docs/changelog/`](docs/changelog/):
## [Unreleased]
### Fixed
+- Fixed the `/web` OKF upgrade dialog ignoring the keyboard: it now takes focus
+ when it opens, closes on Escape, keeps Tab inside, and returns focus when
+ closed. (#TBD)
- Fixed `memory_lint` reporting findings for TTL-expired pages. The lint pass
now omits expired pages before evaluating episodic staleness, rule suggestions,
duplicate titles, and vector or LLM contradiction candidates, preventing
diff --git a/crates/ai-memory-web/src/mount.rs b/crates/ai-memory-web/src/mount.rs
index 9e15e5b0..07837b82 100644
--- a/crates/ai-memory-web/src/mount.rs
+++ b/crates/ai-memory-web/src/mount.rs
@@ -846,6 +846,13 @@ mod tests {
"dismissal key must be migration-stamped"
);
assert!(body.contains("Unpack the archive"));
+ // Keyboard contract for the aria-modal dialog.
+ assert!(
+ body.contains(r#"id="okf-dialog-close" type="button""#),
+ "close button must not default to submit"
+ );
+ assert!(body.contains("\"Escape\"") && body.contains("keydown"));
+ assert!(body.contains("closeBtn.focus()"), "dialog must take focus");
// Archive deleted → dialog still explains, recovery falls back
// to the git checkpoint; the inline banner is gone.
diff --git a/crates/ai-memory-web/templates/projects.html b/crates/ai-memory-web/templates/projects.html
index 3d834446..17173439 100644
--- a/crates/ai-memory-web/templates/projects.html
+++ b/crates/ai-memory-web/templates/projects.html
@@ -94,7 +94,7 @@
<input id="okf-dialog-dismiss" type="checkbox" class="rounded border-slate-300 dark:border-slate-600">
Do not show me again
</label>
- <button id="okf-dialog-close" class="rounded-md bg-slate-900 dark:bg-slate-100 text-white dark:text-slate-900 text-sm font-medium px-4 py-2 hover:bg-slate-700 dark:hover:bg-slate-300">Got it</button>
+ <button id="okf-dialog-close" type="button" class="rounded-md bg-slate-900 dark:bg-slate-100 text-white dark:text-slate-900 text-sm font-medium px-4 py-2 hover:bg-slate-700 dark:hover:bg-slate-300">Got it</button>
</div>
</div>
</div>
@@ -106,13 +106,39 @@
try {
if (localStorage.getItem(key) === "1") return;
} catch (e) { /* storage blocked: still show the dialog */ }
- overlay.classList.remove("hidden");
- document.getElementById("okf-dialog-close").addEventListener("click", function () {
- if (document.getElementById("okf-dialog-dismiss").checked) {
+ var closeBtn = document.getElementById("okf-dialog-close");
+ var dismiss = document.getElementById("okf-dialog-dismiss");
+ // aria-modal alone moves no focus: remember the opener to hand it back.
+ var opener = document.activeElement;
+ function close() {
+ if (dismiss.checked) {
try { localStorage.setItem(key, "1"); } catch (e) { /* best effort */ }
}
overlay.classList.add("hidden");
- });
+ document.removeEventListener("keydown", onKey);
+ if (opener && opener.isConnected && typeof opener.focus === "function") opener.focus();
+ }
+ // Only two focusables, so Tab wraps by hand to keep focus inside the modal.
+ function onKey(e) {
+ if (e.key === "Escape") {
+ e.preventDefault();
+ close();
+ } else if (e.key === "Tab") {
+ var first = e.shiftKey ? closeBtn : dismiss;
+ var next = e.shiftKey ? dismiss : closeBtn;
+ if (document.activeElement === first) {
+ e.preventDefault();
+ next.focus();
+ } else if (document.activeElement !== next) {
+ e.preventDefault();
+ dismiss.focus();
+ }
+ }
+ }
+ overlay.classList.remove("hidden");
+ closeBtn.addEventListener("click", close);
+ document.addEventListener("keydown", onKey);
+ closeBtn.focus();
})();
</script>
{% endif %}