Solution for long term memory for agent coding CLIs and to facilitate handoff between different agent vendors
Rust
fix(status): preserve the derived status API
AkitaOnRails9fde3800bb34
diff --git a/crates/ai-memory-mcp/src/admin.rs b/crates/ai-memory-mcp/src/admin.rsindex fdd035a7..e851f6a3 100644--- a/crates/ai-memory-mcp/src/admin.rs+++ b/crates/ai-memory-mcp/src/admin.rs@@ -1314,11 +1314,15 @@ async fn handle_status(State(state): State<Arc<AdminState>>) -> impl IntoRespons// configured the historical "no vector at all" count is kept.let configured_embedding = state.embedder.as_deref().map(stored_embedding_identity);match state.reader.status_counts().await {- Ok(counts) => match state- .reader- .derived_index_status(configured_embedding)- .await- {+ Ok(counts) => match match configured_embedding {+ Some(identity) => {+ state+ .reader+ .derived_index_status_for_embedding(identity)+ .await+ }+ None => state.reader.derived_index_status().await,+ } {Ok(derived) => {// Three pragma reads; a failure here must not take down the// whole status response, which is also the health probe.diff --git a/crates/ai-memory-mcp/tests/suite/web_search_parity.rs b/crates/ai-memory-mcp/tests/suite/web_search_parity.rsindex cc0022da..b5226433 100644--- a/crates/ai-memory-mcp/tests/suite/web_search_parity.rs+++ b/crates/ai-memory-mcp/tests/suite/web_search_parity.rs@@ -148,7 +148,7 @@ async fn seed() -> Seeded {.await.unwrap();}- let status = store.reader.derived_index_status(None).await.unwrap();+ let status = store.reader.derived_index_status().await.unwrap();assert_eq!(status.latest_pages_missing_embeddings, 0,"every seeded page must carry a vector"diff --git a/crates/ai-memory-store/src/lib.rs b/crates/ai-memory-store/src/lib.rsindex 304a61c9..ec94a5c1 100644--- a/crates/ai-memory-store/src/lib.rs+++ b/crates/ai-memory-store/src/lib.rs@@ -8742,7 +8742,7 @@ mod tests {.upsert_page(sample_page(ws, proj, "notes/empty.md", " ")).await.unwrap();- let derived = store.reader.derived_index_status(None).await.unwrap();+ let derived = store.reader.derived_index_status().await.unwrap();assert_eq!(derived.latest_pages_missing_embeddings, 1, "{derived:?}");assert_eq!(derived.latest_pages_unembeddable, 1, "{derived:?}");}@@ -8804,13 +8804,13 @@ mod tests {// Historical behaviour: the page carries a vector, so nothing is// missing.- let derived = store.reader.derived_index_status(None).await.unwrap();+ let derived = store.reader.derived_index_status().await.unwrap();assert_eq!(derived.latest_pages_missing_embeddings, 0, "{derived:?}");// Configured triple A: the page is covered by its own vector.let derived = store.reader- .derived_index_status(Some(triple_a.clone()))+ .derived_index_status_for_embedding(triple_a.clone()).await.unwrap();assert_eq!(derived.latest_pages_missing_embeddings, 0, "{derived:?}");@@ -8819,7 +8819,7 @@ mod tests {// only vector is stale for the model in use.let derived = store.reader- .derived_index_status(Some(triple_b.clone()))+ .derived_index_status_for_embedding(triple_b.clone()).await.unwrap();assert_eq!(derived.latest_pages_missing_embeddings, 1, "{derived:?}");@@ -8835,17 +8835,17 @@ mod tests {insert_embedding("notes/fresh.md", "prov-b", "model-b", 16);let derived = store.reader- .derived_index_status(Some(triple_a.clone()))+ .derived_index_status_for_embedding(triple_a.clone()).await.unwrap();assert_eq!(derived.latest_pages_missing_embeddings, 1, "{derived:?}");let derived = store.reader- .derived_index_status(Some(triple_b.clone()))+ .derived_index_status_for_embedding(triple_b.clone()).await.unwrap();assert_eq!(derived.latest_pages_missing_embeddings, 1, "{derived:?}");- let derived = store.reader.derived_index_status(None).await.unwrap();+ let derived = store.reader.derived_index_status().await.unwrap();assert_eq!(derived.latest_pages_missing_embeddings, 0, "{derived:?}");}@@ -8880,7 +8880,7 @@ mod tests {},];store.writer.upsert_page(page).await.unwrap();- let derived = store.reader.derived_index_status(None).await.unwrap();+ let derived = store.reader.derived_index_status().await.unwrap();assert_eq!(derived.typed_links_from_latest_pages,vec![("fixes".to_string(), 1)],diff --git a/crates/ai-memory-store/src/reader.rs b/crates/ai-memory-store/src/reader.rsindex 91fbc96d..7f79285d 100644--- a/crates/ai-memory-store/src/reader.rs+++ b/crates/ai-memory-store/src/reader.rs@@ -11418,14 +11418,10 @@ impl ReaderPool {/// Return health counters for derived indexes and link/embedding state.///- /// `configured_embedding` is the `(provider, model, dim)` triple the- /// configured embedder stores rows under (`model_identity`, not the- /// wire model name), or `None` when no embedder is configured. With a- /// triple, a latest page counts as missing an embedding when it has no- /// vector under *that* triple: a vector from an old model is stale and- /// ignored by retrieval, so it must not hide the gap a backfill has to- /// fill. With `None`, "missing" keeps its historical meaning: no vector- /// at all.+ /// "Missing" keeps its historical meaning here: a latest page has no+ /// vector at all. Server health surfaces with a configured embedder use+ /// [`Self::derived_index_status_for_embedding`] so vectors from an old+ /// model do not hide the current backfill gap.////// These checks are intentionally read-only and derived-index-safe: they/// report drift but do not repair it. Rebuild/backfill paths stay behind@@ -11433,7 +11429,24 @@ impl ReaderPool {////// # Errors/// Propagates any SQL or pool error.- pub async fn derived_index_status(+ pub async fn derived_index_status(&self) -> StoreResult<DerivedIndexStatus> {+ self.derived_index_status_inner(None).await+ }++ /// Return derived-index health while judging embedding coverage against+ /// the configured `(provider, model, dim)` identity.+ ///+ /// # Errors+ /// Propagates any SQL or pool error.+ pub async fn derived_index_status_for_embedding(+ &self,+ configured_embedding: (String, String, u32),+ ) -> StoreResult<DerivedIndexStatus> {+ self.derived_index_status_inner(Some(configured_embedding))+ .await+ }++ async fn derived_index_status_inner(&self,configured_embedding: Option<(String, String, u32)>,) -> StoreResult<DerivedIndexStatus> {diff --git a/crates/ai-memory-store/tests/suite/fts_drift_status.rs b/crates/ai-memory-store/tests/suite/fts_drift_status.rsindex c233fa17..b7cb88ee 100644--- a/crates/ai-memory-store/tests/suite/fts_drift_status.rs+++ b/crates/ai-memory-store/tests/suite/fts_drift_status.rs@@ -46,7 +46,7 @@ async fn page_fts_rows_report_index_drift() {.await.unwrap();- let before = store.reader.derived_index_status(None).await.unwrap();+ let before = store.reader.derived_index_status().await.unwrap();assert_eq!(before.pages_rows, 1);assert_eq!(before.pages_fts_rows, 1,@@ -73,7 +73,7 @@ async fn page_fts_rows_report_index_drift() {assert_eq!(hits, 0, "the entry really left the index");}- let after = store.reader.derived_index_status(None).await.unwrap();+ let after = store.reader.derived_index_status().await.unwrap();assert_eq!(after.pages_rows, 1, "the source row is untouched");assert_eq!(after.pages_fts_rows, 0,@@ -129,7 +129,7 @@ async fn observation_fts_rows_report_index_drift() {.await.unwrap();- let before = store.reader.derived_index_status(None).await.unwrap();+ let before = store.reader.derived_index_status().await.unwrap();assert_eq!(before.observations_rows, 1);assert_eq!(before.observations_fts_rows, 1,@@ -154,7 +154,7 @@ async fn observation_fts_rows_report_index_drift() {assert_eq!(hits, 0, "the entry really left the index");}- let after = store.reader.derived_index_status(None).await.unwrap();+ let after = store.reader.derived_index_status().await.unwrap();assert_eq!(after.observations_rows, 1, "the source row is untouched");assert_eq!(after.observations_fts_rows, 0,diff --git a/crates/ai-memory-store/tests/suite/reclaim_ledger_versions.rs b/crates/ai-memory-store/tests/suite/reclaim_ledger_versions.rsindex 74417d96..99a03d75 100644--- a/crates/ai-memory-store/tests/suite/reclaim_ledger_versions.rs+++ b/crates/ai-memory-store/tests/suite/reclaim_ledger_versions.rs@@ -483,7 +483,7 @@ async fn a_reclaimed_ledger_row_leaves_no_searchable_text_behind() {.await.unwrap();- let drift = store.reader.derived_index_status(None).await.unwrap();+ let drift = store.reader.derived_index_status().await.unwrap();assert_eq!(drift.pages_fts_rows, drift.pages_rows,"the rebuilt index agrees with the content table again",diff --git a/crates/ai-memory-store/tests/suite/stress_writer_throughput.rs b/crates/ai-memory-store/tests/suite/stress_writer_throughput.rsindex 4691ff64..d4ad56a2 100644--- a/crates/ai-memory-store/tests/suite/stress_writer_throughput.rs+++ b/crates/ai-memory-store/tests/suite/stress_writer_throughput.rs@@ -143,7 +143,7 @@ async fn a_burst_larger_than_the_queue_applies_backpressure_and_loses_nothing()t.await.unwrap();}- let status = store.reader.derived_index_status(None).await.unwrap();+ let status = store.reader.derived_index_status().await.unwrap();assert_eq!(status.observations_rows, BURST as u64,"every write in a burst larger than the queue must land: backpressure, \diff --git a/crates/ai-memory-web/src/routes/health.rs b/crates/ai-memory-web/src/routes/health.rsindex d507fe83..74a091a8 100644--- a/crates/ai-memory-web/src/routes/health.rs+++ b/crates/ai-memory-web/src/routes/health.rs@@ -46,11 +46,15 @@ pub(crate) async fn handler(embedder.dim(),)});- let derived = match state- .reader- .derived_index_status(configured_embedding.clone())- .await- {+ let derived = match match configured_embedding.clone() {+ Some(identity) => {+ state+ .reader+ .derived_index_status_for_embedding(identity)+ .await+ }+ None => state.reader.derived_index_status().await,+ } {Ok(derived) => derived,Err(error) => return internal(error),};