Solution for long term memory for agent coding CLIs and to facilitate handoff between different agent vendors
Rust
feat(auto-improve): make the reviewer's readable folders configurable
Abhishek Sharmabdff55c56811
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex 0212547d..bee4ee78 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -17,6 +17,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0name), the feature set is unchanged, and the 23-tool MCP surface isunaffected. (#794)+### Added+- `auto_improve.patchable_page_prefixes` makes the folders whose page bodies the+ reviewer reads configurable, defaulting to the historical `_rules/` and+ `procedures/`. Only those two folders' contents were ever sent; every other+ page reached the model as a single title line, so a project keeping its+ durable knowledge in `decisions/` or `gotchas/` — with no `_rules/` pages at+ all — sent no page bodies, and the reviewer re-proposed invariants that were+ already written down, at high confidence, indefinitely. Existing configs are+ unchanged. (#834)+### Docs- Stopped recommending `AI_MEMORY_LLM_MODEL=gpt-5-mini` for the `openai-oauth`provider in `docs/llm-providers.md` and `docs/install.md`. The Codex/ChatGPTdiff --git a/crates/ai-memory-cli/src/commands/auto_improve.rs b/crates/ai-memory-cli/src/commands/auto_improve.rsindex 6812aff3..633a3f50 100644--- a/crates/ai-memory-cli/src/commands/auto_improve.rs+++ b/crates/ai-memory-cli/src/commands/auto_improve.rs@@ -20,6 +20,7 @@ struct AutoImproveRequest {max_input_tokens: usize,max_proposals_per_run: usize,max_patchable_pages: usize,+ patchable_page_prefixes: Vec<String>,max_patchable_body_chars: usize,max_edits_per_proposal: usize,max_edit_content_chars: usize,@@ -83,6 +84,7 @@ pub async fn run(config: &Config, args: AutoImproveArgs) -> Result<()> {max_input_tokens: args.max_input_tokens.unwrap_or(settings.max_input_tokens),max_proposals_per_run: args.max_proposals.unwrap_or(settings.max_proposals_per_run),max_patchable_pages: settings.max_patchable_pages,+ patchable_page_prefixes: settings.patchable_page_prefixes.clone(),max_patchable_body_chars: settings.max_patchable_body_chars,max_edits_per_proposal: settings.max_edits_per_proposal,max_edit_content_chars: settings.max_edit_content_chars,diff --git a/crates/ai-memory-cli/src/commands/serve.rs b/crates/ai-memory-cli/src/commands/serve.rsindex 6e1ffeb0..2f22e9b3 100644--- a/crates/ai-memory-cli/src/commands/serve.rs+++ b/crates/ai-memory-cli/src/commands/serve.rs@@ -2041,6 +2041,7 @@ fn auto_improve_review_config_from_settings(proposal_actor: settings.proposal_actor.clone(),pending_path: settings.pending_path.clone(),max_patchable_pages: settings.max_patchable_pages,+ patchable_page_prefixes: settings.patchable_page_prefixes.clone(),max_patchable_body_chars: settings.max_patchable_body_chars,max_edits_per_proposal: settings.max_edits_per_proposal,max_edit_content_chars: settings.max_edit_content_chars,diff --git a/crates/ai-memory-cli/src/config.rs b/crates/ai-memory-cli/src/config.rsindex 7f6dae36..ea2e9d99 100644--- a/crates/ai-memory-cli/src/config.rs+++ b/crates/ai-memory-cli/src/config.rs@@ -836,8 +836,15 @@ pub struct AutoImproveSettings {pub max_input_tokens: usize,/// Maximum validated proposals returned from one run.pub max_proposals_per_run: usize,- /// Maximum existing _rules/ and procedures/ pages included for patch proposals.+ /// Maximum existing patchable pages included for patch proposals.pub max_patchable_pages: usize,+ /// Wiki folder prefixes whose page bodies the reviewer may read.+ ///+ /// Defaults to `_rules/` and `procedures/`. A project that keeps durable+ /// knowledge elsewhere — `decisions/`, `gotchas/` — can add those folders so+ /// the reviewer stops proposing what is already written there (#834).+ #[serde(default = "default_patchable_page_prefixes")]+ pub patchable_page_prefixes: Vec<String>,/// Maximum body chars rendered per patchable target page.pub max_patchable_body_chars: usize,/// Maximum patch edits per proposal.@@ -941,6 +948,7 @@ impl Default for AutoImproveSettings {max_input_tokens: ai_memory_consolidate::DEFAULT_AUTO_IMPROVE_MAX_INPUT_TOKENS,max_proposals_per_run: ai_memory_consolidate::DEFAULT_AUTO_IMPROVE_MAX_PROPOSALS,max_patchable_pages: ai_memory_consolidate::DEFAULT_AUTO_IMPROVE_MAX_PATCHABLE_PAGES,+ patchable_page_prefixes: default_patchable_page_prefixes(),max_patchable_body_chars:ai_memory_consolidate::DEFAULT_AUTO_IMPROVE_MAX_PATCHABLE_BODY_CHARS,max_edits_per_proposal:@@ -2002,6 +2010,15 @@ fn write_secret(path: &Path, contents: &str) -> std::io::Result<()> {}}+/// The historical patchable folders, kept as the default so an existing config+/// that omits the key behaves exactly as before (#834).+fn default_patchable_page_prefixes() -> Vec<String> {+ ai_memory_consolidate::DEFAULT_AUTO_IMPROVE_PATCHABLE_PAGE_PREFIXES+ .iter()+ .map(|p| (*p).to_string())+ .collect()+}+fn default_data_dir() -> PathBuf {dirs::data_local_dir().unwrap_or_else(|| PathBuf::from("."))diff --git a/crates/ai-memory-consolidate/src/auto_improve.rs b/crates/ai-memory-consolidate/src/auto_improve.rsindex 6136bc66..4b0c0e95 100644--- a/crates/ai-memory-consolidate/src/auto_improve.rs+++ b/crates/ai-memory-consolidate/src/auto_improve.rs@@ -28,6 +28,20 @@ const PROMPT_RESERVE_TOKENS: usize = 1_000;const MAX_PROPOSAL_BODY_CHARS: usize = 32_000;/// Default number of existing pages included as patchable context.pub const DEFAULT_AUTO_IMPROVE_MAX_PATCHABLE_PAGES: usize = 8;++/// Wiki folders whose page bodies the reviewer may read, by path prefix.+///+/// This list decides which of a project's durable knowledge the model can see+/// before it proposes anything. `render_recent_pages` gives every other page as+/// one line — path, title, kind, updated_at — so a page outside these folders+/// reaches the reviewer as a title and nothing else, and the model cannot tell+/// that what it is about to propose is already written down (#834).+///+/// The default is the historical pair. It is a default rather than a constant+/// because folder choice should not silently decide model visibility: a project+/// that keeps its invariants in `decisions/` or `gotchas/` — which the wiki's own+/// conventions encourage — can add them instead of restructuring its wiki.+pub const DEFAULT_AUTO_IMPROVE_PATCHABLE_PAGE_PREFIXES: [&str; 2] = ["_rules/", "procedures/"];/// Default maximum body chars rendered for one patchable target page.pub const DEFAULT_AUTO_IMPROVE_MAX_PATCHABLE_BODY_CHARS: usize = 8_000;/// Default maximum patch edits per proposal.@@ -134,8 +148,14 @@ pub struct AutoImproveReviewConfig {pub proposal_actor: String,/// Wiki-relative pending proposal sidecar folder.pub pending_path: String,- /// Maximum existing _rules/ and procedures/ pages included for patch proposals.+ /// Maximum existing patchable pages included for patch proposals.pub max_patchable_pages: usize,+ /// Wiki folder prefixes whose page bodies the reviewer may read.+ ///+ /// Defaults to [`DEFAULT_AUTO_IMPROVE_PATCHABLE_PAGE_PREFIXES`]. Pages outside+ /// these folders are still listed by title, but their content is never sent,+ /// so the reviewer cannot notice that a proposal duplicates them (#834).+ pub patchable_page_prefixes: Vec<String>,/// Maximum body chars rendered per patchable target page.pub max_patchable_body_chars: usize,/// Maximum patch edits per proposal.@@ -172,6 +192,10 @@ impl Default for AutoImproveReviewConfig {proposal_actor: DEFAULT_AUTO_IMPROVE_PROPOSAL_ACTOR.into(),pending_path: DEFAULT_AUTO_IMPROVE_PENDING_PATH.into(),max_patchable_pages: DEFAULT_AUTO_IMPROVE_MAX_PATCHABLE_PAGES,+ patchable_page_prefixes: DEFAULT_AUTO_IMPROVE_PATCHABLE_PAGE_PREFIXES+ .iter()+ .map(|p| (*p).to_string())+ .collect(),max_patchable_body_chars: DEFAULT_AUTO_IMPROVE_MAX_PATCHABLE_BODY_CHARS,max_edits_per_proposal: DEFAULT_AUTO_IMPROVE_MAX_EDITS_PER_PROPOSAL,max_edit_content_chars: DEFAULT_AUTO_IMPROVE_MAX_EDIT_CONTENT_CHARS,@@ -951,6 +975,18 @@ fn normalize_title(title: &str) -> String {.to_lowercase()}+/// Whether the reviewer may read this page's body, by folder prefix (#834).+///+/// An empty prefix list means no page body is sent, which is the honest reading+/// of "no folders are patchable" — not "every folder is". An empty *prefix*+/// would match every path, so it is ignored rather than silently opening the+/// whole wiki.+pub(crate) fn is_patchable_path(path: &str, prefixes: &[String]) -> bool {+ prefixes+ .iter()+ .any(|prefix| !prefix.is_empty() && path.starts_with(prefix.as_str()))+}+pub(crate) async fn load_patchable_pages(reader: &ReaderPool,workspace_id: WorkspaceId,@@ -961,7 +997,7 @@ pub(crate) async fn load_patchable_pages(let mut out = Vec::new();for page in recent_pages.iter()- .filter(|p| p.path.starts_with("_rules/") || p.path.starts_with("procedures/"))+ .filter(|p| is_patchable_path(&p.path, &cfg.patchable_page_prefixes)).take(cfg.max_patchable_pages){if let Some(body) = reader@@ -1987,6 +2023,10 @@ mod tests {proposal_actor: "auto_improve".into(),pending_path: "_pending/auto-improve".into(),max_patchable_pages: DEFAULT_AUTO_IMPROVE_MAX_PATCHABLE_PAGES,+ patchable_page_prefixes: DEFAULT_AUTO_IMPROVE_PATCHABLE_PAGE_PREFIXES+ .iter()+ .map(|p| (*p).to_string())+ .collect(),max_patchable_body_chars: DEFAULT_AUTO_IMPROVE_MAX_PATCHABLE_BODY_CHARS,max_edits_per_proposal: DEFAULT_AUTO_IMPROVE_MAX_EDITS_PER_PROPOSAL,max_edit_content_chars: DEFAULT_AUTO_IMPROVE_MAX_EDIT_CONTENT_CHARS,@@ -2158,6 +2198,60 @@ mod tests {);}+ // #834: the folder filter decides which of a project's durable knowledge the+ // reviewer can read at all. Everything outside it arrives as a title, so the+ // model cannot tell that a proposal duplicates a page that already exists.+ #[test]+ fn default_prefixes_match_the_historical_pair() {+ let cfg = AutoImproveReviewConfig::default();+ assert_eq!(cfg.patchable_page_prefixes, vec!["_rules/", "procedures/"]);+ }++ #[test]+ fn the_default_still_hides_decisions_and_gotchas() {+ // Pinning the reported blindness rather than only the fix: this is the+ // behaviour a project with no `_rules/` pages actually gets today.+ let prefixes = AutoImproveReviewConfig::default().patchable_page_prefixes;+ assert!(is_patchable_path("_rules/testing.md", &prefixes));+ assert!(is_patchable_path("procedures/release.md", &prefixes));+ assert!(!is_patchable_path("decisions/0001-storage.md", &prefixes));+ assert!(!is_patchable_path("gotchas/sqlite-wal.md", &prefixes));+ }++ #[test]+ fn configuring_a_folder_makes_its_pages_readable() {+ let prefixes = vec!["_rules/".to_string(), "decisions/".to_string()];+ assert!(is_patchable_path("decisions/0001-storage.md", &prefixes));+ assert!(is_patchable_path("_rules/testing.md", &prefixes));+ // Not configured, so still title-only.+ assert!(!is_patchable_path("procedures/release.md", &prefixes));+ }++ #[test]+ fn an_empty_list_reads_no_page_bodies() {+ // "No folders are patchable" must not mean "every folder is".+ assert!(!is_patchable_path("_rules/testing.md", &[]));+ assert!(!is_patchable_path("decisions/0001.md", &[]));+ }++ #[test]+ fn an_empty_prefix_does_not_open_the_whole_wiki() {+ // `"".starts_with` matches every path, so a stray empty entry would turn+ // the filter off silently. It is ignored instead.+ let prefixes = vec![String::new()];+ assert!(!is_patchable_path("sessions/2026-09-21.md", &prefixes));+ assert!(!is_patchable_path("anything.md", &prefixes));+ }++ #[test]+ fn prefixes_match_folders_not_bare_name_prefixes() {+ // `_rules/` carries its separator, so a sibling folder whose name merely+ // starts with the same letters is not swept in.+ let prefixes = vec!["decisions/".to_string()];+ assert!(is_patchable_path("decisions/0001.md", &prefixes));+ assert!(!is_patchable_path("decisions-archive/0001.md", &prefixes));+ }+#[tokio::test]async fn eval_error_timeout_and_invalid_json_fail_closed() {let cases = vec![diff --git a/crates/ai-memory-consolidate/src/lib.rs b/crates/ai-memory-consolidate/src/lib.rsindex 2c6f8689..b31678c9 100644--- a/crates/ai-memory-consolidate/src/lib.rs+++ b/crates/ai-memory-consolidate/src/lib.rs@@ -32,9 +32,9 @@ pub use auto_improve::{DEFAULT_AUTO_IMPROVE_MAX_PROPOSALS, DEFAULT_AUTO_IMPROVE_MAX_REJECTION_CONTEXT,DEFAULT_AUTO_IMPROVE_MAX_RULE_PAGE_TOKENS, DEFAULT_AUTO_IMPROVE_MIN_CONFIDENCE,DEFAULT_AUTO_IMPROVE_MIN_OBSERVATIONS, DEFAULT_AUTO_IMPROVE_MIN_SESSION_DURATION_SECS,- DEFAULT_AUTO_IMPROVE_PENDING_PATH, DEFAULT_AUTO_IMPROVE_PROPOSAL_ACTOR,- DEFAULT_AUTO_IMPROVE_REJECTION_CONTEXT_DAYS, default_auto_improve_eval_targets,- run_auto_improve_review,+ DEFAULT_AUTO_IMPROVE_PATCHABLE_PAGE_PREFIXES, DEFAULT_AUTO_IMPROVE_PENDING_PATH,+ DEFAULT_AUTO_IMPROVE_PROPOSAL_ACTOR, DEFAULT_AUTO_IMPROVE_REJECTION_CONTEXT_DAYS,+ default_auto_improve_eval_targets, run_auto_improve_review,};pub use auto_improve_schedule::{ScheduledAutoImproveSettings, ScheduledAutoImproveTickOutcome,diff --git a/crates/ai-memory-mcp/src/admin.rs b/crates/ai-memory-mcp/src/admin.rsindex 77b513a0..8d303932 100644--- a/crates/ai-memory-mcp/src/admin.rs+++ b/crates/ai-memory-mcp/src/admin.rs@@ -1980,6 +1980,13 @@ async fn handle_auto_improve(proposal_actor: req.proposal_actor.clone(),pending_path: req.pending_path.clone(),max_patchable_pages: req.max_patchable_pages,+ // The admin surface does not expose this yet; the reviewer keeps the+ // configured default rather than silently reading no page bodies (#834).+ patchable_page_prefixes:+ ai_memory_consolidate::DEFAULT_AUTO_IMPROVE_PATCHABLE_PAGE_PREFIXES+ .iter()+ .map(|p| (*p).to_string())+ .collect(),max_patchable_body_chars: req.max_patchable_body_chars,max_edits_per_proposal: req.max_edits_per_proposal,max_edit_content_chars: req.max_edit_content_chars,diff --git a/crates/ai-memory-mcp/src/server.rs b/crates/ai-memory-mcp/src/server.rsindex e2681465..c8cde3a2 100644--- a/crates/ai-memory-mcp/src/server.rs+++ b/crates/ai-memory-mcp/src/server.rs@@ -60,6 +60,11 @@ fn default_auto_improve_review_config() -> AutoImproveReviewConfig {proposal_actor: ai_memory_consolidate::DEFAULT_AUTO_IMPROVE_PROPOSAL_ACTOR.into(),pending_path: ai_memory_consolidate::DEFAULT_AUTO_IMPROVE_PENDING_PATH.into(),max_patchable_pages: ai_memory_consolidate::DEFAULT_AUTO_IMPROVE_MAX_PATCHABLE_PAGES,+ patchable_page_prefixes:+ ai_memory_consolidate::DEFAULT_AUTO_IMPROVE_PATCHABLE_PAGE_PREFIXES+ .iter()+ .map(|p| (*p).to_string())+ .collect(),max_patchable_body_chars:ai_memory_consolidate::DEFAULT_AUTO_IMPROVE_MAX_PATCHABLE_BODY_CHARS,max_edits_per_proposal: ai_memory_consolidate::DEFAULT_AUTO_IMPROVE_MAX_EDITS_PER_PROPOSAL,@@ -2896,6 +2901,7 @@ impl AiMemoryServer {proposal_actor: defaults.proposal_actor.clone(),pending_path: defaults.pending_path.clone(),max_patchable_pages: defaults.max_patchable_pages,+ patchable_page_prefixes: defaults.patchable_page_prefixes.clone(),max_patchable_body_chars: defaults.max_patchable_body_chars,max_edits_per_proposal: defaults.max_edits_per_proposal,max_edit_content_chars: defaults.max_edit_content_chars,diff --git a/docs/ARCHITECTURE.md b/docs/ARCHITECTURE.mdindex 0ebaf65f..2007af03 100644--- a/docs/ARCHITECTURE.md+++ b/docs/ARCHITECTURE.md@@ -593,6 +593,7 @@ min_confidence = 0.75max_input_tokens = 24000max_proposals_per_run = 5max_patchable_pages = 8+patchable_page_prefixes = ["_rules/", "procedures/"]max_patchable_body_chars = 8000max_edits_per_proposal = 5max_edit_content_chars = 4000diff --git a/docs/auto-improvement-loop.md b/docs/auto-improvement-loop.mdindex 5abd1fc6..cf197f5a 100644--- a/docs/auto-improvement-loop.md+++ b/docs/auto-improvement-loop.md@@ -344,6 +344,7 @@ min_confidence = 0.75max_input_tokens = 24000max_proposals_per_run = 5max_patchable_pages = 8+patchable_page_prefixes = ["_rules/", "procedures/"]max_patchable_body_chars = 8000max_edits_per_proposal = 5max_edit_content_chars = 4000@@ -365,6 +366,35 @@ max_sessions_per_tick = 1 # per project; ticks process projects sequentialmin_session_age_secs = 600```+### Which pages the reviewer can actually read++`patchable_page_prefixes` decides which folders' **page bodies** are sent to the+reviewer. Everything else in the project reaches it through the recent-page list+as a single line — path, title, kind, updated_at — with no content.++That matters because the reviewer cannot avoid duplicating what it cannot read.+A project that keeps its invariants in `decisions/` or `gotchas/`, with no+`_rules/` pages at all, sends **no page bodies**, and the model will keep+proposing rules that are already written down — often with high confidence,+because the claim really is well evidenced by the session.++The default is the historical pair, so existing installations are unchanged. Add+the folders where your durable knowledge actually lives:++```toml+patchable_page_prefixes = ["_rules/", "procedures/", "decisions/", "gotchas/"]+```++Prefixes are matched against the start of the page path and should end with `/`,+so `decisions/` does not also match `decisions-archive/`. An empty list disables+page-body context entirely; an empty string in the list is ignored rather than+matching every page.++Note that `max_patchable_pages` still bounds how many of the matching pages are+sent, and the recent-page list they are drawn from is ordered by recency, so a+project with heavy `sessions/` churn may still crowd out durable pages.++`[auto_improve.scheduler]` controls whether and how often the server launchesbackground review. `[auto_improve] require_approval` controls whether validatedproposals are applied automatically or left pending. They intentionally do not