Solution for long term memory for agent coding CLIs and to facilitate handoff between different agent vendors
Rust
fix(capture): treat a glob that could match a saved-output file like the file itself
AkitaOnRailsc058161a07fc
diff --git a/crates/ai-memory-cli/src/commands/render_shared.rs b/crates/ai-memory-cli/src/commands/render_shared.rsindex 125c24e5..f259e32d 100644--- a/crates/ai-memory-cli/src/commands/render_shared.rs+++ b/crates/ai-memory-cli/src/commands/render_shared.rs@@ -394,8 +394,10 @@ function captureMatchCommand(words: [string, boolean][], config: CaptureConfig,function captureBase(config: CaptureConfig, workdir?: string): string { return workdir === undefined ? config.base : /^(?:\/|\\\\|[A-Za-z]:[\\/])/.test(workdir) ? workdir : config.base && captureJoin(config.base, workdir); }// A leading unquoted `~/` (PowerShell `~\`) is home and `~+` the working directory; mirrors `expand_tilde`.function captureExpandTilde(argument: string, tilde: boolean, home: string, base: string): string { return !tilde ? argument : /^~[\/\\]/.test(argument) ? captureJoin(home, argument.slice(2)) : argument === "~+" ? base : argument.startsWith("~+/") && base ? captureJoin(base, argument.slice(3)) : argument; }-// A harness's saved copy of an earlier tool's output, read back like `BashOutput`: Claude Code `~/.claude/projects/<project>/<session>/tool-results/<id>.txt` and `<tmp>/claude-<uid>/<project>/<session>/tasks/<id>.output`, OpenCode `<data>/opencode/tool-output/tool_<id>`, Pi `<tmp>/pi-bash-<id>.log`; mirrors `output_spool`.-function captureOutputSpool(path: string): boolean { const segments = path.split("/").filter(Boolean).map((segment) => segment.replace(/[A-Z]/g, (c) => c.toLowerCase())); const file = segments.pop(); if (file === undefined) return false; const parent = segments[segments.length - 1]; const claudeResults = segments.some((segment, index) => segment === "projects" && index > 0 && segments[index - 1].includes("claude") && segments.slice(index + 1).includes("tool-results")); const claudeTask = parent === "tasks" && file.endsWith(".output") && segments.some((segment) => segment.startsWith("claude")); const opencode = parent === "tool-output" && segments.length >= 2 && segments[segments.length - 2] === "opencode"; const pi = file.startsWith("pi-bash-") && file.endsWith(".log"); return claudeResults || claudeTask || opencode || pi; }+// A harness's saved copy of an earlier tool's output, read back like `BashOutput`: Claude Code `~/.claude/projects/<project>/<session>/tool-results/<id>.txt` and `<tmp>/claude-<uid>/<project>/<session>/tasks/<id>.output`, OpenCode `<data>/opencode/tool-output/tool_<id>`, Pi `<tmp>/pi-bash-<id>.log`. A glob segment fits a named one when the two share a match, and at least one fitting segment must spell literal text; mirrors `output_spool`.+function captureOutputSpool(path: string): boolean { const segments = path.split("/").filter(Boolean).map((segment) => segment.replace(/[A-Z]/g, (c) => c.toLowerCase())); const file = segments.pop(); if (file === undefined) return false; const fits = (segment: string, shape: string) => captureGlobsIntersect([...segment], [...shape]); const named = (...parts: string[]) => parts.some((part) => /[^*?]/.test(part)); const count = segments.length; let claudeResults = false; for (let i = 1; i < count && !claudeResults; i++) { const claude = segments[i - 1]; const projects = segments[i]; if (fits(claude, "*claude*") && fits(projects, "projects")) claudeResults = segments.slice(i + 1).some((results) => fits(results, "tool-results") && named(claude, projects, results)); } const parent = segments[count - 1]; const claudeTask = count > 0 && fits(parent, "tasks") && fits(file, "*.output") && segments.some((claude) => fits(claude, "claude*") && named(parent, file, claude)); const opencode = count >= 2 && fits(segments[count - 2], "opencode") && fits(parent, "tool-output") && named(segments[count - 2], parent); const pi = fits(file, "pi-bash-*.log") && named(file); return claudeResults || claudeTask || opencode || pi; }+// Whether two one-segment globs over `*` and `?` match a common string; mirrors `globs_intersect`.+function captureGlobsIntersect(left: string[], right: string[]): boolean { const common = Array.from({ length: left.length + 1 }, () => new Array<boolean>(right.length + 1).fill(false)); common[left.length][right.length] = true; for (let i = left.length; i >= 0; i--) for (let j = right.length; j >= 0; j--) { if (i === left.length && j === right.length) continue; common[i][j] = left[i] === "*" ? common[i + 1][j] || (j < right.length && common[i][j + 1]) : right[j] === "*" ? common[i][j + 1] || (i < left.length && common[i + 1][j]) : i < left.length && j < right.length ? (left[i] === "?" || right[j] === "?" || left[i] === right[j]) && common[i + 1][j + 1] : false; } return common[0][0]; }// Gemini CLI `read_many_files` globs expand case-insensitively with `**`// recursing to any depth: a literal path matches like a file tool's, a glob// drops when it could expand into an ignored path, and glob syntax the matcher@@ -421,7 +423,7 @@ function captureOwnedExternally(): boolean { const owner = typeof process === "ufunction captureServerRouted(cwd: string | undefined): boolean { let dir = resolve(cwd ?? process.cwd()); const home = homedir(); let boundary: string | undefined; for (let probe = dir; ; probe = dirname(probe)) { if (probe === home) { boundary = home; break; } if (probe === dirname(probe)) break; } for (;;) { try { if (/^\s*server\s*=/m.test(readFileSync(join(dir, ".ai-memory.toml"), "utf8"))) return true; } catch (e) { if (!["ENOENT", "ENOTDIR", "EISDIR"].includes((e as { code?: string })?.code ?? "")) return true; } if (dir === boundary || dir === dirname(dir)) return false; dir = dirname(dir); } }type CaptureTool = ReturnType<typeof captureTool>;// One policy's disposition for one call, shared by the event's own marker and every other marker it reaches.-function captureDecide(tool: CaptureTool, config: CaptureConfig): CaptureDisposition { if (config.state === "invalid" && (tool.family === "file" || tool.shell || tool.reader)) return "metadata-only"; if (config.state !== "active") return "keep"; if (tool.reader) return "metadata-only"; if (tool.family === "search-list") return "drop"; if (tool.family === "file") { if (!tool.paths) return "metadata-only"; const parsed = tool.paths.map((p) => captureNormalize(/^(?:\/|\\\\|[A-Za-z]:[\\/])/.test(p) ? p : captureJoin(config.base, p), config.windowsHost)); if (parsed.some((p) => !p)) return "metadata-only"; const candidates = parsed as { path: string; windows: boolean }[]; if (tool.globs) { const match = captureMatchGlobs(tool.paths, candidates, config); return match === false ? "keep" : match ? "drop" : "metadata-only"; } const budget = { work: 0 }; for (const raw of candidates) { const candidate = { path: captureFold(raw.path), windows: raw.windows }; for (const pattern of config.patterns) { if (candidate.windows !== pattern.windows) continue; if (pattern.directory && captureGlob(pattern.directory, candidate.path, pattern.windows || captureFoldCase, budget)) return "drop"; const match = captureGlob(pattern.path, candidate.path, pattern.windows || captureFoldCase, budget); if (match === undefined) return "metadata-only"; if (match) return "drop"; } } return candidates.some((candidate) => captureOutputSpool(candidate.path)) ? "metadata-only" : "keep"; } if (tool.family === "non-file" && tool.command !== undefined) { const split = captureShellSplit(tool.command, tool.powershell || config.windowsHost); const matched = captureMatchCommand(split.words, config, tool.workdir); if (matched.match !== false) return "drop"; if (split.opaque || matched.spool) return "metadata-only"; } return "keep"; }+function captureDecide(tool: CaptureTool, config: CaptureConfig): CaptureDisposition { if (config.state === "invalid" && (tool.family === "file" || tool.shell || tool.reader)) return "metadata-only"; if (config.state !== "active") return "keep"; if (tool.reader) return "metadata-only"; if (tool.family === "search-list") return "drop"; if (tool.family === "file") { if (!tool.paths) return "metadata-only"; const parsed = tool.paths.map((p) => captureNormalize(/^(?:\/|\\\\|[A-Za-z]:[\\/])/.test(p) ? p : captureJoin(config.base, p), config.windowsHost)); if (parsed.some((p) => !p)) return "metadata-only"; const candidates = parsed as { path: string; windows: boolean }[]; if (tool.globs) { const match = captureMatchGlobs(tool.paths, candidates, config); if (match !== false) return match ? "drop" : "metadata-only"; return candidates.some((candidate) => captureOutputSpool(candidate.path)) ? "metadata-only" : "keep"; } const budget = { work: 0 }; for (const raw of candidates) { const candidate = { path: captureFold(raw.path), windows: raw.windows }; for (const pattern of config.patterns) { if (candidate.windows !== pattern.windows) continue; if (pattern.directory && captureGlob(pattern.directory, candidate.path, pattern.windows || captureFoldCase, budget)) return "drop"; const match = captureGlob(pattern.path, candidate.path, pattern.windows || captureFoldCase, budget); if (match === undefined) return "metadata-only"; if (match) return "drop"; } } return candidates.some((candidate) => captureOutputSpool(candidate.path)) ? "metadata-only" : "keep"; } if (tool.family === "non-file" && tool.command !== undefined) { const split = captureShellSplit(tool.command, tool.powershell || config.windowsHost); const matched = captureMatchCommand(split.words, config, tool.workdir); if (matched.match !== false) return "drop"; if (split.opaque || matched.spool) return "metadata-only"; } return "keep"; }const captureRank: Record<CaptureDisposition, number> = { keep: 0, "metadata-only": 1, drop: 2 };// Every other marker governing a path the call names (a file-tool target, or a shell argument with a separator resolved from its workdir, plus that directory) inspects it too, so a checkout's `ignore_paths` hold for a call made from elsewhere. Lexical; each directory is looked up once, and past the bounds the call is unprovable. Mirrors `capture_lookup_locations` and `foreign_capture_decision`.function captureForeignConfigs(tool: CaptureTool, config: CaptureConfig, cwd: string | undefined, own: string | undefined): CaptureConfig[] { const invalid: CaptureConfig[] = [{ state: "invalid", patterns: [], base: config.base, windowsHost: config.windowsHost }]; const locations = new Set<string>(); const add = (path: string, base: string) => { const absolute = /^(?:\/|\\\\|[A-Za-z]:[\\/])/.test(path); if (!absolute && !base) return; const candidate = captureNormalize(absolute ? path : captureJoin(base, path), config.windowsHost); if (candidate) locations.add(candidate.windows ? candidate.path.replace(/\//g, "\\") : candidate.path); }; if (tool.family === "file") for (const path of tool.paths ?? []) add(path, config.base); else if (tool.family === "non-file" && tool.command !== undefined) { const base = captureBase(config, tool.workdir); if (base) add(base, base); const home = homedir(); for (const [word, tilde] of captureShellSplit(tool.command, tool.powershell || config.windowsHost).words) for (const [argument] of captureShellArguments(word)) { const expanded = captureExpandTilde(argument, tilde, home, base); if (/[\/\\]/.test(expanded)) add(expanded, base); } } if (locations.size > CAPTURE_MAX_LOOKUP_LOCATIONS) return invalid; const directories = new Map<string, string | undefined>(); const markers: string[] = []; for (const location of locations) { const dir = captureExistingDir(location); if (dir === undefined) continue; let marker: string | undefined; if (directories.has(dir)) marker = directories.get(dir); else { if (directories.size === CAPTURE_MAX_FOREIGN_DIRECTORIES) return invalid; marker = findMarker(dir); directories.set(dir, marker); } if (!marker || marker === own || markers.includes(marker)) continue; if (markers.length === CAPTURE_MAX_FOREIGN_MARKERS) return invalid; markers.push(marker); } return markers.map((marker) => captureConfigAt(marker, cwd)); }diff --git a/crates/ai-memory-hooks/src/capture_policy.rs b/crates/ai-memory-hooks/src/capture_policy.rsindex 1abf56e8..95f03353 100644--- a/crates/ai-memory-hooks/src/capture_policy.rs+++ b/crates/ai-memory-hooks/src/capture_policy.rs@@ -1126,36 +1126,81 @@ fn reads_earlier_output(name: &str) -> bool {/// Pi's (`<tmp>/pi-bash-<id>.log`). The command that produced it may have been/// dropped, so, like [`reads_earlier_output`], nothing proves it missed every/// ignored path. Segment names compare without regard to ASCII case.+///+/// A path holding `*` or `?` is a glob that could expand to such a file+/// (`~/.claude/projects/*/*/tool-results/*`): each of its segments is read as+/// a one-segment glob (`**` included) that fits a named directory or file+/// when the two globs share a match. At least one segment that fits must+/// spell some literal text, so a bare `*` or `*/*` is never taken for a saved+/// output file on its own.fn output_spool(path: &str) -> bool {- let segments: Vec<String> = path+ let segments: Vec<Vec<char>> = path.split('/').filter(|segment| !segment.is_empty())- .map(str::to_ascii_lowercase)+ .map(|segment| segment.to_ascii_lowercase().chars().collect()).collect();let Some((file, directories)) = segments.split_last() else {return false;};- let parent = directories.last().map(String::as_str);- let claude_results = directories.iter().enumerate().any(|(index, segment)| {- segment == "projects"- && index > 0- && directories[index - 1].contains("claude")+ let fits = |segment: &[char], shape: &str| {+ globs_intersect(segment, &shape.chars().collect::<Vec<_>>())+ };+ // A segment that is not only wildcards names something.+ let named = |segments: &[&Vec<char>]| {+ segments+ .iter()+ .any(|segment| segment.iter().any(|c| !matches!(c, '*' | '?')))+ };+ let count = directories.len();+ let claude_results = (1..count).any(|index| {+ let (claude, projects) = (&directories[index - 1], &directories[index]);+ fits(claude, "*claude*")+ && fits(projects, "projects")&& directories[index + 1..].iter()- .any(|segment| segment == "tool-results")+ .any(|results| fits(results, "tool-results") && named(&[claude, projects, results]))});- let claude_task = parent == Some("tasks")- && file.ends_with(".output")- && directories- .iter()- .any(|segment| segment.starts_with("claude"));- let opencode = parent == Some("tool-output")- && directories.len() >= 2- && directories[directories.len() - 2] == "opencode";- let pi = file.starts_with("pi-bash-") && file.ends_with(".log");+ let claude_task = count > 0 && {+ let parent = &directories[count - 1];+ fits(parent, "tasks")+ && fits(file, "*.output")+ && directories+ .iter()+ .any(|claude| fits(claude, "claude*") && named(&[parent, file, claude]))+ };+ let opencode = count >= 2 && {+ let (data, output) = (&directories[count - 2], &directories[count - 1]);+ fits(data, "opencode") && fits(output, "tool-output") && named(&[data, output])+ };+ let pi = fits(file, "pi-bash-*.log") && named(&[file]);claude_results || claude_task || opencode || pi}+/// Whether two one-segment globs over `*` and `?` match a common string.+/// A literal is a glob without wildcards, so for one this is `glob_match`.+fn globs_intersect(left: &[char], right: &[char]) -> bool {+ // `common[i][j]`: some string matches both `left[i..]` and `right[j..]`.+ let mut common = vec![vec![false; right.len() + 1]; left.len() + 1];+ common[left.len()][right.len()] = true;+ for i in (0..=left.len()).rev() {+ for j in (0..=right.len()).rev() {+ if i == left.len() && j == right.len() {+ continue;+ }+ common[i][j] = if left.get(i) == Some(&'*') {+ common[i + 1][j] || (j < right.len() && common[i][j + 1])+ } else if right.get(j) == Some(&'*') {+ common[i][j + 1] || (i < left.len() && common[i + 1][j])+ } else if let (Some(l), Some(r)) = (left.get(i), right.get(j)) {+ (*l == '?' || *r == '?' || l == r) && common[i + 1][j + 1]+ } else {+ false+ };+ }+ }+ common[0][0]+}+fn family(name: &str) -> ToolFamily {match name.to_ascii_lowercase().as_str() {"read"diff --git a/crates/ai-memory-hooks/tests/fixtures/capture-policy.json b/crates/ai-memory-hooks/tests/fixtures/capture-policy.jsonindex 61591572..2666e673 100644--- a/crates/ai-memory-hooks/tests/fixtures/capture-policy.json+++ b/crates/ai-memory-hooks/tests/fixtures/capture-policy.json@@ -45,6 +45,10 @@{"agent":"open-code","payload":{"tool":"read","args":{"filePath":"tasks/b1.output"}},"disposition":"keep","tool_family":"file","extraction_state":"extracted","path_count":1},{"agent":"pi","payload":{"tool":"read","args":{"path":"projects/x/s1/tool-results/a.txt"}},"disposition":"keep","tool_family":"file","extraction_state":"extracted","path_count":1},{"agent":"pi","payload":{"tool":"read","args":{"path":"src/pi-bash.rs"}},"disposition":"keep","tool_family":"file","extraction_state":"extracted","path_count":1},+ {"agent":"gemini-cli","payload":{"tool_name":"read_many_files","tool_input":{"include":["/home/me/.claude/*/-repo/s1/tool-results/*"]}},"disposition":"metadata-only","tool_family":"file","extraction_state":"extracted","path_count":1},+ {"agent":"open-code","payload":{"tool":"read_many_files","args":{"include":["/home/me/.claude/*/-repo/s1/tool-results/*"]}},"disposition":"metadata-only","tool_family":"file","extraction_state":"extracted","path_count":1},+ {"agent":"open-code","payload":{"tool":"read_many_files","args":{"include":["/tmp/pi-*"]}},"disposition":"metadata-only","tool_family":"file","extraction_state":"extracted","path_count":1},+ {"agent":"open-code","payload":{"tool":"read_many_files","args":{"include":["src/*/*.rs","/tmp/*.txt"]}},"disposition":"keep","tool_family":"file","extraction_state":"extracted","path_count":2},{"agent":"openclaw","payload":{"tool":"exec","args":{"command":"wc -l <secret/a"}},"disposition":"drop","tool_family":"non-file","extraction_state":"extracted","path_count":0},{"agent":"open-code","payload":{"tool":"bash","args":{"command":"cat public/a *.md"}},"disposition":"keep","tool_family":"non-file","extraction_state":"extracted","path_count":0},{"agent":"openclaw","payload":{"tool":"exec","args":{"command":"git diff"}},"disposition":"keep","tool_family":"non-file","extraction_state":"extracted","path_count":0},@@ -329,6 +333,22 @@{"command":"cat /tmp/claude-1000/-repo/s1/tasks/b1.output","disposition":"metadata-only"},{"command":"tail -n 50 /tmp/pi-bash-0a1b.log","disposition":"metadata-only"},{"command":"cat /tmp/claude-1000/-repo/s1/scratchpad/notes.txt","disposition":"keep"},+ {"command":"cat /home/me/.claude/projects/*/tool-results/*","disposition":"metadata-only"},+ {"command":"cat /home/me/.claude/*/-repo/s1/tool-results/t1.txt","disposition":"metadata-only"},+ {"command":"cat /home/me/.claude/projects/-repo/s1/tool-res*/t1.txt","disposition":"metadata-only"},+ {"command":"cat /home/me/.claude/projects/*/*/*/*","disposition":"metadata-only"},+ {"command":"cat /home/me/.cl*/projects/-repo/s1/tool-results/t1.txt","disposition":"metadata-only"},+ {"command":"cat /tmp/claude-1000/-repo/s1/*/b1.output","disposition":"metadata-only"},+ {"command":"cat /tmp/claude-1000/*/*/*/*.output","disposition":"metadata-only"},+ {"command":"tail -n 50 /tmp/pi-*","disposition":"metadata-only"},+ {"command":"cat /home/me/.local/share/opencode/tool-*/tool_01","disposition":"metadata-only"},+ {"command":"cat ~/.claude/projects/*/*/tool-results/*","disposition":"metadata-only"},+ {"command":"ls src/*","disposition":"keep"},+ {"command":"cat src/*/*","disposition":"keep"},+ {"command":"grep -n main src/*","disposition":"keep"},+ {"command":"cat /tmp/*/notes.txt","disposition":"keep"},+ {"command":"cat /tmp/claude-1000/-repo/s1/scratchpad/*.txt","disposition":"keep"},+ {"command":"cat /home/me/.claude/projects/-repo/*.jsonl","disposition":"keep"},{"command":"cat DOCS/ADR/1.md","fold_case":true,"disposition":"drop"},{"command":"cat Docs/Adr/*.md","fold_case":true,"disposition":"drop"},{"command":"cat DOCS/ADR/1.md","disposition":"keep"},