Solution for long term memory for agent coding CLIs and to facilitate handoff between different agent vendors
Rust
fix(api): stop caching an actor-scoped search response
Rudy Mizrahi Celeklid46c3ecefcea
diff --git a/crates/ai-memory-web/src/routes/api.rs b/crates/ai-memory-web/src/routes/api.rsindex a343d886..ea7c510e 100644--- a/crates/ai-memory-web/src/routes/api.rs+++ b/crates/ai-memory-web/src/routes/api.rs@@ -465,9 +465,13 @@ async fn search_with_request(}.map_err(internal_error)?;- Ok(with_cache(+ // `owner` reaches the hybrid ranker, which attaches an observation excerpt+ // only from a session that filter admits, so both the order and each hit's+ // snippet depend on the caller's identity. `private` alone would let a+ // browser cache replay one actor's hits at the same URL after the+ // credentials switch, so the filtering path must run on every request.+ Ok(with_no_store(Json(enrich_hits(state, hits).await?).into_response(),- LIST_CACHE_MAX_AGE,))}diff --git a/crates/ai-memory-web/tests/suite/routes.rs b/crates/ai-memory-web/tests/suite/routes.rsindex a746fa97..c5fbe9ee 100644--- a/crates/ai-memory-web/tests/suite/routes.rs+++ b/crates/ai-memory-web/tests/suite/routes.rs@@ -3048,32 +3048,61 @@ async fn actor_scoped_api_responses_are_never_reused_across_credentials() {.unwrap();let app = api_router(store.reader.clone(), wiki.clone());- for uri in [- "/workspaces/default/projects/scratch/briefing",- "/workspaces/default/overview",- "/workspaces/default/projects/scratch/overview",- "/workspaces/default/projects/scratch/handoffs",+ // `/search` is listed for both of its registrations: the owner filter+ // reaches the hybrid ranker from either verb, so both bodies are+ // actor-scoped.+ for (method, uri, body) in [+ (+ Method::GET,+ "/workspaces/default/projects/scratch/briefing",+ None,+ ),+ (Method::GET, "/workspaces/default/overview", None),+ (+ Method::GET,+ "/workspaces/default/projects/scratch/overview",+ None,+ ),+ (+ Method::GET,+ "/workspaces/default/projects/scratch/handoffs",+ None,+ ),+ (+ Method::GET,+ "/search?q=anything&workspace=default&project=scratch",+ None,+ ),+ (+ Method::POST,+ "/search",+ Some(r#"{"q":"anything","workspace":"default","project":"scratch"}"#),+ ),] {- let resp = app- .clone()- .oneshot(api_req_actor(- uri,- Some(ai_memory_core::ActorContext {- user: Some("alice".into()),- ..ai_memory_core::ActorContext::default()- }),- Some(ai_memory_core::AuthLevel::User),- ))- .await- .unwrap();- assert_eq!(resp.status(), StatusCode::OK, "{uri}");+ let mut builder = Request::builder()+ .method(method.clone())+ .uri(uri)+ .extension(ai_memory_core::ActorContext {+ user: Some("alice".into()),+ ..ai_memory_core::ActorContext::default()+ })+ .extension(ai_memory_core::AuthLevel::User);+ let req = match body {+ Some(json) => {+ builder = builder.header(header::CONTENT_TYPE, "application/json");+ builder.body(Body::from(json)).unwrap()+ }+ None => builder.body(Body::empty()).unwrap(),+ };+ let resp = app.clone().oneshot(req).await.unwrap();+ assert_eq!(resp.status(), StatusCode::OK, "{method} {uri}");let cache = resp.headers().get(header::CACHE_CONTROL).expect("actor-scoped responses need Cache-Control").to_str().unwrap();- assert_eq!(cache, "private, no-store", "{uri}");+ assert_eq!(cache, "private, no-store", "{method} {uri}");}}