Open-source Grok Bot alternative for named AI teammates. Local-first desktop, web, and mobile clients with per-bot tools, instructions, and memory. Independent fork of T3 Code.
fix(web): reject unsupported composer image types at attach time (#6574)
mohammed shazeb34a12bc33f5f
diff --git a/apps/mobile/src/features/sharing/incoming-share-model.ts b/apps/mobile/src/features/sharing/incoming-share-model.tsindex 873574209..d9985a700 100644--- a/apps/mobile/src/features/sharing/incoming-share-model.ts+++ b/apps/mobile/src/features/sharing/incoming-share-model.ts@@ -1,4 +1,5 @@import {+ isProviderSendTurnSupportedImageMimeType,PROVIDER_SEND_TURN_MAX_ATTACHMENTS,PROVIDER_SEND_TURN_MAX_IMAGE_BYTES,} from "@t3tools/contracts";@@ -162,6 +163,13 @@ export async function buildIncomingShareDraft(input: {await releaseOwnedFiles(input.fileReader, [uri, payload.value]);continue;}+ if (!isProviderSendTurnSupportedImageMimeType(mimeType)) {+ warnings.push(+ `'${resolved?.originalName ?? fallbackName(uri, index, mimeType)}' is not a supported image type.`,+ );+ await releaseOwnedFiles(input.fileReader, [uri, payload.value]);+ continue;+ }if (resolved?.contentSize !== null &&resolved?.contentSize !== undefined &&diff --git a/apps/mobile/src/lib/composerImages.ts b/apps/mobile/src/lib/composerImages.tsindex e92bb0c6e..747b7afd3 100644--- a/apps/mobile/src/lib/composerImages.ts+++ b/apps/mobile/src/lib/composerImages.ts@@ -1,4 +1,5 @@import {+ isProviderSendTurnSupportedImageMimeType,PROVIDER_SEND_TURN_MAX_ATTACHMENTS,PROVIDER_SEND_TURN_MAX_IMAGE_BYTES,type UploadChatImageAttachment,@@ -98,6 +99,10 @@ export async function pickComposerImages(input: { readonly existingCount: numbererror = `Unsupported file type for '${asset.fileName ?? "image"}'.`;continue;}+ if (!isProviderSendTurnSupportedImageMimeType(mimeType)) {+ error = `'${asset.fileName ?? "image"}' is not a supported image type. Attach GIF, JPEG, PNG, or WebP images.`;+ continue;+ }const base64 = asset.base64;if (!base64) {diff --git a/apps/web/src/components/chat/ChatComposer.tsx b/apps/web/src/components/chat/ChatComposer.tsxindex afba1e086..5a01c5c76 100644--- a/apps/web/src/components/chat/ChatComposer.tsx+++ b/apps/web/src/components/chat/ChatComposer.tsx@@ -12,6 +12,7 @@ import type {ThreadId,} from "@t3tools/contracts";import {+ isProviderSendTurnSupportedImageMimeType,ProviderDriverKind,ProviderInstanceId,PROVIDER_SEND_TURN_MAX_ATTACHMENTS,@@ -2305,6 +2306,10 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)error = `Unsupported file type for '${file.name}'. Please attach image files only.`;continue;}+ if (!isProviderSendTurnSupportedImageMimeType(file.type)) {+ error = `'${file.name}' is not a supported image type. Attach GIF, JPEG, PNG, or WebP images.`;+ continue;+ }if (reservedCount >= PROVIDER_SEND_TURN_MAX_ATTACHMENTS) {error = `You can attach up to ${PROVIDER_SEND_TURN_MAX_ATTACHMENTS} images per message.`;break;diff --git a/packages/contracts/src/orchestration.test.ts b/packages/contracts/src/orchestration.test.tsindex eba1b4648..f403e6de2 100644--- a/packages/contracts/src/orchestration.test.ts+++ b/packages/contracts/src/orchestration.test.ts@@ -23,6 +23,7 @@ import {ThreadCreatedPayload,ThreadTurnDiff,ThreadTurnStartRequestedPayload,+ isProviderSendTurnSupportedImageMimeType,} from "./orchestration.ts";import { ProviderInstanceId } from "./providerInstance.ts";@@ -935,3 +936,9 @@ it.effect("project favicon overrides accept only supported image files", () =>assert.strictEqual(invalid._tag, "Failure");}),);++it("isProviderSendTurnSupportedImageMimeType accepts raster formats and rejects svg", () => {+ assert.strictEqual(isProviderSendTurnSupportedImageMimeType("image/png"), true);+ assert.strictEqual(isProviderSendTurnSupportedImageMimeType("IMAGE/JPEG"), true);+ assert.strictEqual(isProviderSendTurnSupportedImageMimeType("image/svg+xml"), false);+});diff --git a/packages/contracts/src/orchestration.ts b/packages/contracts/src/orchestration.tsindex 35fef721e..cd9f3a747 100644--- a/packages/contracts/src/orchestration.ts+++ b/packages/contracts/src/orchestration.ts@@ -144,6 +144,20 @@ export type ProviderUserInputAnswers = typeof ProviderUserInputAnswers.Type;export const PROVIDER_SEND_TURN_MAX_INPUT_CHARS = 120_000;export const PROVIDER_SEND_TURN_MAX_ATTACHMENTS = 8;export const PROVIDER_SEND_TURN_MAX_IMAGE_BYTES = 10 * 1024 * 1024;+export const PROVIDER_SEND_TURN_SUPPORTED_IMAGE_MIME_TYPES = [+ "image/gif",+ "image/jpeg",+ "image/png",+ "image/webp",+] as const;+const PROVIDER_SEND_TURN_SUPPORTED_IMAGE_MIME_TYPE_SET = new Set<string>(+ PROVIDER_SEND_TURN_SUPPORTED_IMAGE_MIME_TYPES,+);++/** Whether a pasted or picked image mime type can be sent on a provider turn. */+export function isProviderSendTurnSupportedImageMimeType(mimeType: string): boolean {+ return PROVIDER_SEND_TURN_SUPPORTED_IMAGE_MIME_TYPE_SET.has(mimeType.toLowerCase());+}const PROVIDER_SEND_TURN_MAX_IMAGE_DATA_URL_CHARS = 14_000_000;const CHAT_ATTACHMENT_ID_MAX_CHARS = 128;// Correlation id is command id by design in this model.