Skip to content

Open-source Grok Bot alternative for named AI teammates. Local-first desktop, web, and mobile clients with per-bot tools, instructions, and memory. Independent fork of T3 Code.

[codex] Migrate desktop app errors to Schema (#3449)

Julius Marminge4cd958445f60
diff --git a/apps/desktop/src/app/DesktopApp.ts b/apps/desktop/src/app/DesktopApp.ts
index f498c3340..214fd383e 100644
--- a/apps/desktop/src/app/DesktopApp.ts
+++ b/apps/desktop/src/app/DesktopApp.ts
@@ -1,8 +1,8 @@
import * as Cause from "effect/Cause";
-import * as Data from "effect/Data";
import * as Effect from "effect/Effect";
import * as Option from "effect/Option";
import * as Ref from "effect/Ref";
+import * as Schema from "effect/Schema";
import * as NetService from "@t3tools/shared/Net";
import * as Crypto from "effect/Crypto";
@@ -33,22 +33,24 @@ const makeDesktopRunId = Crypto.Crypto.pipe(
Effect.map((value) => value.replaceAll("-", "").slice(0, 12)),
);
-class DesktopBackendPortUnavailableError extends Data.TaggedError(
+export class DesktopBackendPortUnavailableError extends Schema.TaggedErrorClass<DesktopBackendPortUnavailableError>()(
"DesktopBackendPortUnavailableError",
-)<{
- readonly startPort: number;
- readonly maxPort: number;
- readonly hosts: readonly string[];
-}> {
- override get message() {
+ {
+ startPort: Schema.Int,
+ maxPort: Schema.Int,
+ hosts: Schema.Array(Schema.String),
+ },
+) {
+ override get message(): string {
return `No desktop backend port is available on hosts ${this.hosts.join(", ")} between ${this.startPort} and ${this.maxPort}.`;
}
}
-class DesktopDevelopmentBackendPortRequiredError extends Data.TaggedError(
+export class DesktopDevelopmentBackendPortRequiredError extends Schema.TaggedErrorClass<DesktopDevelopmentBackendPortRequiredError>()(
"DesktopDevelopmentBackendPortRequiredError",
-)<{}> {
- override get message() {
+ {},
+) {
+ override get message(): string {
return "T3CODE_PORT is required in desktop development.";
}
}
diff --git a/apps/desktop/src/app/DesktopAppErrors.test.ts b/apps/desktop/src/app/DesktopAppErrors.test.ts
new file mode 100644
index 000000000..666c36d39
--- /dev/null
+++ b/apps/desktop/src/app/DesktopAppErrors.test.ts
@@ -0,0 +1,30 @@
+import { assert, describe, it } from "@effect/vitest";
+
+import {
+ DesktopBackendPortUnavailableError,
+ DesktopDevelopmentBackendPortRequiredError,
+} from "./DesktopApp.ts";
+
+describe("DesktopApp errors", () => {
+ it("preserves unavailable backend port context", () => {
+ const error = new DesktopBackendPortUnavailableError({
+ startPort: 3_773,
+ maxPort: 65_535,
+ hosts: ["127.0.0.1", "0.0.0.0", "::"],
+ });
+
+ assert.equal(error.startPort, 3_773);
+ assert.equal(error.maxPort, 65_535);
+ assert.deepEqual(error.hosts, ["127.0.0.1", "0.0.0.0", "::"]);
+ assert.equal(
+ error.message,
+ "No desktop backend port is available on hosts 127.0.0.1, 0.0.0.0, :: between 3773 and 65535.",
+ );
+ });
+
+ it("reports the required development port", () => {
+ const error = new DesktopDevelopmentBackendPortRequiredError();
+
+ assert.equal(error.message, "T3CODE_PORT is required in desktop development.");
+ });
+});