Skip to content

Open-source Grok Bot alternative for named AI teammates. Local-first desktop, web, and mobile clients with per-bot tools, instructions, and memory. Independent fork of T3 Code.

Extend Done display to 15 minutes and show up to 5 Live Activity banner rows (#3761)

Julius Marminge6e42231cb1da
diff --git a/infra/relay/src/agentActivity/AgentActivityPublisher.test.ts b/infra/relay/src/agentActivity/AgentActivityPublisher.test.ts
index d46db9858..1fcc9d0cb 100644
--- a/infra/relay/src/agentActivity/AgentActivityPublisher.test.ts
+++ b/infra/relay/src/agentActivity/AgentActivityPublisher.test.ts
@@ -736,7 +736,7 @@ describe("makeAggregateState", () => {
...state,
threadId: "thread-done" as RelayAgentActivityState["threadId"],
phase: "completed",
- updatedAt: "1970-01-01T00:50:00.000Z",
+ updatedAt: "1970-01-01T00:44:00.000Z",
};
const aggregate = AgentActivityPublisher.makeAggregateState({
activeStates: [active, staleCompleted],
@@ -769,7 +769,7 @@ describe("makeAggregateState", () => {
});
expect(
AgentActivityPublisher.makeAggregateState({
- activeStates: [{ ...lingeringCompleted, updatedAt: "1970-01-01T00:50:00.000Z" }],
+ activeStates: [{ ...lingeringCompleted, updatedAt: "1970-01-01T00:44:00.000Z" }],
terminalState: null,
nowMs: hourMs,
}),
@@ -789,16 +789,25 @@ describe("makeAggregateState", () => {
updatedAt: "1970-01-01T00:59:00.000Z",
};
const aggregate = AgentActivityPublisher.makeAggregateState({
- activeStates: [mkActive("a-1"), mkActive("a-2"), mkActive("a-3"), justCompleted],
+ activeStates: [
+ mkActive("a-1"),
+ mkActive("a-2"),
+ mkActive("a-3"),
+ mkActive("a-4"),
+ mkActive("a-5"),
+ justCompleted,
+ ],
terminalState: null,
nowMs: hourMs,
});
- expect(aggregate?.activeCount).toBe(3);
+ expect(aggregate?.activeCount).toBe(5);
expect(aggregate?.activities).toMatchObject([
{ threadId: "a-1" },
{ threadId: "a-2" },
{ threadId: "a-3" },
+ { threadId: "a-4" },
+ { threadId: "a-5" },
]);
});
});
diff --git a/infra/relay/src/agentActivity/AgentActivityPublisher.ts b/infra/relay/src/agentActivity/AgentActivityPublisher.ts
index 5b739018f..9b3bcf229 100644
--- a/infra/relay/src/agentActivity/AgentActivityPublisher.ts
+++ b/infra/relay/src/agentActivity/AgentActivityPublisher.ts
@@ -13,6 +13,7 @@ import * as Option from "effect/Option";
import {
isExpiredAgentActivityState,
isTerminalPhase,
+ MAX_ACTIVITY_ROWS,
sanitizeAgentActivityAggregateState,
} from "./agentActivityPayloads.ts";
@@ -228,7 +229,7 @@ function terminalAggregateState(state: RelayAgentActivityState): RelayAgentActiv
// How long a finished thread keeps its Done/Failed row in the aggregate while
// other agents are still active. Long enough to be seen on the lock screen,
// short enough that the activity list stays about live work.
-export const TERMINAL_AGENT_ACTIVITY_DISPLAY_TTL_MS = 5 * 60 * 1_000;
+export const TERMINAL_AGENT_ACTIVITY_DISPLAY_TTL_MS = 15 * 60 * 1_000;
function isRecentTerminalState(state: RelayAgentActivityState, nowMs: number): boolean {
if (!isTerminalPhase(state)) {
@@ -273,7 +274,7 @@ export function makeAggregateState(input: {
subtitle: newest.phase === "failed" ? "Agent work failed" : "Agent work completed",
activeCount: 0,
updatedAt: newest.updatedAt,
- activities: recentTerminal.slice(0, 3).map(aggregateRowForState),
+ activities: recentTerminal.slice(0, MAX_ACTIVITY_ROWS).map(aggregateRowForState),
});
}
// Recently finished threads ride along after the active ones (display slots
@@ -282,7 +283,10 @@ export function makeAggregateState(input: {
const recentTerminalStates = input.activeStates
.filter((state) => isRecentTerminalState(state, input.nowMs))
.sort((a, b) => b.updatedAt.localeCompare(a.updatedAt));
- const displayedStates = [...activeStates.slice(0, 3), ...recentTerminalStates].slice(0, 3);
+ const displayedStates = [
+ ...activeStates.slice(0, MAX_ACTIVITY_ROWS),
+ ...recentTerminalStates,
+ ].slice(0, MAX_ACTIVITY_ROWS);
const updatedAt = [...activeStates, ...recentTerminalStates].reduce((latest, state) =>
state.updatedAt.localeCompare(latest.updatedAt) > 0 ? state : latest,
).updatedAt;
diff --git a/infra/relay/src/agentActivity/ApnsDeliveries.test.ts b/infra/relay/src/agentActivity/ApnsDeliveries.test.ts
index 5a35b54fb..cdafc6682 100644
--- a/infra/relay/src/agentActivity/ApnsDeliveries.test.ts
+++ b/infra/relay/src/agentActivity/ApnsDeliveries.test.ts
@@ -373,7 +373,7 @@ describe("ApnsDeliveries", () => {
...aggregate,
title: longTitle,
subtitle: longTitle,
- activities: [0, 1, 2, 3].map((index) =>
+ activities: [0, 1, 2, 3, 4, 5].map((index) =>
Object.assign({}, aggregate.activities[0]!, {
projectTitle: longTitle,
threadTitle: longTitle,
@@ -396,7 +396,7 @@ describe("ApnsDeliveries", () => {
const payloadAggregate = queuedJobs[0]?.payload.aggregate;
expect(payloadAggregate?.title.length).toBeLessThanOrEqual(120);
expect(payloadAggregate?.subtitle.length).toBeLessThanOrEqual(120);
- expect(payloadAggregate?.activities).toHaveLength(3);
+ expect(payloadAggregate?.activities).toHaveLength(5);
expect(payloadAggregate?.activities[0]?.projectTitle.length).toBeLessThanOrEqual(120);
expect(payloadAggregate?.activities[0]?.status.length).toBeLessThanOrEqual(40);
expect(payloadAggregate?.activities[0]?.deepLink).toBe("/");
diff --git a/infra/relay/src/agentActivity/agentActivityPayloads.ts b/infra/relay/src/agentActivity/agentActivityPayloads.ts
index 33f305fb7..a5e12a4be 100644
--- a/infra/relay/src/agentActivity/agentActivityPayloads.ts
+++ b/infra/relay/src/agentActivity/agentActivityPayloads.ts
@@ -43,7 +43,9 @@ export function isExpiredAgentActivityState(
const MAX_SUMMARY_TEXT_LENGTH = 120;
const MAX_STATUS_TEXT_LENGTH = 40;
const MAX_DEEP_LINK_LENGTH = 512;
-const MAX_ACTIVITY_ROWS = 3;
+// The Live Activity banner (lock screen / Notification Center) renders up to
+// five rows; the expanded Dynamic Island shows the top three of these.
+export const MAX_ACTIVITY_ROWS = 5;
function truncateText(value: string, maxLength: number): string {
const trimmed = value.trim();