Skip to content

Open-source Grok Bot alternative for named AI teammates. Local-first desktop, web, and mobile clients with per-bot tools, instructions, and memory. Independent fork of T3 Code.

[codex] fix mobile native static analysis source discovery (#2942)

Julius Marminge80b40ce96a50
diff --git a/scripts/mobile-native-static-check.ts b/scripts/mobile-native-static-check.ts
index 4d1ef9415..ca871fd8a 100644
--- a/scripts/mobile-native-static-check.ts
+++ b/scripts/mobile-native-static-check.ts
@@ -40,14 +40,13 @@ const sourceExtensions = new Set([".swift", ".kt", ".kts"]);
const excludedDirectories = new Set([
".expo",
".git",
- "android",
"build",
"DerivedData",
- "ios",
"node_modules",
"Pods",
"Vendor",
]);
+const generatedNativeProjectDirectories = new Set(["android", "ios"]);
const appRoot = Effect.service(Path.Path).pipe(
Effect.flatMap((path) => path.fromFileUrl(new URL("../apps/mobile", import.meta.url))),
@@ -108,6 +107,7 @@ const runCommand = Effect.fn("runCommand")(function* (
function collectSources(
directory: string,
+ root: string,
): Effect.Effect<
ReadonlyArray<string>,
PlatformError.PlatformError,
@@ -120,15 +120,18 @@ function collectSources(
const sources: Array<string> = [];
for (const entry of entries) {
- if (excludedDirectories.has(entry)) {
- continue;
- }
-
const entryPath = path.join(directory, entry);
const stat = yield* fs.stat(entryPath);
if (stat.type === "Directory") {
- sources.push(...(yield* collectSources(entryPath)));
+ const isGeneratedNativeProjectDirectory =
+ directory === root && generatedNativeProjectDirectories.has(entry);
+
+ if (excludedDirectories.has(entry) || isGeneratedNativeProjectDirectory) {
+ continue;
+ }
+
+ sources.push(...(yield* collectSources(entryPath, root)));
continue;
}
@@ -144,7 +147,7 @@ function collectSources(
const runNativeStaticChecks = Effect.fn("runNativeStaticChecks")(function* () {
const path = yield* Path.Path;
const root = yield* appRoot;
- const sources = yield* collectSources(root);
+ const sources = yield* collectSources(root, root);
const swiftSources = sources.filter((source) => path.extname(source) === ".swift");
const kotlinSources = sources.filter((source) => {
const extension = path.extname(source);
@@ -156,6 +159,10 @@ const runNativeStaticChecks = Effect.fn("runNativeStaticChecks")(function* () {
availableTools.set(tool.command, yield* commandExists(tool.command));
}
+ yield* Console.log(
+ `Found ${swiftSources.length} Swift and ${kotlinSources.length} Kotlin native source files.`,
+ );
+
if (swiftSources.length > 0) {
if (availableTools.get("swiftlint")) {
yield* runCommand("swiftlint", ["lint", "--config", ".swiftlint.yml", "--strict"], root);