Skip to content

Open-source Grok Bot alternative for named AI teammates. Local-first desktop, web, and mobile clients with per-bot tools, instructions, and memory. Independent fork of T3 Code.

fix(ci): fail stable macOS releases without signing credentials (#281)

Leo9418599a2be2
diff --git a/.changeset/require-signed-mac-release.md b/.changeset/require-signed-mac-release.md
new file mode 100644
index 000000000..5724bdbb9
--- /dev/null
+++ b/.changeset/require-signed-mac-release.md
@@ -0,0 +1,4 @@
+---
+---
+
+Empty changeset: CI release-policy change only.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index fb511d975..5f34fa315 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -183,6 +183,10 @@ jobs:
fi
signed=false
if (( present > 0 )); then signed=true; fi
+ if test "$signed" != true && test "$RELEASE_CHANNEL" = stable; then
+ printf 'Stable macOS releases require the complete Developer ID signing credential set.\n' >&2
+ exit 1
+ fi
printf 'MACOS_SIGNED=%s\n' "$signed" >> "$GITHUB_ENV"
- name: Validate Windows signing credentials
diff --git a/docs/internals/ci.md b/docs/internals/ci.md
index 5503dd27f..ad9b8e973 100644
--- a/docs/internals/ci.md
+++ b/docs/internals/ci.md
@@ -50,7 +50,9 @@ Apple Silicon macOS and Windows runners build the advertised desktop targets bef
creates the `vX.Y.Z` tag and GitHub Release. The final job verifies the exact asset names and
`SHA256SUMS`, then starts the next Version Packages update. Version automation waits for the current
stable tag before it prepares another version.
-Missing signing credentials produce unsigned macOS and Windows artifacts.
+A stable release fails before building when the macOS signing credentials are absent, so an
+unsigned DMG can never publish as the latest stable release. Scheduled nightlies and Windows
+builds without credentials still produce unsigned artifacts.
Unsigned macOS builds still replace Electron's linker-signed stub with a sealed ad-hoc signature
and fail the release if `codesign --verify` fails or the identifier is not `dev.leodoes.akeru`.
Complete credentials use the existing Developer ID, notarization, and Azure Trusted Signing paths.
diff --git a/docs/operations/release.md b/docs/operations/release.md
index f77934136..7a7724046 100644
--- a/docs/operations/release.md
+++ b/docs/operations/release.md
@@ -69,9 +69,9 @@ the Apple Silicon macOS and Windows runners. The Tenki Runner GitHub App must ha
## macOS secrets
-The stable release builds a sealed, ad-hoc-signed DMG when all macOS secrets are absent. Users
-must approve that build through the macOS Gatekeeper installation flow. If any macOS secret is
-present, the workflow requires the complete set and stops on a partial configuration.
+The stable release fails before building when the macOS secrets are absent, so an unsigned DMG
+can never publish as the latest stable release. Scheduled nightlies still build the sealed,
+ad-hoc-signed fallback without secrets. A partial secret configuration stops every channel.
Add these GitHub Actions secrets to publish a Developer ID signed and notarized DMG:
diff --git a/scripts/ci-workflow-policy.test.ts b/scripts/ci-workflow-policy.test.ts
index e5c2b0b4a..a8ac2a6b3 100644
--- a/scripts/ci-workflow-policy.test.ts
+++ b/scripts/ci-workflow-policy.test.ts
@@ -199,13 +199,17 @@ describe("CI workflow budget", () => {
expect(text).toContain("gh workflow run version-packages.yml --ref main");
});
- it("builds an ad-hoc-signed macOS release when Apple credentials are absent", () => {
+ it("fails stable but not nightly macOS releases when Apple credentials are absent", () => {
const release = workflow(".github/workflows/release.yml");
const steps = release.jobs.desktop?.steps ?? [];
- expect(steps.find((step) => step.name === "Validate macOS signing credentials")?.run).toContain(
- "present != 0 && present != ${#values[@]}",
+ const validate = steps.find((step) => step.name === "Validate macOS signing credentials");
+ expect(validate?.run).toContain("present != 0 && present != ${#values[@]}");
+ expect(validate?.run).toContain(
+ "Stable macOS releases require the complete Developer ID signing credential set.",
);
+ expect(validate?.run).toContain('test "$RELEASE_CHANNEL" = stable');
+ expect(validate?.run).toMatch(/credential set\.\\n' >&2\n\s*exit 1/);
expect(steps.find((step) => step.name === "Build signed macOS artifact")?.if).toBe(
"matrix.platform == 'mac' && env.MACOS_SIGNED == 'true'",
);
diff --git a/scripts/release-smoke.ts b/scripts/release-smoke.ts
index 0173d678a..0f7cfd57c 100644
--- a/scripts/release-smoke.ts
+++ b/scripts/release-smoke.ts
@@ -113,6 +113,10 @@ for (const [needle, label] of [
["runner: windows-2025", "GitHub-hosted Windows runner"],
["runner: tenki-standard-medium-4c-8g", "Tenki Linux runner"],
["macOS signing credentials must be either complete or absent.", "macOS signing mode"],
+ [
+ "Stable macOS releases require the complete Developer ID signing credential set.",
+ "required stable macOS signing guard",
+ ],
["Build unsigned macOS artifact", "unsigned macOS fallback"],
["Verify unsigned macOS app signature", "unsigned macOS signature verification"],
["--signed", "existing signed build path"],