Open-source Grok Bot alternative for named AI teammates. Local-first desktop, web, and mobile clients with per-bot tools, instructions, and memory. Independent fork of T3 Code.
fix: open agent file links in the file viewer (#8098)
Wout Stiens99960383d094
diff --git a/apps/mobile/modules/t3-markdown-text/src/markdownLinks.ts b/apps/mobile/modules/t3-markdown-text/src/markdownLinks.tsindex f13891e3f..20637c6ba 100644--- a/apps/mobile/modules/t3-markdown-text/src/markdownLinks.ts+++ b/apps/mobile/modules/t3-markdown-text/src/markdownLinks.ts@@ -3,8 +3,10 @@ import type { MARKDOWN_FILE_ICON_SOURCES } from "./markdownFileIcons.generated";const WINDOWS_DRIVE_PATH_PATTERN = /^[A-Za-z]:[\\/]/;const WINDOWS_UNC_PATH_PATTERN = /^\\\\/;const RELATIVE_PATH_PREFIX_PATTERN = /^(~\/|\.{1,2}\/)/;-const RELATIVE_FILE_PATH_PATTERN = /^[A-Za-z0-9._-]+(?:\/[A-Za-z0-9._-]+)+(?::\d+){0,2}$/;-const RELATIVE_FILE_NAME_PATTERN = /^[A-Za-z0-9._-]+\.[A-Za-z0-9_-]+(?::\d+){0,2}$/;+const RELATIVE_FILE_PATH_PATTERN =+ /^(?:[A-Za-z0-9._-]+(?: +[A-Za-z0-9._-]+)*\/)+[A-Za-z0-9._-]+(?: +[A-Za-z0-9._-]+)*(?::\d+){0,2}$/;+const RELATIVE_FILE_NAME_PATTERN =+ /^[A-Za-z0-9._-]+(?: +[A-Za-z0-9._-]+)*\.[A-Za-z0-9_-]+(?::\d+){0,2}$/;const POSITION_SUFFIX_PATTERN = /:\d+(?::\d+)?$/;const POSIX_FILE_ROOT_PREFIXES = ["/Users/",diff --git a/apps/mobile/src/lib/markdownLinks.test.ts b/apps/mobile/src/lib/markdownLinks.test.tsindex ff57287b7..49a8b4664 100644--- a/apps/mobile/src/lib/markdownLinks.test.ts+++ b/apps/mobile/src/lib/markdownLinks.test.ts@@ -50,6 +50,24 @@ describe("resolveMarkdownLinkPresentation", () => {});});+ it.each(["md", "html", "xml"])("recognizes a bare spaced .%s filename", (extension) => {+ expect(+ resolveMarkdownLinkPresentation(`Updated%20cutover%20checklist.${extension}`),+ ).toMatchObject({+ kind: "file",+ path: `Updated cutover checklist.${extension}`,+ label: `Updated cutover checklist.${extension}`,+ });+ });++ it("recognizes spaced relative paths", () => {+ expect(resolveMarkdownLinkPresentation("docs/My%20Folder/checklist.xml")).toMatchObject({+ kind: "file",+ path: "docs/My Folder/checklist.xml",+ label: "checklist.xml",+ });+ });+it("extracts line fragments from relative file links", () => {expect(resolveMarkdownLinkPresentation("src/main.ts#L18C2")).toMatchObject({kind: "file",diff --git a/apps/web/src/components/ChatMarkdown.tsx b/apps/web/src/components/ChatMarkdown.tsxindex 0482d662a..a0a1a932f 100644--- a/apps/web/src/components/ChatMarkdown.tsx+++ b/apps/web/src/components/ChatMarkdown.tsx@@ -80,6 +80,7 @@ import {resolveInlineCodeFileLinkMeta,resolveMarkdownFileLinkMeta,rewriteMarkdownFileUriHref,+ shouldOpenMarkdownFileLinkInBrowserByDefault,shouldOpenMarkdownFileLinkInEditor,type MarkdownFileLinkMeta,} from "../markdown-links";@@ -1402,7 +1403,7 @@ const MarkdownFileLink = memo(function MarkdownFileLink({handleOpenInEditor();return;}- if (onOpenInBrowser) {+ if (onOpenInBrowser && shouldOpenMarkdownFileLinkInBrowserByDefault(iconPath)) {handleOpenInBrowser();return;}diff --git a/apps/web/src/markdown-links.test.ts b/apps/web/src/markdown-links.test.tsindex a1d1094bb..c7a2bcedc 100644--- a/apps/web/src/markdown-links.test.ts+++ b/apps/web/src/markdown-links.test.ts@@ -9,6 +9,7 @@ import {resolveMarkdownFileLinkMeta,resolveMarkdownFileLinkTarget,rewriteMarkdownFileUriHref,+ shouldOpenMarkdownFileLinkInBrowserByDefault,shouldOpenMarkdownFileLinkInEditor,} from "./markdown-links";@@ -69,6 +70,15 @@ describe("shouldOpenMarkdownFileLinkInEditor", () => {});});+describe("shouldOpenMarkdownFileLinkInBrowserByDefault", () => {+ it("keeps PDFs browser-first while source files open in the file viewer", () => {+ expect(shouldOpenMarkdownFileLinkInBrowserByDefault("report.pdf")).toBe(true);+ expect(shouldOpenMarkdownFileLinkInBrowserByDefault("report.PDF?download=1")).toBe(true);+ expect(shouldOpenMarkdownFileLinkInBrowserByDefault("report.html")).toBe(false);+ expect(shouldOpenMarkdownFileLinkInBrowserByDefault("report.xml")).toBe(false);+ });+});+describe("rewriteMarkdownFileUriHref", () => {it("rewrites file uri hrefs into direct path hrefs", () => {expect(rewriteMarkdownFileUriHref("file:///Users/julius/project/src/main.ts#L42")).toBe(@@ -198,6 +208,20 @@ describe("resolveMarkdownFileLinkTarget", () => {});});+ it.each(["md", "html", "xml"])(+ "resolves a bare spaced .%s filename from the markdown renderer",+ (extension) => {+ const href = renderMarkdownLinkHref(`[checklist](<Updated cutover checklist.${extension}>)`);++ expect(href).toBe(`Updated%20cutover%20checklist.${extension}`);+ expect(resolveMarkdownFileLinkMeta(href, "/repo/project")).toMatchObject({+ targetPath: `/repo/project/Updated cutover checklist.${extension}`,+ workspaceRelativePath: `Updated cutover checklist.${extension}`,+ basename: `Updated cutover checklist.${extension}`,+ });+ },+ );+it("formats tooltip display paths relative to the cwd for slash-prefixed windows paths", () => {expect(resolveMarkdownFileLinkMeta(diff --git a/apps/web/src/markdown-links.ts b/apps/web/src/markdown-links.tsindex 6ba2c78e1..24ecd1906 100644--- a/apps/web/src/markdown-links.ts+++ b/apps/web/src/markdown-links.ts@@ -11,7 +11,8 @@ const EXTERNAL_SCHEME_PATTERN = /^([A-Za-z][A-Za-z0-9+.-]*):(.*)$/;const RELATIVE_PATH_PREFIX_PATTERN = /^(~\/|\.{1,2}\/)/;const RELATIVE_FILE_PATH_PATTERN =/^(?:[A-Za-z0-9._-]+(?: +[A-Za-z0-9._-]+)*\/)+[A-Za-z0-9._-]+(?: +[A-Za-z0-9._-]+)*(?::\d+){0,2}$/;-const RELATIVE_FILE_NAME_PATTERN = /^[A-Za-z0-9._-]+\.[A-Za-z0-9_-]+(?::\d+){0,2}$/;+const RELATIVE_FILE_NAME_PATTERN =+ /^[A-Za-z0-9._-]+(?: +[A-Za-z0-9._-]+)*\.[A-Za-z0-9_-]+(?::\d+){0,2}$/;const POSITION_SUFFIX_PATTERN = /:\d+(?::\d+)?$/;const POSITION_ONLY_PATTERN = /^\d+(?::\d+)?$/;// Standard OS and dev-container roots; deliberately excludes app-route-ish@@ -71,6 +72,10 @@ export function shouldOpenMarkdownFileLinkInEditor(return isTerminalLinkActivation(event, platform);}+export function shouldOpenMarkdownFileLinkInBrowserByDefault(path: string): boolean {+ return /\.pdf$/i.test(path.split(/[?#]/, 1)[0] ?? "");+}+function safeDecode(value: string): string {try {return decodeURIComponent(value);