Skip to content

Open-source Grok Bot alternative for named AI teammates. Local-first desktop, web, and mobile clients with per-bot tools, instructions, and memory. Independent fork of T3 Code.

fix(web): show Grok models during limited probes (#129)

Leob62b6e7089e5
diff --git a/apps/web/src/components/chat/ModelPickerContent.tsx b/apps/web/src/components/chat/ModelPickerContent.tsx
index 8729b1bf8..e046988b0 100644
--- a/apps/web/src/components/chat/ModelPickerContent.tsx
+++ b/apps/web/src/components/chat/ModelPickerContent.tsx
@@ -36,7 +36,7 @@ import { cn } from "~/lib/utils";
import { getVirtualizedScrollFadeClassName } from "../ui/scroll-area";
import { TooltipProvider } from "../ui/tooltip";
import {
- isProviderInstancePickerReady,
+ isProviderInstancePickerSelectable,
isProviderInstancePickerVisible,
type ProviderInstanceEntry,
} from "../../providerInstances";
@@ -189,14 +189,14 @@ export const ModelPickerContent = memo(function ModelPickerContent(props: {
[props.lockedContinuationGroupKey, props.lockedProvider],
);
- const readyInstanceSet = useMemo(() => {
- const ready = new Set<ProviderInstanceId>();
+ const selectableInstanceSet = useMemo(() => {
+ const selectable = new Set<ProviderInstanceId>();
for (const entry of instanceEntries) {
- if (isProviderInstancePickerReady(entry)) {
- ready.add(entry.instanceId);
+ if (isProviderInstancePickerSelectable(entry)) {
+ selectable.add(entry.instanceId);
}
}
- return ready;
+ return selectable;
}, [instanceEntries]);
// Flatten models into a searchable array. One pass over the
@@ -212,7 +212,7 @@ export const ModelPickerContent = memo(function ModelPickerContent(props: {
// its models — stale options shouldn't appear in the picker.
continue;
}
- if (!readyInstanceSet.has(instanceId)) {
+ if (!selectableInstanceSet.has(instanceId)) {
continue;
}
for (const model of models) {
@@ -233,7 +233,7 @@ export const ModelPickerContent = memo(function ModelPickerContent(props: {
}
}
return out;
- }, [modelOptionsByInstance, entryByInstanceId, readyInstanceSet]);
+ }, [modelOptionsByInstance, entryByInstanceId, selectableInstanceSet]);
const isLocked = props.lockedProvider !== null;
const isSearching = searchQuery.trim().length > 0;
diff --git a/apps/web/src/components/chat/ModelPickerSidebar.tsx b/apps/web/src/components/chat/ModelPickerSidebar.tsx
index 98db6a9c1..c366fd240 100644
--- a/apps/web/src/components/chat/ModelPickerSidebar.tsx
+++ b/apps/web/src/components/chat/ModelPickerSidebar.tsx
@@ -6,6 +6,7 @@ import { Tooltip, TooltipPopup, TooltipTrigger } from "../ui/tooltip";
import { cn } from "~/lib/utils";
import {
isProviderInstancePickerReady,
+ isProviderInstancePickerSelectable,
shouldShowInstanceBadge,
type ProviderInstanceEntry,
} from "../../providerInstances";
@@ -133,7 +134,8 @@ export const ModelPickerSidebar = memo(function ModelPickerSidebar(props: {
{/* Instance buttons (one per configured instance — built-in + custom) */}
{props.instanceEntries.map((entry) => {
- const isUnavailable = !isProviderInstancePickerReady(entry);
+ const isUnavailable = !isProviderInstancePickerSelectable(entry);
+ const isNotReady = !isProviderInstancePickerReady(entry);
const isContextDisabled = props.disabledInstanceIds?.has(entry.instanceId) ?? false;
const isDisabled = isUnavailable || isContextDisabled;
const isSelected = props.selectedInstanceId === entry.instanceId;
@@ -141,7 +143,7 @@ export const ModelPickerSidebar = memo(function ModelPickerSidebar(props: {
const showNewBadge = props.newBadgeInstanceIds?.has(entry.instanceId) ?? false;
const showInstanceBadge = shouldShowInstanceBadge(entry, props.instanceEntries);
- const tooltip = isUnavailable
+ const tooltip = isNotReady
? describeUnavailableInstance(entry)
: isContextDisabled
? (props.getDisabledInstanceTooltip?.(entry) ?? entry.displayName)
diff --git a/apps/web/src/providerInstances.test.ts b/apps/web/src/providerInstances.test.ts
index b64a5e25d..b58069109 100644
--- a/apps/web/src/providerInstances.test.ts
+++ b/apps/web/src/providerInstances.test.ts
@@ -6,6 +6,7 @@ import {
deriveProviderInstanceEntries,
getDefaultProviderInstanceModel,
isProviderInstancePickerReady,
+ isProviderInstancePickerSelectable,
isProviderInstancePickerVisible,
resolveDefaultProviderModelSelection,
resolveSelectableProviderInstance,
@@ -16,7 +17,9 @@ function provider(input: {
provider: ProviderDriverKind;
instanceId: string;
enabled?: boolean;
+ installed?: boolean;
availability?: ServerProvider["availability"];
+ authStatus?: ServerProvider["auth"]["status"];
displayName?: string;
accentColor?: string;
status?: ServerProvider["status"];
@@ -28,11 +31,11 @@ function provider(input: {
...(input.displayName ? { displayName: input.displayName } : {}),
...(input.accentColor ? { accentColor: input.accentColor } : {}),
enabled: input.enabled ?? true,
- installed: true,
+ installed: input.installed ?? true,
version: null,
status: input.status ?? "ready",
...(input.availability ? { availability: input.availability } : {}),
- auth: { status: "authenticated" },
+ auth: { status: input.authStatus ?? "authenticated" },
checkedAt: "2026-01-01T00:00:00.000Z",
models: input.models ?? [],
slashCommands: [],
@@ -71,6 +74,60 @@ describe("isProviderInstancePickerReady", () => {
});
});
+describe("isProviderInstancePickerSelectable", () => {
+ it("keeps installed provider models selectable while the probe is limited", () => {
+ const [entry] = deriveProviderInstanceEntries([
+ provider({
+ provider: ProviderDriverKind.make("grok"),
+ instanceId: "grok",
+ status: "warning",
+ models: [model("grok-build")],
+ }),
+ ]);
+
+ expect(entry && isProviderInstancePickerSelectable(entry)).toBe(true);
+ });
+
+ it("rejects missing and explicitly unauthenticated providers", () => {
+ const [missing, unauthenticated] = deriveProviderInstanceEntries([
+ provider({
+ provider: ProviderDriverKind.make("grok"),
+ instanceId: "grok_missing",
+ installed: false,
+ }),
+ provider({
+ provider: ProviderDriverKind.make("grok"),
+ instanceId: "grok_signed_out",
+ authStatus: "unauthenticated",
+ }),
+ ]);
+
+ expect(missing && isProviderInstancePickerSelectable(missing)).toBe(false);
+ expect(unauthenticated && isProviderInstancePickerSelectable(unauthenticated)).toBe(false);
+ });
+
+ it("rejects disabled provider snapshots with explicit or omitted availability", () => {
+ const [available, availabilityOmitted] = deriveProviderInstanceEntries([
+ provider({
+ provider: ProviderDriverKind.make("grok"),
+ instanceId: "grok_available",
+ status: "disabled",
+ availability: "available",
+ }),
+ provider({
+ provider: ProviderDriverKind.make("grok"),
+ instanceId: "grok_availability_omitted",
+ status: "disabled",
+ }),
+ ]);
+
+ expect(available && isProviderInstancePickerSelectable(available)).toBe(false);
+ expect(availabilityOmitted && isProviderInstancePickerSelectable(availabilityOmitted)).toBe(
+ false,
+ );
+ });
+});
+
describe("isProviderInstancePickerVisible", () => {
it("keeps enabled instances in the rail and removes disabled instances", () => {
const [enabledEntry, disabledEntry] = deriveProviderInstanceEntries([
diff --git a/apps/web/src/providerInstances.ts b/apps/web/src/providerInstances.ts
index ef60d554d..08af444ff 100644
--- a/apps/web/src/providerInstances.ts
+++ b/apps/web/src/providerInstances.ts
@@ -75,6 +75,24 @@ export function isProviderInstancePickerReady(entry: ProviderInstanceEntry): boo
return entry.enabled && entry.isAvailable && entry.status === "ready";
}
+/**
+ * Whether an instance can expose its known models in the picker.
+ *
+ * A warning or error probe does not erase the server's model inventory. The
+ * user can still pick one of those models and retry the provider, matching the
+ * mobile client. Missing installs and explicit authentication failures remain
+ * unavailable.
+ */
+export function isProviderInstancePickerSelectable(entry: ProviderInstanceEntry): boolean {
+ return (
+ entry.enabled &&
+ entry.isAvailable &&
+ entry.installed &&
+ entry.status !== "disabled" &&
+ entry.snapshot.auth.status !== "unauthenticated"
+ );
+}
+
/** Picker rails contain configured, enabled instances only. */
export function isProviderInstancePickerVisible(entry: ProviderInstanceEntry): boolean {
return entry.enabled;