Open-source Grok Bot alternative for named AI teammates. Local-first desktop, web, and mobile clients with per-bot tools, instructions, and memory. Independent fork of T3 Code.
fix(server): wait for concurrent SQLite writers instead of failing with SQLITE_BUSY (#5134)
Ostapc0f9d917c1ab
diff --git a/apps/server/src/persistence/Layers/Sqlite.test.ts b/apps/server/src/persistence/Layers/Sqlite.test.tsnew file mode 100644index 000000000..0b64e4f7f--- /dev/null+++ b/apps/server/src/persistence/Layers/Sqlite.test.ts@@ -0,0 +1,66 @@+// @effect-diagnostics nodeBuiltinImport:off+import * as NodeChildProcess from "node:child_process";+import * as NodeFS from "node:fs";+import * as NodeOS from "node:os";+import * as NodePath from "node:path";++import * as NodeServices from "@effect/platform-node/NodeServices";+import { assert, it } from "@effect/vitest";+import * as Effect from "effect/Effect";+import * as Layer from "effect/Layer";+import * as SqlClient from "effect/unstable/sql/SqlClient";++import { SqlitePersistenceMemory, makeSqlitePersistenceLive } from "./Sqlite.ts";++const lockHolderSource = `+const { DatabaseSync } = require("node:sqlite");+const db = new DatabaseSync(process.argv[1]);+db.exec("BEGIN IMMEDIATE");+process.stdout.write("locked\\n");+setTimeout(() => {+ db.exec("COMMIT");+ db.close();+}, Number(process.argv[2]));+`;++const spawnWriteLockHolder = (dbPath: string, holdMs: number) =>+ Effect.promise(+ () =>+ new Promise<void>((resolve, reject) => {+ const holder = NodeChildProcess.spawn(+ process.execPath,+ ["-e", lockHolderSource, dbPath, String(holdMs)],+ { stdio: ["ignore", "pipe", "ignore"] },+ );+ holder.stdout.once("data", () => resolve());+ holder.on("error", reject);+ holder.on("exit", () =>+ reject(new Error("lock holder exited before acquiring the write lock")),+ );+ }),+ );++it.effect("waits out a concurrent writer instead of failing with SQLITE_BUSY", () => {+ const tempDir = NodeFS.mkdtempSync(NodePath.join(NodeOS.tmpdir(), "t3-sqlite-busy-"));+ const dbPath = NodePath.join(tempDir, "state.sqlite");++ return Effect.gen(function* () {+ const sql = yield* SqlClient.SqlClient;+ yield* sql`CREATE TABLE busy_probe(id INTEGER PRIMARY KEY)`;+ yield* spawnWriteLockHolder(dbPath, 300);+ yield* sql`INSERT INTO busy_probe(id) VALUES (${1})`;+ const rows = yield* sql<{ readonly id: number }>`SELECT id FROM busy_probe`;+ assert.deepEqual([...rows], [{ id: 1 }]);+ }).pipe(+ Effect.provide(makeSqlitePersistenceLive(dbPath).pipe(Layer.provide(NodeServices.layer))),+ Effect.ensuring(Effect.sync(() => NodeFS.rmSync(tempDir, { recursive: true, force: true }))),+ );+});++it.effect("applies busy_timeout in the shared persistence setup", () =>+ Effect.gen(function* () {+ const sql = yield* SqlClient.SqlClient;+ const rows = yield* sql<{ readonly timeout: number }>`PRAGMA busy_timeout`;+ assert.equal(rows[0]?.timeout, 5000);+ }).pipe(Effect.provide(SqlitePersistenceMemory)),+);diff --git a/apps/server/src/persistence/Layers/Sqlite.ts b/apps/server/src/persistence/Layers/Sqlite.tsindex d1e002501..ec1ffdefa 100644--- a/apps/server/src/persistence/Layers/Sqlite.ts+++ b/apps/server/src/persistence/Layers/Sqlite.ts@@ -33,6 +33,8 @@ const makeRuntimeSqliteLayer = Effect.fn("makeRuntimeSqliteLayer")(function* (const setup = Layer.effectDiscard(Effect.gen(function* () {const sql = yield* SqlClient.SqlClient;+ // CLI and server write from separate processes; wait rather than fail with SQLITE_BUSY.+ yield* sql`PRAGMA busy_timeout = 5000;`;yield* sql`PRAGMA foreign_keys = ON;`;yield* sql`PRAGMA journal_mode = WAL;`;yield* runMigrations();