Skip to content

Open-source Grok Bot alternative for named AI teammates. Local-first desktop, web, and mobile clients with per-bot tools, instructions, and memory. Independent fork of T3 Code.

[codex] fix: preserve localhost preview hosts (#3499)

Wout Stiensc1e2408e1f31
diff --git a/apps/web/src/browser/browserTargetResolver.test.ts b/apps/web/src/browser/browserTargetResolver.test.ts
index 230581278..d3c7f6a8d 100644
--- a/apps/web/src/browser/browserTargetResolver.test.ts
+++ b/apps/web/src/browser/browserTargetResolver.test.ts
@@ -47,6 +47,14 @@ describe("browser target resolver", () => {
).toBe("http://localhost:3000/app");
});
+ it("preserves localhost server-picker values when the prepared base is 127.0.0.1", async () => {
+ readPreparedConnection.mockReturnValue({ httpBaseUrl: "http://127.0.0.1:3773" });
+ const { resolveDiscoveredServerUrl } = await import("./browserTargetResolver");
+ expect(
+ resolveDiscoveredServerUrl(EnvironmentId.make("environment-1"), "localhost:5173/app?x=1#top"),
+ ).toBe("http://localhost:5173/app?x=1#top");
+ });
+
it("normalizes public URLs without treating them as environment ports", async () => {
const { resolveDiscoveredServerUrl } = await import("./browserTargetResolver");
expect(resolveDiscoveredServerUrl(EnvironmentId.make("environment-1"), "example.com/app")).toBe(
diff --git a/apps/web/src/browser/browserTargetResolver.ts b/apps/web/src/browser/browserTargetResolver.ts
index 0a6dc3aa7..9142cce1e 100644
--- a/apps/web/src/browser/browserTargetResolver.ts
+++ b/apps/web/src/browser/browserTargetResolver.ts
@@ -24,6 +24,11 @@ const isPrivateNetworkHost = (host: string): boolean => {
);
};
+const isLocalLoopbackHost = (host: string): boolean => {
+ const normalized = host.toLowerCase().replace(/^\[|\]$/g, "");
+ return normalized === "localhost" || normalized === "127.0.0.1" || normalized === "::1";
+};
+
export function resolveBrowserNavigationTarget(
environmentId: EnvironmentId,
target: BrowserNavigationTarget,
@@ -68,6 +73,12 @@ export function resolveDiscoveredServerUrl(environmentId: EnvironmentId, rawUrl:
const normalizedUrl = normalizePreviewUrl(rawUrl);
const parsed = new URL(normalizedUrl);
if (!isLoopbackHost(parsed.hostname)) return normalizedUrl;
+ const connection = readPreparedConnection(environmentId);
+ if (!connection) throw new Error(`Environment ${environmentId} is not connected.`);
+ const environmentUrl = new URL(connection.httpBaseUrl);
+ if (parsed.hostname !== "0.0.0.0" && isLocalLoopbackHost(environmentUrl.hostname)) {
+ return normalizedUrl;
+ }
const port = Number(parsed.port || (parsed.protocol === "https:" ? 443 : 80));
return resolveBrowserNavigationTarget(environmentId, {
kind: "environment-port",