Skip to content

Open-source Grok Bot alternative for named AI teammates. Local-first desktop, web, and mobile clients with per-bot tools, instructions, and memory. Independent fork of T3 Code.

fix(server): stop the provider title mirror from overwriting real thread titles (#5941)

Ulises Britosddee418a8d6d
diff --git a/apps/server/src/orchestration/Layers/ProviderCommandReactor.ts b/apps/server/src/orchestration/Layers/ProviderCommandReactor.ts
index ff6397971..cfc95f261 100644
--- a/apps/server/src/orchestration/Layers/ProviderCommandReactor.ts
+++ b/apps/server/src/orchestration/Layers/ProviderCommandReactor.ts
@@ -39,6 +39,7 @@ import {
type ProviderCommandReactorShape,
} from "../Services/ProviderCommandReactor.ts";
import { forkParked, ServerActivation } from "../../serverActivation.ts";
+import { canReplaceThreadTitle, DEFAULT_THREAD_TITLE } from "../threadTitles.ts";
import {
resolveSourceControlWriterModelSelection,
ServerSettingsService,
@@ -91,7 +92,6 @@ const turnStartKeyForEvent = (event: ProviderIntentEvent): string =>
const HANDLED_TURN_START_KEY_MAX = 10_000;
const HANDLED_TURN_START_KEY_TTL = Duration.minutes(30);
const DEFAULT_RUNTIME_MODE: RuntimeMode = "full-access";
-const DEFAULT_THREAD_TITLE = "New thread";
const MAX_REGENERATION_ATTACHMENTS = 4;
const MAX_THREAD_TITLE_CONTEXT_CHARS = 8_000;
const MAX_FIRST_USER_TITLE_CONTEXT_CHARS = 2_000;
@@ -227,18 +227,6 @@ export function providerErrorLabelFromInstanceHint(input: {
);
}
-function canReplaceThreadTitle(currentTitle: string, titleSeed?: string): boolean {
- const trimmedCurrentTitle = currentTitle.trim();
- if (trimmedCurrentTitle === DEFAULT_THREAD_TITLE) {
- return true;
- }
-
- const trimmedTitleSeed = titleSeed?.trim();
- return trimmedTitleSeed !== undefined && trimmedTitleSeed.length > 0
- ? trimmedCurrentTitle === trimmedTitleSeed
- : false;
-}
-
function findProviderAdapterRequestError(
cause: Cause.Cause<ProviderServiceError>,
): ProviderAdapterRequestError | undefined {
@@ -626,6 +614,7 @@ const make = Effect.gen(function* () {
...(preferredProvider ? { provider: preferredProvider } : {}),
providerInstanceId: desiredInstanceId,
...(effectiveCwd ? { cwd: effectiveCwd } : {}),
+ ...(thread.title ? { title: thread.title } : {}),
modelSelection: desiredModelSelection,
...(input?.resumeCursor !== undefined ? { resumeCursor: input.resumeCursor } : {}),
runtimeMode: desiredRuntimeMode,
diff --git a/apps/server/src/orchestration/Layers/ProviderRuntimeIngestion.test.ts b/apps/server/src/orchestration/Layers/ProviderRuntimeIngestion.test.ts
index 258aa010e..449b1fbf5 100644
--- a/apps/server/src/orchestration/Layers/ProviderRuntimeIngestion.test.ts
+++ b/apps/server/src/orchestration/Layers/ProviderRuntimeIngestion.test.ts
@@ -48,6 +48,7 @@ import { OrchestrationProjectionSnapshotQueryLive } from "./ProjectionSnapshotQu
import * as ThreadBackgroundLiveness from "../ThreadBackgroundLiveness.ts";
import * as ThreadPlanProgress from "../ThreadPlanProgress.ts";
import { ProviderRuntimeIngestionLive } from "./ProviderRuntimeIngestion.ts";
+import { DEFAULT_THREAD_TITLE } from "../threadTitles.ts";
import { OrchestrationEngineService } from "../Services/OrchestrationEngine.ts";
import { ProviderRuntimeIngestionService } from "../Services/ProviderRuntimeIngestion.ts";
import { ProjectionSnapshotQuery } from "../Services/ProjectionSnapshotQuery.ts";
@@ -221,7 +222,10 @@ describe("ProviderRuntimeIngestion", () => {
}
});
- async function createHarness(options?: { serverSettings?: Partial<ServerSettings> }) {
+ async function createHarness(options?: {
+ serverSettings?: Partial<ServerSettings>;
+ threadTitle?: string;
+ }) {
const workspaceRoot = makeTempDir("t3-provider-project-");
NodeFS.mkdirSync(NodePath.join(workspaceRoot, ".git"));
const provider = createProviderServiceHarness();
@@ -277,7 +281,7 @@ describe("ProviderRuntimeIngestion", () => {
commandId: CommandId.make("cmd-thread-create"),
threadId: ThreadId.make("thread-1"),
projectId: asProjectId("project-1"),
- title: "Thread",
+ title: options?.threadTitle ?? "Thread",
modelSelection: {
instanceId: ProviderInstanceId.make("codex"),
model: "gpt-5-codex",
@@ -2915,7 +2919,7 @@ describe("ProviderRuntimeIngestion", () => {
const thread = await waitForThread(
harness.readModel,
(entry) =>
- entry.title === "Renamed by provider" &&
+ entry.title === "Thread" &&
entry.activities.some(
(activity: ProviderRuntimeTestActivity) => activity.kind === "turn.plan.updated",
) &&
@@ -2930,7 +2934,7 @@ describe("ProviderRuntimeIngestion", () => {
),
);
- expect(thread.title).toBe("Renamed by provider");
+ expect(thread.title).toBe("Thread");
const planActivity = thread.activities.find(
(activity: ProviderRuntimeTestActivity) => activity.id === "evt-turn-plan-updated",
@@ -2971,6 +2975,51 @@ describe("ProviderRuntimeIngestion", () => {
expect(checkpoint?.checkpointRef).toBe("provider-diff:evt-turn-diff-updated");
});
+ it("mirrors a provider title only while the thread still has the default title", async () => {
+ const harness = await createHarness({ threadTitle: DEFAULT_THREAD_TITLE });
+ const now = "2026-01-01T00:00:00.000Z";
+
+ harness.emit({
+ type: "thread.metadata.updated",
+ eventId: asEventId("evt-thread-metadata-default"),
+ provider: ProviderDriverKind.make("codex"),
+ createdAt: now,
+ threadId: asThreadId("thread-1"),
+ payload: {
+ name: "Renamed by provider",
+ metadata: { source: "provider" },
+ },
+ });
+
+ const thread = await waitForThread(
+ harness.readModel,
+ (entry) => entry.title === "Renamed by provider",
+ );
+ expect(thread.title).toBe("Renamed by provider");
+ });
+
+ it("rejects a provider title once the thread has a real title", async () => {
+ const harness = await createHarness({ threadTitle: "User-set title" });
+ const now = "2026-01-01T00:00:00.000Z";
+
+ harness.emit({
+ type: "thread.metadata.updated",
+ eventId: asEventId("evt-thread-metadata-real"),
+ provider: ProviderDriverKind.make("codex"),
+ createdAt: now,
+ threadId: asThreadId("thread-1"),
+ payload: {
+ name: "Renamed by provider",
+ metadata: { source: "provider" },
+ },
+ });
+
+ await harness.drain();
+ const readModel = await harness.readModel();
+ const thread = readModel.threads.find((entry) => entry.id === ThreadId.make("thread-1"));
+ expect(thread?.title).toBe("User-set title");
+ });
+
it("projects context window updates into normalized thread activities", async () => {
const harness = await createHarness();
const now = "2026-01-01T00:00:00.000Z";
diff --git a/apps/server/src/orchestration/Layers/ProviderRuntimeIngestion.ts b/apps/server/src/orchestration/Layers/ProviderRuntimeIngestion.ts
index 032537972..c942960f3 100644
--- a/apps/server/src/orchestration/Layers/ProviderRuntimeIngestion.ts
+++ b/apps/server/src/orchestration/Layers/ProviderRuntimeIngestion.ts
@@ -43,6 +43,7 @@ import {
} from "../Services/ProviderRuntimeIngestion.ts";
import { forkParked } from "../../serverActivation.ts";
import { ServerSettingsService } from "../../serverSettings.ts";
+import { canReplaceThreadTitle } from "../threadTitles.ts";
const providerTurnKey = (threadId: ThreadId, turnId: TurnId) => `${threadId}:${turnId}`;
const providerTaskKey = (threadId: ThreadId, taskId: string) => `${threadId}:${taskId}`;
@@ -1892,12 +1893,14 @@ const make = Effect.gen(function* () {
}
if (event.type === "thread.metadata.updated" && event.payload.name) {
- yield* orchestrationEngine.dispatch({
- type: "thread.meta.update",
- commandId: yield* providerCommandId(event, "thread-meta-update"),
- threadId: thread.id,
- title: event.payload.name,
- });
+ if (canReplaceThreadTitle(thread.title)) {
+ yield* orchestrationEngine.dispatch({
+ type: "thread.meta.update",
+ commandId: yield* providerCommandId(event, "thread-meta-update"),
+ threadId: thread.id,
+ title: event.payload.name,
+ });
+ }
}
if (event.type === "turn.diff.updated") {
diff --git a/apps/server/src/orchestration/threadTitles.ts b/apps/server/src/orchestration/threadTitles.ts
new file mode 100644
index 000000000..c9a9c4f72
--- /dev/null
+++ b/apps/server/src/orchestration/threadTitles.ts
@@ -0,0 +1,13 @@
+export const DEFAULT_THREAD_TITLE = "New thread";
+
+export function canReplaceThreadTitle(currentTitle: string, titleSeed?: string): boolean {
+ const trimmedCurrentTitle = currentTitle.trim();
+ if (trimmedCurrentTitle === DEFAULT_THREAD_TITLE) {
+ return true;
+ }
+
+ const trimmedTitleSeed = titleSeed?.trim();
+ return trimmedTitleSeed !== undefined && trimmedTitleSeed.length > 0
+ ? trimmedCurrentTitle === trimmedTitleSeed
+ : false;
+}
diff --git a/apps/server/src/provider/Layers/OpenCodeAdapter.test.ts b/apps/server/src/provider/Layers/OpenCodeAdapter.test.ts
index 1385ccbaa..eea328e05 100644
--- a/apps/server/src/provider/Layers/OpenCodeAdapter.test.ts
+++ b/apps/server/src/provider/Layers/OpenCodeAdapter.test.ts
@@ -1191,6 +1191,73 @@ it.layer(OpenCodeAdapterTestLayer)("OpenCodeAdapterLive", (it) => {
}),
);
+ it.effect("passes the thread title to session.create when provided", () =>
+ Effect.gen(function* () {
+ const adapter = yield* OpenCodeAdapter;
+ const threadId = asThreadId("thread-opencode-title-provided");
+
+ yield* adapter.startSession({
+ provider: ProviderDriverKind.make("opencode"),
+ threadId,
+ runtimeMode: "full-access",
+ title: "Investigate reconnect failures",
+ });
+
+ NodeAssert.equal(runtimeMock.state.sessionCreateInputs.length, 1);
+ NodeAssert.equal(
+ runtimeMock.state.sessionCreateInputs[0]?.title,
+ "Investigate reconnect failures",
+ );
+ }),
+ );
+
+ it.effect("does not mirror OpenCode's default placeholder session titles", () =>
+ Effect.gen(function* () {
+ const adapter = yield* OpenCodeAdapter;
+ const threadId = asThreadId("thread-opencode-placeholder-title");
+ runtimeMock.state.subscribedEvents = [
+ {
+ type: "session.updated",
+ properties: {
+ info: {
+ id: "http://127.0.0.1:9999/session",
+ title: "New session - 2026-08-09T10:20:30.456Z",
+ },
+ },
+ },
+ {
+ type: "session.updated",
+ properties: {
+ info: {
+ id: "http://127.0.0.1:9999/session",
+ title: "Investigate reconnect failures",
+ },
+ },
+ },
+ ];
+
+ const eventsFiber = yield* adapter.streamEvents.pipe(
+ Stream.filter((event) => event.threadId === threadId),
+ Stream.take(3),
+ Stream.runCollect,
+ Effect.forkChild,
+ );
+
+ yield* adapter.startSession({
+ provider: ProviderDriverKind.make("opencode"),
+ threadId,
+ runtimeMode: "full-access",
+ });
+
+ const events = Array.from(yield* Fiber.join(eventsFiber).pipe(Effect.timeout("1 second")));
+ const metadataUpdated = events.filter((event) => event.type === "thread.metadata.updated");
+ NodeAssert.equal(metadataUpdated.length, 1);
+ if (metadataUpdated[0]?.type === "thread.metadata.updated") {
+ NodeAssert.equal(metadataUpdated[0].payload.name, "Investigate reconnect failures");
+ }
+ }),
+ );
+
it.effect("writes provider-native observability records using the session thread id", () =>
Effect.gen(function* () {
const nativeEvents: Array<{
diff --git a/apps/server/src/provider/Layers/OpenCodeAdapter.ts b/apps/server/src/provider/Layers/OpenCodeAdapter.ts
index 73c23b77e..8f7e42c11 100644
--- a/apps/server/src/provider/Layers/OpenCodeAdapter.ts
+++ b/apps/server/src/provider/Layers/OpenCodeAdapter.ts
@@ -201,7 +201,24 @@ function openCodeEventSessionTitle(event: OpenCodeSubscribedEvent): string | und
return undefined;
}
- return trimText(event.properties.info.title);
+ const title = trimText(event.properties.info.title);
+ // OpenCode mints a placeholder title at session.create when no title was
+ // provided, and re-emits it on every `session.updated`. Mirroring it would
+ // overwrite the thread's real title (openCodeEventSessionTitle feeds the
+ // `thread.metadata.updated` mirror). Ignore OpenCode's auto-generated
+ // placeholders so the thread isn't locked onto them.
+ if (!title || isOpenCodeDefaultTitle(title)) {
+ return undefined;
+ }
+
+ return title;
+}
+
+const OPENCODE_DEFAULT_TITLE_PATTERN =
+ /^(New session - |Child session - )\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}\.\d{3}Z$/;
+
+function isOpenCodeDefaultTitle(title: string): boolean {
+ return OPENCODE_DEFAULT_TITLE_PATTERN.test(title);
}
interface OpenCodeSessionContext {
@@ -1302,6 +1319,7 @@ export function makeOpenCodeAdapter(
}
const createdSession = yield* runOpenCodeSdk("session.create", () =>
client.session.create({
+ ...(input.title ? { title: input.title } : {}),
permission: buildOpenCodePermissionRules(input.runtimeMode),
}),
);
diff --git a/packages/contracts/src/provider.ts b/packages/contracts/src/provider.ts
index 94fb007a7..c84ad43c4 100644
--- a/packages/contracts/src/provider.ts
+++ b/packages/contracts/src/provider.ts
@@ -56,6 +56,7 @@ export const ProviderSessionStartInput = Schema.Struct({
// See ProviderSession for the migration story.
providerInstanceId: Schema.optional(ProviderInstanceId),
cwd: Schema.optional(TrimmedNonEmptyString),
+ title: Schema.optional(TrimmedNonEmptyString),
modelSelection: Schema.optional(ModelSelection),
resumeCursor: Schema.optional(Schema.Unknown),
approvalPolicy: Schema.optional(ProviderApprovalPolicy),