Open-source Grok Bot alternative for named AI teammates. Local-first desktop, web, and mobile clients with per-bot tools, instructions, and memory. Independent fork of T3 Code.
fix(web): widen ordered-list marker gutter for 3+ digit item numbers (#6527)
Lars Nieuwenhuiseaa6c4712fe1
diff --git a/apps/web/src/components/ChatMarkdown.test.tsx b/apps/web/src/components/ChatMarkdown.test.tsxnew file mode 100644index 000000000..9499ee5a6--- /dev/null+++ b/apps/web/src/components/ChatMarkdown.test.tsx@@ -0,0 +1,36 @@+import { describe, expect, it } from "vite-plus/test";++import { orderedListGutterStyle } from "./ChatMarkdown";++describe("orderedListGutterStyle", () => {+ it("leaves the default gutter alone for single-digit lists", () => {+ expect(orderedListGutterStyle(9, undefined)).toBeUndefined();+ });++ it("leaves the default gutter alone for two-digit lists", () => {+ expect(orderedListGutterStyle(99, undefined)).toBeUndefined();+ });++ it("leaves the default gutter alone for a two-digit list that starts above 1", () => {+ // start=50 + 49 items => last marker is "98", still two digits.+ expect(orderedListGutterStyle(49, 50)).toBeUndefined();+ });++ it("widens the gutter once the last marker reaches three digits", () => {+ // item 100 is the bug from #6512: a 100-item list starting at 1.+ expect(orderedListGutterStyle(100, undefined)).toEqual({ "--list-gutter": "4ch" });+ });++ it("accounts for a non-default start attribute", () => {+ // start=95 + 9 items => last marker is "103", three digits.+ expect(orderedListGutterStyle(9, 95)).toEqual({ "--list-gutter": "4ch" });+ });++ it("scales further for four-digit markers", () => {+ expect(orderedListGutterStyle(1000, undefined)).toEqual({ "--list-gutter": "5ch" });+ });++ it("treats a missing/zero item count as a single item", () => {+ expect(orderedListGutterStyle(0, undefined)).toBeUndefined();+ });+});diff --git a/apps/web/src/components/ChatMarkdown.tsx b/apps/web/src/components/ChatMarkdown.tsxindex 53b043f3a..294a9e22a 100644--- a/apps/web/src/components/ChatMarkdown.tsx+++ b/apps/web/src/components/ChatMarkdown.tsx@@ -146,6 +146,26 @@ function findTaskListMarkerOffset(markdown: string, listItemStart: number): numbif (!match?.[1]) return null;return listItemStart + firstLine.indexOf(match[1]);}++/**+ * The default `1.25rem` marker gutter (`.chat-markdown ol`) fits two-digit+ * decimal markers. Once a list's last item reaches three digits (item 100+),+ * `list-style-position: outside` paints the marker wider than that gutter and+ * the leading digit gets clipped by the item's own overflow. Rather than+ * widening the gutter for every list, only lists whose last marker is 3++ * digits get a wider `--list-gutter`, sized to that marker's digit count.+ */+export function orderedListGutterStyle(+ itemCount: number,+ start: number | undefined,+): { "--list-gutter": string } | undefined {+ const firstNumber = typeof start === "number" && Number.isFinite(start) ? start : 1;+ const lastNumber = firstNumber + Math.max(itemCount - 1, 0);+ const digits = String(Math.abs(lastNumber)).length;+ if (digits <= 2) return undefined;+ return { "--list-gutter": `${digits + 1}ch` };+}+const CHAT_MARKDOWN_SANITIZE_SCHEMA = {...defaultSchema,attributes: {@@ -1506,6 +1526,15 @@ function ChatMarkdown({</div>);},+ ol({ node, start, style, ...props }) {+ const itemCount =+ node?.children?.filter((child) => child.type === "element" && child.tagName === "li")+ .length ?? 0;+ const gutterStyle = orderedListGutterStyle(itemCount, start);+ return (+ <ol {...props} start={start} style={gutterStyle ? { ...style, ...gutterStyle } : style} />+ );+ },li({ node, children, ...props }) {const listItemStart = node?.position?.start.offset;const markerOffset =diff --git a/apps/web/src/index.css b/apps/web/src/index.cssindex b2c914c0b..299506c30 100644--- a/apps/web/src/index.css+++ b/apps/web/src/index.css@@ -1630,12 +1630,22 @@ code {}.chat-markdown ul {+ /* Reset for nested uls under a widened ol — --list-gutter is an inherited+ custom property, so without this a task-list under a 3+ digit ordered+ list would inherit the outer gutter instead of its own default. */+ --list-gutter: 1.25rem;padding-left: 1.25rem;list-style-type: disc;}+/* --list-gutter defaults to the same 1.25rem as .chat-markdown ul, but+ ChatMarkdown's `ol` renderer widens it (via inline style) for lists whose+ last marker is 3+ digits, so item 100+ isn't clipped by list-style-position:+ outside painting the marker past the padding box. Reset it here too so a+ nested ol without its own widened marker doesn't inherit the outer one. */.chat-markdown ol {- padding-left: 1.25rem;+ --list-gutter: 1.25rem;+ padding-left: var(--list-gutter, 1.25rem);list-style-type: decimal;}@@ -1665,7 +1675,7 @@ code {}.chat-markdown li.task-list-item input[type="checkbox"] {- margin: 0 0.35em 0.15em -1.25rem;+ margin: 0 0.35em 0.15em calc(-1 * var(--list-gutter, 1.25rem));vertical-align: middle;}