Open-source Grok Bot alternative for named AI teammates. Local-first desktop, web, and mobile clients with per-bot tools, instructions, and memory. Independent fork of T3 Code.
fix(server): image upload crashed dispatchCommand with a stack overflow (#3952)
Theo Browneed81c156daf3
diff --git a/apps/server/src/imageMime.test.ts b/apps/server/src/imageMime.test.tsindex cc1cc2ff7..e87e4dcbd 100644--- a/apps/server/src/imageMime.test.ts+++ b/apps/server/src/imageMime.test.ts@@ -32,6 +32,63 @@ describe("imageMime", () => {});});+ it("rejects payload with characters outside the base64 alphabet", () => {+ expect(parseBase64DataUrl("data:image/png;base64,SGVs!bG8=")).toBeNull();+ expect(parseBase64DataUrl("data:image/png;base64,SGVs,bG8=")).toBeNull();+ });++ it("rejects structurally malformed base64", () => {+ // '=' before the trailing padding position+ expect(parseBase64DataUrl("data:image/png;base64,AB=CD===")).toBeNull();+ expect(parseBase64DataUrl("data:image/png;base64,SGV=bG8=")).toBeNull();+ // more than two padding characters+ expect(parseBase64DataUrl("data:image/png;base64,SGVsbG8=====AAA")).toBeNull();+ // length not a multiple of 4+ expect(parseBase64DataUrl("data:image/png;base64,SGVsbG8")).toBeNull();+ });++ it("accepts base64 with one or two trailing padding characters", () => {+ expect(parseBase64DataUrl("data:image/png;base64,SGVsbA==")).toEqual({+ mimeType: "image/png",+ base64: "SGVsbA==",+ });+ expect(parseBase64DataUrl("data:image/png;base64,SGVsbG8h")).toEqual({+ mimeType: "image/png",+ base64: "SGVsbG8h",+ });+ });++ it("rejects empty and whitespace-only payloads", () => {+ expect(parseBase64DataUrl("data:image/png;base64,")).toBeNull();+ expect(parseBase64DataUrl("data:image/png;base64, \r\n")).toBeNull();+ });++ it("parses a case-insensitive scheme and mime type", () => {+ expect(parseBase64DataUrl("DATA:IMAGE/PNG;BASE64,SGVsbG8=")).toEqual({+ mimeType: "image/png",+ base64: "SGVsbG8=",+ });+ });++ it("parses a multi-megabyte payload from a deep call stack", () => {+ // Regression: matching the payload with a regex borrowed the JS call+ // stack, so a ~10 MB image parsed inside fiber execution threw+ // "RangeError: Maximum call stack size exceeded".+ const dataUrl = `data:image/png;base64,${"A".repeat(14_000_000)}`;+ const atDepth = (depth: number): ReturnType<typeof parseBase64DataUrl> =>+ depth === 0 ? parseBase64DataUrl(dataUrl) : atDepth(depth - 1);+ const findMaxDepth = (depth: number): number => {+ try {+ return findMaxDepth(depth + 1);+ } catch {+ return depth;+ }+ };+ const result = atDepth(Math.floor(findMaxDepth(0) * 0.85));+ expect(result?.mimeType).toBe("image/png");+ expect(result?.base64.length).toBe(14_000_000);+ });+it("does not read inherited keys from mime extension map", () => {expect(inferImageExtension({ mimeType: "constructor" })).toBe(".bin");});diff --git a/apps/server/src/imageMime.ts b/apps/server/src/imageMime.tsindex c8761285a..66ce6096e 100644--- a/apps/server/src/imageMime.ts+++ b/apps/server/src/imageMime.ts@@ -29,17 +29,43 @@ export const SAFE_IMAGE_FILE_EXTENSIONS = new Set([".webp",]);+// Whether `code` is a character the base64 payload may contain, aside from+// the whitespace handled separately below.+function isBase64Char(code: number): boolean {+ return (+ (code >= 0x61 && code <= 0x7a) || // a-z+ (code >= 0x41 && code <= 0x5a) || // A-Z+ (code >= 0x30 && code <= 0x39) || // 0-9+ code === 0x2b || // ++ code === 0x2f || // /+ code === 0x3d // =+ );+}++function isBase64Whitespace(code: number): boolean {+ return code === 0x0d || code === 0x0a || code === 0x20; // \r \n space+}++// Data URLs carry the full image payload, so this parser must never run a+// regex across the payload: V8's regex engine borrows the JS call stack, and+// matching a multi-megabyte string from a deep call stack (e.g. inside fiber+// execution) throws "Maximum call stack size exceeded".export function parseBase64DataUrl(dataUrl: string,): { readonly mimeType: string; readonly base64: string } | null {- const match = /^data:([^,]+),([a-z0-9+/=\r\n ]+)$/i.exec(dataUrl.trim());- if (!match) return null;+ const trimmed = dataUrl.trim();+ if (trimmed.slice(0, 5).toLowerCase() !== "data:") return null;++ const commaIndex = trimmed.indexOf(",");+ if (commaIndex === -1) return null;+ const header = trimmed.slice(5, commaIndex);+ if (header.length === 0) return null;const headerParts: Array<string> = [];- for (const part of (match[1] ?? "").split(";")) {- const trimmed = part.trim();- if (trimmed.length > 0) {- headerParts.push(trimmed);+ for (const part of header.split(";")) {+ const partTrimmed = part.trim();+ if (partTrimmed.length > 0) {+ headerParts.push(partTrimmed);}}if (headerParts.length < 2) {@@ -51,8 +77,37 @@ export function parseBase64DataUrl(}const mimeType = headerParts[0]?.toLowerCase();- const base64 = match[2]?.replace(/\s+/g, "");- if (!mimeType || !base64) return null;+ if (!mimeType) return null;++ const payload = trimmed.slice(commaIndex + 1);+ const runs: Array<string> = [];+ let runStart = -1;+ for (let index = 0; index < payload.length; index += 1) {+ const code = payload.charCodeAt(index);+ if (isBase64Char(code)) {+ if (runStart === -1) runStart = index;+ continue;+ }+ if (!isBase64Whitespace(code)) return null;+ if (runStart !== -1) {+ runs.push(payload.slice(runStart, index));+ runStart = -1;+ }+ }+ if (runStart !== -1) {+ runs.push(payload.slice(runStart));+ }+ const base64 = runs.length === 1 ? runs[0]! : runs.join("");+ if (base64.length === 0 || base64.length % 4 !== 0) return null;+ const firstPad = base64.indexOf("=");+ if (firstPad !== -1) {+ // '=' is only valid as one or two trailing padding characters; Node's+ // decoder would otherwise silently truncate at the first '='.+ if (base64.length - firstPad > 2) return null;+ for (let index = firstPad; index < base64.length; index += 1) {+ if (base64.charCodeAt(index) !== 0x3d) return null;+ }+ }return { mimeType, base64 };}