Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.
Use Rust SRP in browser extension e2e tests (#2159)
Leendert de Borst1ab8f8ec8f6a
diff --git a/apps/browser-extension/package-lock.json b/apps/browser-extension/package-lock.jsonindex d32e7eb67..9f3099525 100644--- a/apps/browser-extension/package-lock.json+++ b/apps/browser-extension/package-lock.json@@ -26,7 +26,6 @@"react-hook-form": "^7.57.0","react-i18next": "^17.0.8","react-router-dom": "^7.18.1",- "secure-remote-password": "github:LinusU/secure-remote-password#73e5f732b6ca0cdbdc19da1a0c5f48cdbad2cbf0","sql.js": "^1.12.0","vitest": "^4.1.8","yup": "^1.6.1"@@ -2393,12 +2392,6 @@"url": "https://github.com/sponsors/ljharb"}},- "node_modules/array-buffer-to-hex": {- "version": "1.0.0",- "resolved": "https://registry.npmjs.org/array-buffer-to-hex/-/array-buffer-to-hex-1.0.0.tgz",- "integrity": "sha512-arycdkxgK1cj6s03GDb96tlCxOl1n3kg9M2OHseUc6Pqyqp+lgfceFPmG507eI5V+oxOSEnlOw/dFc7LXBXF4Q==",- "license": "MIT"- },"node_modules/array-includes": {"version": "3.1.8","resolved": "https://registry.npmjs.org/array-includes/-/array-includes-3.1.8.tgz",@@ -3268,21 +3261,6 @@"node": ">= 8"}},- "node_modules/crypto-digest-sync": {- "version": "1.0.0",- "resolved": "https://registry.npmjs.org/crypto-digest-sync/-/crypto-digest-sync-1.0.0.tgz",- "integrity": "sha512-UQBOB5z+HF4iA8shKQ3PPwhCmdFAihwcytD1Qh4uiz78x04cZZmKtZ1F1VyAjkrA8uEZqXt2tMXfj3dJHtcbng==",- "license": "MIT"- },- "node_modules/crypto-random-hex": {- "version": "1.0.0",- "resolved": "https://registry.npmjs.org/crypto-random-hex/-/crypto-random-hex-1.0.0.tgz",- "integrity": "sha512-1DuZQ03El13TRgfrqbbjW40Gvi4OKInny/Wxqj23/JMXe214C/3Tlz92bKXWDW3NZT5RjXUGdYW4qiIOUPf+cA==",- "license": "MIT",- "dependencies": {- "array-buffer-to-hex": "^1.0.0"- }- },"node_modules/css-select": {"version": "5.2.2","resolved": "https://registry.npmjs.org/css-select/-/css-select-5.2.2.tgz",@@ -3737,12 +3715,6 @@"dev": true,"license": "MIT"},- "node_modules/encode-utf8": {- "version": "1.0.3",- "resolved": "https://registry.npmjs.org/encode-utf8/-/encode-utf8-1.0.3.tgz",- "integrity": "sha512-ucAnuBEhUK4boH2HjVYG5Q2mQyPorvv0u/ocS+zhdw0S8AlHYY+GOFhP1Gio5z4icpP2ivFSvhtFjQi8+T9ppw==",- "license": "MIT"- },"node_modules/end-of-stream": {"version": "1.4.5","resolved": "https://registry.npmjs.org/end-of-stream/-/end-of-stream-1.4.5.tgz",@@ -5053,12 +5025,6 @@"node": ">= 0.4"}},- "node_modules/hex-to-array-buffer": {- "version": "1.1.0",- "resolved": "https://registry.npmjs.org/hex-to-array-buffer/-/hex-to-array-buffer-1.1.0.tgz",- "integrity": "sha512-vvl3IM8FfT1uOnHtEqyjkDK9Luqz6MQrH82qIvVnjyXxRhkeaEZyRRPiBgf2yym3nweRVEfayxt/1SoTXZYd4Q==",- "license": "MIT"- },"node_modules/hookable": {"version": "6.1.1","resolved": "https://registry.npmjs.org/hookable/-/hookable-6.1.1.tgz",@@ -5858,12 +5824,6 @@"js-yaml": "bin/js-yaml.js"}},- "node_modules/jsbn": {- "version": "1.1.0",- "resolved": "https://registry.npmjs.org/jsbn/-/jsbn-1.1.0.tgz",- "integrity": "sha512-4bYVV3aAMtDTTu4+xsDYa6sy9GyJ69/amsu9sYF2zqjiEoZA5xJi3BrfX3uY+/IekIu7MwdObdbDWpoZdBv3/A==",- "license": "MIT"- },"node_modules/jsdoc-type-pratt-parser": {"version": "4.1.0","resolved": "https://registry.npmjs.org/jsdoc-type-pratt-parser/-/jsdoc-type-pratt-parser-4.1.0.tgz",@@ -6949,12 +6909,6 @@"dev": true,"license": "BlueOak-1.0.0"},- "node_modules/pad-start": {- "version": "1.0.2",- "resolved": "https://registry.npmjs.org/pad-start/-/pad-start-1.0.2.tgz",- "integrity": "sha512-EBN8Ez1SVRcZT1XsIE4WkdnZ5coLoaChkIgAET6gIlaLhXqCz9upVk0DQWFtOYkrpTVvbEppRUnqhTiJrBdkfw==",- "license": "MIT"- },"node_modules/parent-module": {"version": "1.0.1","resolved": "https://registry.npmjs.org/parent-module/-/parent-module-1.0.1.tgz",@@ -8113,21 +8067,6 @@"dev": true,"license": "MIT"},- "node_modules/secure-remote-password": {- "version": "0.3.0",- "resolved": "git+ssh://[email protected]/LinusU/secure-remote-password.git#73e5f732b6ca0cdbdc19da1a0c5f48cdbad2cbf0",- "integrity": "sha512-UT5eya0NtNvT+R/+L4DgReCLvCJttVTl4g4oy0sQ4aiRYspyHJf/X/ZA+zB2ZrZBXe7gyNpMnhQNT9MXFNPwvA==",- "license": "MIT",- "dependencies": {- "array-buffer-to-hex": "^1.0.0",- "crypto-digest-sync": "^1.0.0",- "crypto-random-hex": "^1.0.0",- "encode-utf8": "^1.0.1",- "hex-to-array-buffer": "^1.1.0",- "jsbn": "^1.1.0",- "pad-start": "^1.0.2"- }- },"node_modules/semver": {"version": "7.8.5","resolved": "https://registry.npmjs.org/semver/-/semver-7.8.5.tgz",diff --git a/apps/browser-extension/package.json b/apps/browser-extension/package.jsonindex 2e5d34aaa..de1fe2006 100644--- a/apps/browser-extension/package.json+++ b/apps/browser-extension/package.json@@ -46,7 +46,6 @@"react-hook-form": "^7.57.0","react-i18next": "^17.0.8","react-router-dom": "^7.18.1",- "secure-remote-password": "github:LinusU/secure-remote-password#73e5f732b6ca0cdbdc19da1a0c5f48cdbad2cbf0","sql.js": "^1.12.0","vitest": "^4.1.8","yup": "^1.6.1"diff --git a/apps/browser-extension/tests/helpers/test-api.ts b/apps/browser-extension/tests/helpers/test-api.tsindex 5fe3813cd..b9276e1aa 100644--- a/apps/browser-extension/tests/helpers/test-api.ts+++ b/apps/browser-extension/tests/helpers/test-api.ts@@ -12,9 +12,8 @@ import { join } from 'path';import Database from 'better-sqlite3';import * as OTPAuth from 'otpauth';-import * as srp from 'secure-remote-password/client.js';-import { argon2DeriveKey } from '../../src/utils/dist/core/rust/aliasvault_core.js';+import { argon2DeriveKey, srpDerivePrivateKey, srpDeriveVerifier, srpGenerateSalt } from '../../src/utils/dist/core/rust/aliasvault_core.js';// Get the vault schema SQL from the core vault packageimport { COMPLETE_SCHEMA_SQL, VAULT_VERSIONS } from '../../src/utils/dist/core/vault/index.mjs';@@ -274,18 +273,18 @@ async function prepareRegistration(): Promise<{ request: RegisterRequest; salt: string; encryptionKey: Uint8Array }> {const normalizedUsername = normalizeUsername(username);- // Generate salt using SRP client- const salt = srp.generateSalt();+ ensureRustCore();- // Derive key from password using Argon2Id+ // Generate salt and derive key from password+ const salt = srpGenerateSalt();const encryptionKey = deriveKeyFromPassword(password, salt);// Convert to uppercase hex string (expected by server)const passwordHashString = bytesToHexString(encryptionKey);// Generate SRP private key and verifier- const privateKey = srp.derivePrivateKey(salt, normalizedUsername, passwordHashString);- const verifier = srp.deriveVerifier(privateKey);+ const privateKey = srpDerivePrivateKey(salt, normalizedUsername, passwordHashString);+ const verifier = srpDeriveVerifier(privateKey);return {request: {