Skip to content

Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.

Refactor and cleanup (#2159)

Leendert de Borst264c7cfb4be1
diff --git a/apps/mobile-app/android/app/build.gradle b/apps/mobile-app/android/app/build.gradle
index 8d040abfd..eb2172918 100644
--- a/apps/mobile-app/android/app/build.gradle
+++ b/apps/mobile-app/android/app/build.gradle
@@ -209,8 +209,6 @@ dependencies {
// Do NOT remove: it has no direct code reference here, so it can look unused.
implementation("androidx.exifinterface:exifinterface:1.4.2")
- // Add modern SQLite library with VACUUM INTO and backup API support
-
// Add ZXing library for QR code scanning (F-Droid compatible)
implementation("com.journeyapps:zxing-android-embedded:4.3.0")
diff --git a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/vaultstore/storageprovider/AndroidStorageProvider.kt b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/vaultstore/storageprovider/AndroidStorageProvider.kt
index dc921282c..3be5f1c91 100644
--- a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/vaultstore/storageprovider/AndroidStorageProvider.kt
+++ b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/vaultstore/storageprovider/AndroidStorageProvider.kt
@@ -14,16 +14,6 @@ class AndroidStorageProvider(private val context: Context) : StorageProvider {
return File(context.filesDir, "encrypted_database.db")
}
- /**
- * Get a random temporary file path.
- * @return The random temporary file path as a string
- */
- override fun getRandomTempFilePath(): String {
- val tempFile = File(context.cacheDir, "temp_db_${System.nanoTime()}_${java.util.UUID.randomUUID()}.sqlite")
- tempFile.deleteOnExit()
- return tempFile.absolutePath
- }
-
override fun setEncryptedDatabaseFile(encryptedData: String) {
val file = File(context.filesDir, "encrypted_database.db")
file.writeText(encryptedData)
@@ -216,10 +206,6 @@ class AndroidStorageProvider(private val context: Context) : StorageProvider {
// endregion
- override fun getCacheDir(): File {
- return context.cacheDir
- }
-
// region Sync engine state
override fun getSyncEngineState(key: String): String? {
diff --git a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/vaultstore/storageprovider/StorageProvider.kt b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/vaultstore/storageprovider/StorageProvider.kt
index 6f9faa83d..24b8ff82a 100644
--- a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/vaultstore/storageprovider/StorageProvider.kt
+++ b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/vaultstore/storageprovider/StorageProvider.kt
@@ -13,12 +13,6 @@ interface StorageProvider {
*/
fun getEncryptedDatabaseFile(): File
- /**
- * Get a random temporary file path.
- * @return The random temporary file path as a string
- */
- fun getRandomTempFilePath(): String
-
/**
* Set the encrypted database file.
* @param encryptedData The encrypted database data as a base64 encoded string
@@ -181,12 +175,6 @@ interface StorageProvider {
// endregion
- /**
- * Get the cache directory for temporary files.
- * @return The cache directory
- */
- fun getCacheDir(): File
-
// region Sync engine state
/**
diff --git a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/vaultstore/storageprovider/TestStorageProvider.kt b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/vaultstore/storageprovider/TestStorageProvider.kt
index ac4b28b0f..2f6e319c8 100644
--- a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/vaultstore/storageprovider/TestStorageProvider.kt
+++ b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/vaultstore/storageprovider/TestStorageProvider.kt
@@ -27,12 +27,6 @@ class TestStorageProvider : StorageProvider {
tempFile.writeText(encryptedData)
}
- override fun getRandomTempFilePath(): String {
- val tempFile = File.createTempFile("temp_db", ".sqlite")
- tempFile.deleteOnExit()
- return tempFile.absolutePath
- }
-
override fun setMetadata(metadata: String) {
tempMetadata = metadata
}
@@ -148,10 +142,6 @@ class TestStorageProvider : StorageProvider {
// endregion
- override fun getCacheDir(): File {
- return File(System.getProperty("java.io.tmpdir") ?: "/tmp")
- }
-
// region Sync engine state
private val syncEngineState = mutableMapOf<String, String>()
diff --git a/apps/mobile-app/i18n/locales/en.json b/apps/mobile-app/i18n/locales/en.json
index 99f04ba96..8888bfb9f 100644
--- a/apps/mobile-app/i18n/locales/en.json
+++ b/apps/mobile-app/i18n/locales/en.json
@@ -713,7 +713,6 @@
"noDescriptionAvailable": "No description available for this version.",
"status": {
"preparingUpgrade": "Preparing upgrade...",
- "vaultAlreadyUpToDate": "Vault is already up to date",
"applyingDatabaseMigrations": "Applying database migrations...",
"applyingMigration": "Applying migration {{current}} of {{total}}...",
"committingChanges": "Committing changes..."
diff --git a/core/rust/build.sh b/core/rust/build.sh
index ccf6a05bc..1e9a70012 100755
--- a/core/rust/build.sh
+++ b/core/rust/build.sh
@@ -177,7 +177,7 @@ build_browser() {
fi
echo ""
- echo -e "${BLUE}Building WASM for browser extension...${NC}"
+ echo -e "${BLUE}Building WASM for $BROWSER_TARGET (${profile_args[*]})...${NC}"
local start_time=$(date +%s)