Skip to content

Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.

Refactor Actions to move Rust setup to build core libraries action (#2413)

Leendert de Borst37dbc012a15a
diff --git a/.github/actions/build-android-app/action.yml b/.github/actions/build-android-app/action.yml
index bdf0504f2..5f19fda5f 100644
--- a/.github/actions/build-android-app/action.yml
+++ b/.github/actions/build-android-app/action.yml
@@ -25,11 +25,9 @@ runs:
cache-dependency-path: apps/mobile-app/package-lock.json
- name: Build core libraries
- shell: bash
- run: |
- cd ./core
- chmod +x build-and-distribute.sh
- ./build-and-distribute.sh
+ uses: ./.github/actions/build-core-libraries
+ with:
+ target: android
- name: Verify core library distribution
shell: bash
diff --git a/.github/actions/build-browser-extension/action.yml b/.github/actions/build-browser-extension/action.yml
index b5712c098..f2c2963ac 100644
--- a/.github/actions/build-browser-extension/action.yml
+++ b/.github/actions/build-browser-extension/action.yml
@@ -19,40 +19,10 @@ runs:
cache: 'npm'
cache-dependency-path: apps/browser-extension/package-lock.json
- - name: Setup Rust toolchain
- uses: dtolnay/rust-toolchain@stable
- with:
- targets: wasm32-unknown-unknown
-
- - name: Cache Rust dependencies
- uses: Swatinem/rust-cache@v2
- with:
- workspaces: core/rust
-
- - name: Install wasm-pack
- shell: bash
- run: cargo install wasm-pack --locked
-
- - name: Install clang (compiles SQLite for wasm32)
- shell: bash
- run: sudo apt-get update && sudo apt-get install -y clang
-
- name: Build core libraries
- shell: bash
- run: |
- cd ./core
- chmod +x build-and-distribute.sh
- ./build-and-distribute.sh --browser-extension
-
- - name: Verify core library distribution
- shell: bash
- run: |
- # Verify critical rust WASM files exist
- if [ ! -f "core/client/wasm/aliasvault_core_bg.wasm" ]; then
- echo "Error: Rust WASM files not found in browser extension"
- exit 1
- fi
- echo "Core library distribution verified"
+ uses: ./.github/actions/build-core-libraries
+ with:
+ target: browser-extension
- name: Install dependencies
run: npm ci
diff --git a/.github/actions/build-core-libraries/action.yml b/.github/actions/build-core-libraries/action.yml
index cec60a9c3..733a7cf86 100644
--- a/.github/actions/build-core-libraries/action.yml
+++ b/.github/actions/build-core-libraries/action.yml
@@ -1,10 +1,13 @@
name: "Build Core Libraries"
-description: "Builds and distributes all core libraries including TypeScript packages and Rust WASM"
+description: "Sets up Node.js and the Rust toolchain for one platform, then builds and distributes the core libraries for it"
inputs:
- working-directory:
- description: "Working directory (default: repository root)"
+ target:
+ description: "Platform to build the Rust core for: web, browser-extension, android or ios"
+ required: true
+ check-generated:
+ description: "Fail when the build changes committed generated files (models, registry), meaning a source edit was committed without running the generators"
required: false
- default: "."
+ default: "false"
runs:
using: "composite"
@@ -14,30 +17,51 @@ runs:
with:
node-version: '24'
+ - name: Resolve Rust targets
+ id: resolve
+ shell: bash
+ env:
+ TARGET: ${{ inputs.target }}
+ run: |
+ case "$TARGET" in
+ web|browser-extension) echo "rust-targets=wasm32-unknown-unknown" >> "$GITHUB_OUTPUT"; echo "wasm=true" >> "$GITHUB_OUTPUT" ;;
+ android) echo "rust-targets=aarch64-linux-android,armv7-linux-androideabi,x86_64-linux-android,i686-linux-android" >> "$GITHUB_OUTPUT" ;;
+ ios) echo "rust-targets=aarch64-apple-ios,aarch64-apple-ios-sim,x86_64-apple-ios" >> "$GITHUB_OUTPUT" ;;
+ *) echo "::error::Unknown target '$TARGET', expected web, browser-extension, android or ios"; exit 1 ;;
+ esac
+
- name: Setup Rust toolchain
uses: dtolnay/rust-toolchain@stable
with:
- targets: wasm32-unknown-unknown
+ targets: ${{ steps.resolve.outputs.rust-targets }}
+
+ - name: Cache Rust dependencies
+ uses: Swatinem/rust-cache@v2
+ with:
+ workspaces: core/rust
- name: Install wasm-pack
+ if: steps.resolve.outputs.wasm == 'true'
shell: bash
- run: cargo install wasm-pack --locked
+ run: command -v wasm-pack || cargo install wasm-pack --locked
- name: Install clang (compiles SQLite for wasm32)
+ if: steps.resolve.outputs.wasm == 'true' && runner.os == 'Linux'
shell: bash
run: sudo apt-get update && sudo apt-get install -y clang
- name: Build and distribute core libraries
shell: bash
- working-directory: ${{ inputs.working-directory }}
+ working-directory: core
+ env:
+ TARGET: ${{ inputs.target }}
run: |
- cd ./core
chmod +x build-and-distribute.sh
- ./build-and-distribute.sh
+ ./build-and-distribute.sh "--$TARGET"
- name: Fail on stale generated files
+ if: inputs.check-generated == 'true'
shell: bash
- working-directory: ${{ inputs.working-directory }}
run: |
# The build above which (re)builds both Git committed files as well as non-committed files, should not result in any changes to the files listed below.
# If there are Git changes, it means a source edit was committed without running the generators which could lead to inconsistencies.
@@ -60,13 +84,11 @@ runs:
echo "Generated files are in sync with their sources."
- name: Verify core library distribution
+ if: steps.resolve.outputs.wasm == 'true'
shell: bash
- working-directory: ${{ inputs.working-directory }}
run: |
- # Verify critical rust WASM files exist
if [ ! -f "core/client/wasm/aliasvault_core_bg.wasm" ]; then
echo "Error: Rust WASM files not found in core/client/wasm"
exit 1
fi
-
echo "Core library distribution verified"
diff --git a/.github/actions/build-ios-app/action.yml b/.github/actions/build-ios-app/action.yml
index d55ff59ff..50d210482 100644
--- a/.github/actions/build-ios-app/action.yml
+++ b/.github/actions/build-ios-app/action.yml
@@ -25,11 +25,9 @@ runs:
cache-dependency-path: apps/mobile-app/package-lock.json
- name: Build core libraries
- shell: bash
- run: |
- cd ./core
- chmod +x build-and-distribute.sh
- ./build-and-distribute.sh
+ uses: ./.github/actions/build-core-libraries
+ with:
+ target: ios
- name: Install dependencies
run: npm ci
diff --git a/.github/workflows/browser-extension-build.yml b/.github/workflows/browser-extension-build.yml
index bcdebdc61..bae7415e0 100644
--- a/.github/workflows/browser-extension-build.yml
+++ b/.github/workflows/browser-extension-build.yml
@@ -31,6 +31,9 @@ jobs:
- name: Build Core Libraries
uses: ./.github/actions/build-core-libraries
+ with:
+ target: browser-extension
+ check-generated: "true"
build-chrome-extension:
needs: build-core-libraries
diff --git a/.github/workflows/e2e-tests-android.yml b/.github/workflows/e2e-tests-android.yml
index ee7ebac15..8c929ddc0 100644
--- a/.github/workflows/e2e-tests-android.yml
+++ b/.github/workflows/e2e-tests-android.yml
@@ -8,6 +8,7 @@ on:
- 'apps/mobile-app/**'
- 'core/**'
- '.github/workflows/e2e-tests-android.yml'
+ - '.github/actions/build-core-libraries/**'
- '.github/actions/start-api-server/**'
pull_request:
branches: [ "main" ]
@@ -15,6 +16,7 @@ on:
- 'apps/mobile-app/**'
- 'core/**'
- '.github/workflows/e2e-tests-android.yml'
+ - '.github/actions/build-core-libraries/**'
- '.github/actions/start-api-server/**'
workflow_dispatch:
@@ -59,16 +61,6 @@ jobs:
cache: 'npm'
cache-dependency-path: apps/mobile-app/package-lock.json
- - name: Setup Rust toolchain
- uses: dtolnay/rust-toolchain@stable
- with:
- targets: aarch64-linux-android,armv7-linux-androideabi,x86_64-linux-android,i686-linux-android
-
- - name: Cache Rust dependencies
- uses: Swatinem/rust-cache@v2
- with:
- workspaces: core/rust
-
- name: Setup Android SDK
uses: android-actions/setup-android@v4
with:
@@ -80,11 +72,10 @@ jobs:
- name: Install Android NDK
run: sdkmanager --install "ndk;26.1.10909125"
- - name: Build core libraries for Android
- run: |
- cd ../../core
- chmod +x build-and-distribute.sh
- ./build-and-distribute.sh --android
+ - name: Build core libraries
+ uses: ./.github/actions/build-core-libraries
+ with:
+ target: android
- name: Install mobile app dependencies
run: npm ci
diff --git a/.github/workflows/e2e-tests-browser-extension.yml b/.github/workflows/e2e-tests-browser-extension.yml
index 02672edc0..79db6fea6 100644
--- a/.github/workflows/e2e-tests-browser-extension.yml
+++ b/.github/workflows/e2e-tests-browser-extension.yml
@@ -8,6 +8,7 @@ on:
- 'apps/browser-extension/**'
- 'core/**'
- '.github/workflows/e2e-tests-browser-extension.yml'
+ - '.github/actions/build-core-libraries/**'
- '.github/actions/start-api-server/**'
pull_request:
branches: [ "main" ]
@@ -15,6 +16,7 @@ on:
- 'apps/browser-extension/**'
- 'core/**'
- '.github/workflows/e2e-tests-browser-extension.yml'
+ - '.github/actions/build-core-libraries/**'
- '.github/actions/start-api-server/**'
workflow_dispatch:
@@ -39,27 +41,10 @@ jobs:
with:
node-version: '24'
- - name: Setup Rust toolchain
- uses: dtolnay/rust-toolchain@stable
- with:
- targets: wasm32-unknown-unknown
-
- - name: Cache Rust dependencies
- uses: Swatinem/rust-cache@v2
- with:
- workspaces: core/rust
-
- - name: Install wasm-pack
- run: cargo install wasm-pack --locked
-
- - name: Install clang (compiles SQLite for wasm32)
- run: sudo apt-get update && sudo apt-get install -y clang
-
- name: Build core libraries
- run: |
- cd ./core
- chmod +x build-and-distribute.sh
- ./build-and-distribute.sh --browser-extension
+ uses: ./.github/actions/build-core-libraries
+ with:
+ target: browser-extension
- name: Install .NET dependencies
working-directory: apps/server
@@ -109,27 +94,10 @@ jobs:
cache: 'npm'
cache-dependency-path: apps/browser-extension/package-lock.json
- - name: Setup Rust toolchain
- uses: dtolnay/rust-toolchain@stable
- with:
- targets: wasm32-unknown-unknown
-
- - name: Cache Rust dependencies
- uses: Swatinem/rust-cache@v2
- with:
- workspaces: core/rust
-
- - name: Install wasm-pack
- run: cargo install wasm-pack --locked
-
- - name: Install clang (compiles SQLite for wasm32)
- run: sudo apt-get update && sudo apt-get install -y clang
-
- name: Build core libraries
- run: |
- cd ./core
- chmod +x build-and-distribute.sh
- ./build-and-distribute.sh --browser-extension
+ uses: ./.github/actions/build-core-libraries
+ with:
+ target: browser-extension
- name: Start dev database
run: ./scripts/dev.sh db-start
diff --git a/.github/workflows/e2e-tests-ios.yml b/.github/workflows/e2e-tests-ios.yml
index 7e3bbe419..500d480d4 100644
--- a/.github/workflows/e2e-tests-ios.yml
+++ b/.github/workflows/e2e-tests-ios.yml
@@ -8,6 +8,7 @@ on:
- 'apps/mobile-app/**'
- 'core/**'
- '.github/workflows/e2e-tests-ios.yml'
+ - '.github/actions/build-core-libraries/**'
- '.github/actions/start-api-server/**'
pull_request:
branches: [ "main" ]
@@ -15,6 +16,7 @@ on:
- 'apps/mobile-app/**'
- 'core/**'
- '.github/workflows/e2e-tests-ios.yml'
+ - '.github/actions/build-core-libraries/**'
- '.github/actions/start-api-server/**'
workflow_dispatch:
@@ -47,16 +49,6 @@ jobs:
cache: 'npm'
cache-dependency-path: apps/mobile-app/package-lock.json
- - name: Setup Rust toolchain
- uses: dtolnay/rust-toolchain@stable
- with:
- targets: aarch64-apple-ios,aarch64-apple-ios-sim,x86_64-apple-ios
-
- - name: Cache Rust dependencies
- uses: Swatinem/rust-cache@v2
- with:
- workspaces: core/rust
-
- name: Setup Ruby
uses: ruby/setup-ruby@v1
with:
@@ -66,11 +58,10 @@ jobs:
- name: Install CocoaPods
run: sudo gem install cocoapods
- - name: Build core libraries for iOS
- run: |
- cd ../../core
- chmod +x build-and-distribute.sh
- ./build-and-distribute.sh --ios
+ - name: Build core libraries
+ uses: ./.github/actions/build-core-libraries
+ with:
+ target: ios
- name: Install mobile app dependencies
run: npm ci
diff --git a/.github/workflows/e2e-tests-server.yml b/.github/workflows/e2e-tests-server.yml
index 28bcf716e..7857099df 100644
--- a/.github/workflows/e2e-tests-server.yml
+++ b/.github/workflows/e2e-tests-server.yml
@@ -9,6 +9,7 @@ on:
- 'core/**'
- 'install.sh'
- '.github/workflows/e2e-tests-server.yml'
+ - '.github/actions/build-core-libraries/**'
pull_request:
branches: [ "main" ]
paths:
@@ -16,6 +17,7 @@ on:
- 'core/**'
- 'install.sh'
- '.github/workflows/e2e-tests-server.yml'
+ - '.github/actions/build-core-libraries/**'
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
@@ -77,32 +79,10 @@ jobs:
with:
dotnet-version: 10.0.x
- - name: Setup Node.js
- uses: actions/setup-node@v6
- with:
- node-version: '24'
-
- - name: Setup Rust toolchain
- uses: dtolnay/rust-toolchain@stable
- with:
- targets: wasm32-unknown-unknown
-
- - name: Cache Rust dependencies
- uses: Swatinem/rust-cache@v2
- with:
- workspaces: core/rust
-
- - name: Install wasm-pack
- run: cargo install wasm-pack --locked
-
- - name: Install clang (compiles SQLite for wasm32)
- run: sudo apt-get update && sudo apt-get install -y clang
-
- name: Build core libraries
- run: |
- cd ./core
- chmod +x build-and-distribute.sh
- ./build-and-distribute.sh --web
+ uses: ./.github/actions/build-core-libraries
+ with:
+ target: web
- name: Install dependencies
working-directory: apps/server
diff --git a/.github/workflows/e2e-tests-web.yml b/.github/workflows/e2e-tests-web.yml
index 409a9ce0a..cae2482f2 100644
--- a/.github/workflows/e2e-tests-web.yml
+++ b/.github/workflows/e2e-tests-web.yml
@@ -9,6 +9,7 @@ on:
- 'apps/server/AliasVault.Api/**'
- 'core/**'
- '.github/workflows/e2e-tests-web.yml'
+ - '.github/actions/build-core-libraries/**'
- '.github/actions/start-api-server/**'
pull_request:
branches: [ "main" ]
@@ -17,6 +18,7 @@ on:
- 'apps/server/AliasVault.Api/**'
- 'core/**'
- '.github/workflows/e2e-tests-web.yml'
+ - '.github/actions/build-core-libraries/**'
- '.github/actions/start-api-server/**'
workflow_dispatch:
@@ -38,27 +40,10 @@ jobs:
cache: 'npm'
cache-dependency-path: apps/web/package-lock.json
- - name: Setup Rust toolchain
- uses: dtolnay/rust-toolchain@stable
- with:
- targets: wasm32-unknown-unknown
-
- - name: Cache Rust dependencies
- uses: Swatinem/rust-cache@v2
- with:
- workspaces: core/rust
-
- - name: Install wasm-pack
- run: cargo install wasm-pack --locked
-
- - name: Install clang (compiles SQLite for wasm32)
- run: sudo apt-get update && sudo apt-get install -y clang
-
- name: Build core libraries
- run: |
- cd ./core
- chmod +x build-and-distribute.sh
- ./build-and-distribute.sh --web
+ uses: ./.github/actions/build-core-libraries
+ with:
+ target: web
- name: Start dev database
run: ./scripts/dev.sh db-start
diff --git a/.github/workflows/mobile-app-build.yml b/.github/workflows/mobile-app-build.yml
index 9c4ee81c1..8fb1719c8 100644
--- a/.github/workflows/mobile-app-build.yml
+++ b/.github/workflows/mobile-app-build.yml
@@ -7,6 +7,7 @@ on:
- 'apps/mobile-app/**'
- 'core/**'
- '.github/workflows/mobile-app-build.yml'
+ - '.github/actions/build-core-libraries/**'
- '.github/actions/build-android-app/**'
- '.github/actions/build-ios-app/**'
pull_request:
@@ -15,6 +16,7 @@ on:
- 'apps/mobile-app/**'
- 'core/**'
- '.github/workflows/mobile-app-build.yml'
+ - '.github/actions/build-core-libraries/**'
- '.github/actions/build-android-app/**'
- '.github/actions/build-ios-app/**'
workflow_dispatch:
@@ -55,11 +57,10 @@ jobs:
cache: 'npm'
cache-dependency-path: apps/mobile-app/package-lock.json
- - name: Build and distribute core libraries
- run: |
- cd ../../core
- chmod +x build-and-distribute.sh
- ./build-and-distribute.sh --android
+ - name: Build core libraries
+ uses: ./.github/actions/build-core-libraries
+ with:
+ target: android
- name: Install dependencies
run: npm ci
@@ -84,10 +85,9 @@ jobs:
cache-dependency-path: apps/mobile-app/package-lock.json
- name: Build core libraries
- run: |
- cd ../../core
- chmod +x build-and-distribute.sh
- ./build-and-distribute.sh --android
+ uses: ./.github/actions/build-core-libraries
+ with:
+ target: android
- name: Install dependencies
run: npm ci