Skip to content

Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.

Return empty list on error (#2159)

Leendert de Borst398b382cf023
diff --git a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/autofill/utils/RustItemMatcher.kt b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/autofill/utils/RustItemMatcher.kt
index d992b8ce7..aaf33983c 100644
--- a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/autofill/utils/RustItemMatcher.kt
+++ b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/autofill/utils/RustItemMatcher.kt
@@ -101,8 +101,7 @@ object RustItemMatcher {
return filtered
} catch (e: Exception) {
Log.e(TAG, "Error filtering items with Rust matcher: ${e.message}", e)
- // Fallback to returning all items on error
- return items
+ return emptyList()
}
}
diff --git a/apps/mobile-app/ios/VaultUI/Selection/Utils/RustItemMatcher.swift b/apps/mobile-app/ios/VaultUI/Selection/Utils/RustItemMatcher.swift
index 80cabfe29..9a4894311 100644
--- a/apps/mobile-app/ios/VaultUI/Selection/Utils/RustItemMatcher.swift
+++ b/apps/mobile-app/ios/VaultUI/Selection/Utils/RustItemMatcher.swift
@@ -39,7 +39,7 @@ public class RustItemMatcher {
let inputData = try JSONSerialization.data(withJSONObject: input, options: [])
guard let inputJson = String(data: inputData, encoding: .utf8) else {
print("[RustItemMatcher] Failed to create input JSON")
- return credentials
+ return []
}
// Call Rust via UniFFI
@@ -50,7 +50,7 @@ public class RustItemMatcher {
let output = try JSONSerialization.jsonObject(with: outputData) as? [String: Any],
let matchedIds = output["matched_ids"] as? [String] else {
print("[RustItemMatcher] Failed to parse output JSON")
- return credentials
+ return []
}
// If no matches found, return empty array
@@ -70,8 +70,7 @@ public class RustItemMatcher {
} catch {
print("[RustItemMatcher] Error filtering credentials: \(error)")
- // Fallback to returning all credentials on error
- return credentials
+ return []
}
}
}