Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.
Add RPO recovery test to browser extension (#1404)
Leendert de Borst447bea3a3ed8
diff --git a/apps/browser-extension/src/entrypoints/popup/components/ReloadButton.tsx b/apps/browser-extension/src/entrypoints/popup/components/ReloadButton.tsxindex 86c90ecb2..ae7192a35 100644--- a/apps/browser-extension/src/entrypoints/popup/components/ReloadButton.tsx+++ b/apps/browser-extension/src/entrypoints/popup/components/ReloadButton.tsx@@ -16,7 +16,7 @@ const ReloadButton: React.FC<ReloadButtonProps> = ({ onClick }) => {className="px-2 items-center"><div className="relative inline-flex items-center">- <button onClick={onClick} className="absolute p-2 hover:bg-gray-200 rounded-2xl">+ <button id="reload-vault" onClick={onClick} className="absolute p-2 hover:bg-gray-200 rounded-2xl"><svg xmlns="http://www.w3.org/2000/svg" className="h-4 w-4 text-gray-400" viewBox="0 0 20 20" fill="currentColor"><path fillRule="evenodd" d="M4 2a1 1 0 011 1v2.101a7.002 7.002 0 0111.601 2.566 1 1 0 11-1.885.666A5.002 5.002 0 005.999 7H9a1 1 0 010 2H4a1 1 0 01-1-1V3a1 1 0 011-1zm.008 9.057a1 1 0 011.276.61A5.002 5.002 0 0014.001 13H11a1 1 0 110-2h5a1 1 0 011 1v5a1 1 0 11-2 0v-2.101a7.002 7.002 0 01-11.601-2.566 1 1 0 01.61-1.276z" clipRule="evenodd" /></svg>diff --git a/apps/server/Tests/AliasVault.E2ETests/Common/BrowserExtensionPlaywrightTest.cs b/apps/server/Tests/AliasVault.E2ETests/Common/BrowserExtensionPlaywrightTest.csindex 49dc43add..cfbc10b87 100644--- a/apps/server/Tests/AliasVault.E2ETests/Common/BrowserExtensionPlaywrightTest.cs+++ b/apps/server/Tests/AliasVault.E2ETests/Common/BrowserExtensionPlaywrightTest.cs@@ -108,17 +108,50 @@ public class BrowserExtensionPlaywrightTest : ClientPlaywrightTest// Wait for login to complete by waiting for expected text.if (waitForLogin){- // Wait for bottom navigation to appear (indicates login completed)- await extensionPopup.WaitForSelectorAsync("text=Vault");+ // Wait for "Items" heading to appear (indicates vault loaded)+ // This appears for both empty and non-empty vaults+ await extensionPopup.WaitForSelectorAsync("text=Items", new() { Timeout = 15000 });- // Also wait for the items list container to be visible,- // indicating the vault has loaded and rendered- await extensionPopup.WaitForSelectorAsync("#items-list", new() { Timeout = 15000 });+ // Wait a bit for vault to fully initialize+ await Task.Delay(500);}return extensionPopup;}+ /// <summary>+ /// Create a new credential in the browser extension.+ /// </summary>+ /// <param name="extensionPopup">The extension popup page.</param>+ /// <param name="serviceName">The name of the credential to create.</param>+ /// <returns>Async task.</returns>+ protected async Task CreateCredentialInExtension(IPage extensionPopup, string serviceName)+ {+ // Click add new item button+ await extensionPopup.ClickAsync("button[title='Add new item']");++ // Wait for the item name field to be visible+ await extensionPopup.WaitForSelectorAsync("input#itemName");++ // Fill in the credential name+ await extensionPopup.FillAsync("input#itemName", serviceName);++ // Save the credential+ await extensionPopup.ClickAsync("button#save-credential");++ // After save, we're on the item detail page - wait for it to load+ await extensionPopup.WaitForSelectorAsync("button[title='Edit Item']", new() { Timeout = 5000 });++ // Navigate back to the vault list+ await extensionPopup.ClickAsync("#nav-vault");++ // Wait for the credential to appear in the list+ await extensionPopup.WaitForSelectorAsync($"text={serviceName}", new() { Timeout = 10000 });++ // Wait a bit for sync to complete+ await Task.Delay(500);+ }+/// <summary>/// Find the repository root directory by walking up from the current assembly location./// </summary>diff --git a/apps/server/Tests/AliasVault.E2ETests/Tests/Extensions/ChromeExtensionTests.cs b/apps/server/Tests/AliasVault.E2ETests/Tests/Extensions/ChromeExtensionTests.csindex b670a265f..38f363846 100644--- a/apps/server/Tests/AliasVault.E2ETests/Tests/Extensions/ChromeExtensionTests.cs+++ b/apps/server/Tests/AliasVault.E2ETests/Tests/Extensions/ChromeExtensionTests.cs@@ -7,6 +7,8 @@namespace AliasVault.E2ETests.Tests.Extensions;+using Microsoft.EntityFrameworkCore;+/// <summary>/// End-to-end tests for the Chrome extension./// </summary>@@ -38,6 +40,115 @@ public class ChromeExtensionTests : BrowserExtensionPlaywrightTestAssert.That(pageContent, Does.Contain(serviceName));}+ /// <summary>+ /// Tests server RPO (Recovery Point Objective) recovery scenario.+ /// This test verifies that when server data loss occurs (server rolls back to an earlier revision),+ /// the browser extension client can recover by uploading its more advanced vault to the server.+ /// </summary>+ /// <returns>Async task.</returns>+ [Order(2)]+ [Test]+ public async Task ExtensionHandlesServerRpoRollbackScenario()+ {+ // Login to the browser extension+ var extensionPopup = await LoginToExtension();++ // Create 3 credentials, each creating a new vault revision on the server+ var serviceName1 = "Test Service RPO 1";+ var serviceName2 = "Test Service RPO 2";+ var serviceName3 = "Test Service RPO 3";++ // Create credentials using helper method+ await CreateCredentialInExtension(extensionPopup, serviceName1);+ await CreateCredentialInExtension(extensionPopup, serviceName2);+ await CreateCredentialInExtension(extensionPopup, serviceName3);++ // Verify all three services appear in the extension+ var extensionContent = await extensionPopup.TextContentAsync("body");+ Assert.Multiple(() =>+ {+ Assert.That(extensionContent, Does.Contain(serviceName1), "First credential should appear");+ Assert.That(extensionContent, Does.Contain(serviceName2), "Second credential should appear");+ Assert.That(extensionContent, Does.Contain(serviceName3), "Third credential should appear");+ });++ // Get the current vault revision from the database (should be 3)+ var vaultBeforeRollback = await ApiDbContext.Vaults+ .OrderByDescending(v => v.RevisionNumber)+ .FirstOrDefaultAsync();++ Assert.That(vaultBeforeRollback, Is.Not.Null, "Vault should exist in database");+ var revisionBeforeRollback = vaultBeforeRollback!.RevisionNumber;++ Console.WriteLine($"Vault revision before rollback: {revisionBeforeRollback}");+ Assert.That(revisionBeforeRollback, Is.GreaterThanOrEqualTo(3), "Should have at least 3 revisions");++ // SIMULATE SERVER DATA LOSS: Delete the last 2 vault revisions from the server database+ var revisionsToDelete = await ApiDbContext.Vaults+ .Where(v => v.RevisionNumber > revisionBeforeRollback - 2)+ .OrderByDescending(v => v.RevisionNumber)+ .Take(2)+ .ToListAsync();++ foreach (var revision in revisionsToDelete)+ {+ Console.WriteLine($"Deleting vault revision: {revision.RevisionNumber}");+ ApiDbContext.Vaults.Remove(revision);+ }++ await ApiDbContext.SaveChangesAsync();++ // Verify the server now has a lower revision+ var vaultAfterRollback = await ApiDbContext.Vaults+ .OrderByDescending(v => v.RevisionNumber)+ .FirstOrDefaultAsync();++ Assert.That(vaultAfterRollback, Is.Not.Null, "Vault should still exist after rollback");+ var revisionAfterRollback = vaultAfterRollback!.RevisionNumber;++ Console.WriteLine($"Vault revision after rollback: {revisionAfterRollback}");+ Assert.That(revisionAfterRollback, Is.LessThan(revisionBeforeRollback), "Server revision should be lower after rollback");++ // Now trigger a sync in the browser extension by clicking the reload button+ // This should trigger the sync logic that detects server rollback+ await extensionPopup.ClickAsync("button#reload-vault");++ // Wait for sync to complete+ await Task.Delay(2000);++ // Verify the server now has the recovered vault with a new revision number+ var vaultAfterRecovery = await ApiDbContext.Vaults+ .OrderByDescending(v => v.RevisionNumber)+ .FirstOrDefaultAsync();++ Assert.That(vaultAfterRecovery, Is.Not.Null, "Vault should exist after recovery");+ var revisionAfterRecovery = vaultAfterRecovery!.RevisionNumber;++ Console.WriteLine($"Vault revision after recovery: {revisionAfterRecovery}");++ // The revision number should have jumped (creating a gap) because client uploaded with its old revision number+ // Server assigns newRevision = clientRevision + 1, so if client had rev 100 and server had 95,+ // server will create rev 101 (gap: 96-100)+ Assert.That(revisionAfterRecovery, Is.GreaterThan(revisionAfterRollback), "Server should have higher revision after recovery");++ // Verify the gap exists (revision after recovery should equal or exceed the original revision before rollback)+ Assert.That(revisionAfterRecovery, Is.GreaterThanOrEqualTo(revisionBeforeRollback), "Server should have recovered to at least the pre-rollback revision (gap indicates RPO recovery)");++ // Verify all three credentials are still present in the extension after recovery+ await extensionPopup.ClickAsync("#nav-vault");+ await Task.Delay(500);++ var contentAfterRecovery = await extensionPopup.TextContentAsync("body");+ Assert.Multiple(() =>+ {+ Assert.That(contentAfterRecovery, Does.Contain(serviceName1), "First credential should still appear after recovery");+ Assert.That(contentAfterRecovery, Does.Contain(serviceName2), "Second credential should still appear after recovery");+ Assert.That(contentAfterRecovery, Does.Contain(serviceName3), "Third credential should still appear after recovery");+ });++ Console.WriteLine($"✅ RPO recovery test passed! Server recovered from revision {revisionAfterRollback} to {revisionAfterRecovery} (gap indicates disaster recovery)");+ }+/// <summary>/// Gets the extension ID from the browser context using reflection./// This is a helper method for tests that need to open the extension popup manually.