Skip to content

Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.

Add password strength indicator to change password screen (#773)

Leendert de Borst493446ed174e
diff --git a/apps/server/AliasVault.Admin/Main/Pages/Account/Manage/ChangePassword.razor b/apps/server/AliasVault.Admin/Main/Pages/Account/Manage/ChangePassword.razor
index 11ac83cfe..8352add53 100644
--- a/apps/server/AliasVault.Admin/Main/Pages/Account/Manage/ChangePassword.razor
+++ b/apps/server/AliasVault.Admin/Main/Pages/Account/Manage/ChangePassword.razor
@@ -19,16 +19,18 @@
</div>
<div>
<label for="new-password" class="block mb-2 text-sm font-medium text-gray-700 dark:text-gray-200">New password</label>
- <InputText type="password" @bind-Value="Input.NewPassword" id="new-password" class="w-full px-3 py-2 border border-gray-300 rounded-md shadow-sm focus:outline-none focus:ring-primary-500 focus:border-primary-500 sm:text-sm dark:bg-gray-700 dark:border-gray-600 dark:placeholder-gray-400 dark:text-white" autocomplete="new-password" aria-required="true" placeholder="Please enter your new password."/>
+ <input type="password" @bind="Input.NewPassword" @oninput="OnPasswordInput" id="new-password" class="w-full px-3 py-2 border border-gray-300 rounded-md shadow-sm focus:outline-none focus:ring-primary-500 focus:border-primary-500 sm:text-sm dark:bg-gray-700 dark:border-gray-600 dark:placeholder-gray-400 dark:text-white" autocomplete="new-password" aria-required="true" placeholder="Please enter your new password."/>
<ValidationMessage For="() => Input.NewPassword" class="mt-1 text-sm text-red-600 dark:text-red-400"/>
</div>
<div>
<label for="confirm-password" class="block mb-2 text-sm font-medium text-gray-700 dark:text-gray-200">Confirm password</label>
- <InputText type="password" @bind-Value="Input.ConfirmPassword" id="confirm-password" class="w-full px-3 py-2 border border-gray-300 rounded-md shadow-sm focus:outline-none focus:ring-primary-500 focus:border-primary-500 sm:text-sm dark:bg-gray-700 dark:border-gray-600 dark:placeholder-gray-400 dark:text-white" autocomplete="new-password" aria-required="true" placeholder="Please confirm your new password."/>
+ <input type="password" @bind="Input.ConfirmPassword" @oninput="OnConfirmPasswordInput" id="confirm-password" class="w-full px-3 py-2 border border-gray-300 rounded-md shadow-sm focus:outline-none focus:ring-primary-500 focus:border-primary-500 sm:text-sm dark:bg-gray-700 dark:border-gray-600 dark:placeholder-gray-400 dark:text-white" autocomplete="new-password" aria-required="true" placeholder="Please confirm your new password."/>
<ValidationMessage For="() => Input.ConfirmPassword" class="mt-1 text-sm text-red-600 dark:text-red-400"/>
</div>
<div>
- <SubmitButton>Update password</SubmitButton>
+ <button type="submit" disabled="@(!IsSubmitEnabled)" class="w-full px-4 py-2 text-white bg-primary-600 hover:bg-primary-700 rounded-lg focus:outline-none focus:ring-2 focus:ring-primary-500 focus:ring-offset-2 transition duration-150 ease-in-out @(IsSubmitEnabled ? "" : "opacity-50 cursor-not-allowed")">
+ Update password
+ </button>
</div>
</EditForm>
</div>
@@ -38,6 +40,34 @@
[SupplyParameterFromForm] private InputModel Input { get; set; } = default!;
+ /// <summary>
+ /// Gets a value indicating whether the submit button should be enabled.
+ /// </summary>
+ private bool IsSubmitEnabled =>
+ !string.IsNullOrWhiteSpace(Input.OldPassword) &&
+ !string.IsNullOrWhiteSpace(Input.NewPassword) &&
+ !string.IsNullOrWhiteSpace(Input.ConfirmPassword) &&
+ Input.NewPassword == Input.ConfirmPassword &&
+ Input.NewPassword.Length >= 10;
+
+ /// <summary>
+ /// Handles password input to update state.
+ /// </summary>
+ private void OnPasswordInput(ChangeEventArgs e)
+ {
+ Input.NewPassword = e.Value?.ToString() ?? string.Empty;
+ StateHasChanged();
+ }
+
+ /// <summary>
+ /// Handles confirm password input to update button state.
+ /// </summary>
+ private void OnConfirmPasswordInput(ChangeEventArgs e)
+ {
+ Input.ConfirmPassword = e.Value?.ToString() ?? string.Empty;
+ StateHasChanged();
+ }
+
protected override void OnInitialized()
{
Input ??= new();
@@ -45,6 +75,7 @@
private async Task OnValidSubmitAsync()
{
+
var user = await UserManager.FindByIdAsync(UserService.User().Id);
if (user == null)
{
diff --git a/apps/server/AliasVault.Client/Auth/Pages/Setup/Components/PasswordStep.razor b/apps/server/AliasVault.Client/Auth/Pages/Setup/Components/PasswordStep.razor
index f310685d3..88e4902a2 100644
--- a/apps/server/AliasVault.Client/Auth/Pages/Setup/Components/PasswordStep.razor
+++ b/apps/server/AliasVault.Client/Auth/Pages/Setup/Components/PasswordStep.razor
@@ -2,6 +2,7 @@
@using System.Timers
@using Microsoft.Extensions.Localization
@using AliasVault.Client.Main.Components.Shared
+@using AliasVault.Client.Main.Constants
<div class="w-full mx-auto">
@if (_isLoading)
@@ -158,7 +159,7 @@
{
await InvokeAsync(async () =>
{
- if (Password.Length < 10)
+ if (Password.Length < PasswordStrengthConstants.MinimumGoodPasswordLength)
{
_errorMessage = Localizer["PasswordTooShortError"];
await OnPasswordChange.InvokeAsync(string.Empty);
diff --git a/apps/server/AliasVault.Client/Main/Components/Shared/PasswordStrengthIndicator.razor b/apps/server/AliasVault.Client/Main/Components/Shared/PasswordStrengthIndicator.razor
index 0a9c717cd..be764ac37 100644
--- a/apps/server/AliasVault.Client/Main/Components/Shared/PasswordStrengthIndicator.razor
+++ b/apps/server/AliasVault.Client/Main/Components/Shared/PasswordStrengthIndicator.razor
@@ -1,4 +1,5 @@
@using Microsoft.Extensions.Localization
+@using AliasVault.Client.Main.Constants
@inject IStringLocalizerFactory LocalizerFactory
@if (!string.IsNullOrEmpty(Password))
@@ -88,10 +89,10 @@
return _passwordStrength switch
{
0 => "bg-orange-400 dark:bg-orange-500",
- 1 => "bg-orange-500 dark:bg-orange-600",
- 2 => "bg-yellow-500 dark:bg-yellow-600",
- 3 => "bg-blue-500 dark:bg-blue-600",
- 4 => "bg-green-500 dark:bg-green-600",
+ 1 => "bg-yellow-500 dark:bg-yellow-600",
+ 2 => "bg-green-500 dark:bg-green-600",
+ 3 => "bg-green-600 dark:bg-green-700",
+ 4 => "bg-green-700 dark:bg-green-800",
_ => "bg-gray-300 dark:bg-gray-600"
};
}
@@ -101,10 +102,10 @@
return _passwordStrength switch
{
0 => "text-orange-600 dark:text-orange-400",
- 1 => "text-orange-600 dark:text-orange-400",
- 2 => "text-yellow-600 dark:text-yellow-400",
- 3 => "text-blue-600 dark:text-blue-400",
- 4 => "text-green-600 dark:text-green-400",
+ 1 => "text-yellow-600 dark:text-yellow-400",
+ 2 => "text-green-600 dark:text-green-400",
+ 3 => "text-green-700 dark:text-green-300",
+ 4 => "text-green-800 dark:text-green-200",
_ => "text-gray-500 dark:text-gray-400"
};
}
@@ -113,4 +114,22 @@
{
return (_passwordStrength + 1) * 20;
}
+
+ /// <summary>
+ /// Gets the current password strength level.
+ /// </summary>
+ /// <returns>The password strength level (0-4).</returns>
+ public int GetPasswordStrength()
+ {
+ return _passwordStrength;
+ }
+
+ /// <summary>
+ /// Checks if the current password meets the minimum required strength.
+ /// </summary>
+ /// <returns>True if the password meets minimum requirements, false otherwise.</returns>
+ public bool MeetsMinimumRequirement()
+ {
+ return _passwordStrength >= PasswordStrengthConstants.MinimumRequiredStrength;
+ }
}
diff --git a/apps/server/AliasVault.Client/Main/Constants/PasswordStrengthConstants.cs b/apps/server/AliasVault.Client/Main/Constants/PasswordStrengthConstants.cs
new file mode 100644
index 000000000..0d78fb0b7
--- /dev/null
+++ b/apps/server/AliasVault.Client/Main/Constants/PasswordStrengthConstants.cs
@@ -0,0 +1,25 @@
+//-----------------------------------------------------------------------
+// <copyright file="PasswordStrengthConstants.cs" company="aliasvault">
+// Copyright (c) aliasvault. All rights reserved.
+// Licensed under the AGPLv3 license. See LICENSE.md file in the project root for full license information.
+// </copyright>
+//-----------------------------------------------------------------------
+
+namespace AliasVault.Client.Main.Constants;
+
+/// <summary>
+/// Constants for password strength validation and requirements.
+/// </summary>
+public static class PasswordStrengthConstants
+{
+ /// <summary>
+ /// Minimum password strength level required for account creation and password changes.
+ /// Level 2 corresponds to "Good" (12-15 characters).
+ /// </summary>
+ public const int MinimumRequiredStrength = 2;
+
+ /// <summary>
+ /// Minimum password length for "Good" strength level.
+ /// </summary>
+ public const int MinimumGoodPasswordLength = 12;
+}
diff --git a/apps/server/AliasVault.Client/Main/Models/Validation/PasswordChangeFormModel.cs b/apps/server/AliasVault.Client/Main/Models/Validation/PasswordChangeFormModel.cs
index cfbcc6177..7df3f8e92 100644
--- a/apps/server/AliasVault.Client/Main/Models/Validation/PasswordChangeFormModel.cs
+++ b/apps/server/AliasVault.Client/Main/Models/Validation/PasswordChangeFormModel.cs
@@ -8,6 +8,7 @@
namespace AliasVault.Client.Main.Models.Validation;
using System.ComponentModel.DataAnnotations;
+using AliasVault.Client.Main.Constants;
using AliasVault.Client.Resources;
using AliasVault.Shared.Models.WebApi.PasswordChange;
@@ -26,7 +27,7 @@ public class PasswordChangeFormModel : PasswordChangeModel
/// Gets or sets the new password.
/// </summary>
[Required(ErrorMessageResourceType = typeof(ValidationMessages), ErrorMessageResourceName = nameof(ValidationMessages.PasswordRequired))]
- [MinLength(10, ErrorMessageResourceType = typeof(ValidationMessages), ErrorMessageResourceName = nameof(ValidationMessages.PasswordMinLength))]
+ [MinLength(PasswordStrengthConstants.MinimumGoodPasswordLength, ErrorMessageResourceType = typeof(ValidationMessages), ErrorMessageResourceName = nameof(ValidationMessages.PasswordMinLength))]
public new string NewPassword { get; set; } = null!;
/// <summary>
diff --git a/apps/server/AliasVault.Client/Resources/Components/Auth/Setup/PasswordStep.en.resx b/apps/server/AliasVault.Client/Resources/Components/Auth/Setup/PasswordStep.en.resx
index c6caa6359..37af213c8 100644
--- a/apps/server/AliasVault.Client/Resources/Components/Auth/Setup/PasswordStep.en.resx
+++ b/apps/server/AliasVault.Client/Resources/Components/Auth/Setup/PasswordStep.en.resx
@@ -65,7 +65,7 @@
<comment>Success message for valid password</comment>
</data>
<data name="PasswordTooShortError">
- <value>Master password must be at least 10 characters long.</value>
+ <value>Master password must be at least 12 characters long (Good strength or higher).</value>
<comment>Error message for password too short</comment>
</data>
<data name="ConfirmPasswordPrompt">
diff --git a/apps/server/AliasVault.Client/Resources/Components/Main/Pages/Settings/Security/ChangePassword.en.resx b/apps/server/AliasVault.Client/Resources/Components/Main/Pages/Settings/Security/ChangePassword.en.resx
index 4a9c21136..89b229d8e 100644
--- a/apps/server/AliasVault.Client/Resources/Components/Main/Pages/Settings/Security/ChangePassword.en.resx
+++ b/apps/server/AliasVault.Client/Resources/Components/Main/Pages/Settings/Security/ChangePassword.en.resx
@@ -116,4 +116,8 @@
<value>Failed to change password. Please refresh the page and try again.</value>
<comment>Error message when password change fails</comment>
</data>
+ <data name="PasswordStrengthTooWeakError" xml:space="preserve">
+ <value>Your new password must be at least 12 characters long (Good strength or higher).</value>
+ <comment>Error message when password strength is too weak</comment>
+ </data>
</root>
\ No newline at end of file
diff --git a/apps/server/AliasVault.Client/Resources/ValidationMessages.en.resx b/apps/server/AliasVault.Client/Resources/ValidationMessages.en.resx
index d813bd1e6..8d27c046e 100644
--- a/apps/server/AliasVault.Client/Resources/ValidationMessages.en.resx
+++ b/apps/server/AliasVault.Client/Resources/ValidationMessages.en.resx
@@ -61,7 +61,7 @@
<!-- Password validation messages -->
<data name="PasswordMinLength" xml:space="preserve">
- <value>The new password must be at least 10 characters long.</value>
+ <value>The new password must be at least 12 characters long (Good strength or higher).</value>
<comment>Error message for password minimum length validation</comment>
</data>
<data name="PasswordsDoNotMatch" xml:space="preserve">
@@ -69,7 +69,7 @@
<comment>Error message when password confirmation doesn't match</comment>
</data>
<data name="PasswordMinLengthGeneric" xml:space="preserve">
- <value>Password must be at least 10 characters long.</value>
+ <value>Password must be at least 12 characters long (Good strength or higher).</value>
<comment>Generic error message for password minimum length validation</comment>
</data>
<data name="PasswordsDoNotMatchGeneric" xml:space="preserve">