Skip to content

Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.

Update EmailBoxController.cs (#2469)

Leendert de Borst4bee88b619a0
diff --git a/apps/server/AliasVault.Api/Controllers/V2/Email/EmailBoxController.cs b/apps/server/AliasVault.Api/Controllers/V2/Email/EmailBoxController.cs
index 8a0974f65..830bdc23d 100644
--- a/apps/server/AliasVault.Api/Controllers/V2/Email/EmailBoxController.cs
+++ b/apps/server/AliasVault.Api/Controllers/V2/Email/EmailBoxController.cs
@@ -84,14 +84,14 @@ public class EmailBoxController(IAliasServerDbContextFactory dbContextFactory, U
});
}
- // A vault push skips new aliases over the alias limit, so an unclaimed address usually means the limit was hit.
- if (emailClaim is null)
+ /*
+ * A vault push skips new aliases over the alias limit, so an unclaimed address usually means the limit was hit.
+ * Taken addresses over the lookup limit get the same answer to prevent unwanted enumeration.
+ */
+ var remaining = await rateLimitService.GetRemainingAliasAllowancesAsync(context, [user.PersonalGroupId]);
+ if (remaining.TryGetValue(user.PersonalGroupId, out var left) && left <= 0)
{
- var remaining = await rateLimitService.GetRemainingAliasAllowancesAsync(context, [user.PersonalGroupId]);
- if (remaining.TryGetValue(user.PersonalGroupId, out var left) && left <= 0)
- {
- return BadRequest(ApiErrorCodeHelper.CreateValidationErrorResponse(ApiErrorCode.ALIAS_LIMIT_REACHED, 400));
- }
+ return BadRequest(ApiErrorCodeHelper.CreateValidationErrorResponse(ApiErrorCode.ALIAS_LIMIT_REACHED, 400));
}
return BadRequest(new ApiErrorResponse