Skip to content

Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.

Remove groupname from API (#2159)

Leendert de Borst4ca16e1e1de9
diff --git a/apps/browser-extension/src/utils/dist/core/models/webapi/index.d.ts b/apps/browser-extension/src/utils/dist/core/models/webapi/index.d.ts
index 502370818..51dc8938c 100644
--- a/apps/browser-extension/src/utils/dist/core/models/webapi/index.d.ts
+++ b/apps/browser-extension/src/utils/dist/core/models/webapi/index.d.ts
@@ -556,7 +556,6 @@ type SentManifestInvitation = {
type ReceivedManifestInvitation = {
id: string;
groupId: string;
- groupName: string;
manifestId: string;
inviterUsername: string;
createdAt: string;
@@ -576,7 +575,6 @@ type SharedManifestInfo = {
*/
type GroupInfo = {
groupId: string;
- name: string;
role: GroupRole;
manifests: SharedManifestInfo[];
members: GroupMemberInfo[];
diff --git a/apps/mobile-app/utils/dist/core/models/webapi/index.d.ts b/apps/mobile-app/utils/dist/core/models/webapi/index.d.ts
index 502370818..51dc8938c 100644
--- a/apps/mobile-app/utils/dist/core/models/webapi/index.d.ts
+++ b/apps/mobile-app/utils/dist/core/models/webapi/index.d.ts
@@ -556,7 +556,6 @@ type SentManifestInvitation = {
type ReceivedManifestInvitation = {
id: string;
groupId: string;
- groupName: string;
manifestId: string;
inviterUsername: string;
createdAt: string;
@@ -576,7 +575,6 @@ type SharedManifestInfo = {
*/
type GroupInfo = {
groupId: string;
- name: string;
role: GroupRole;
manifests: SharedManifestInfo[];
members: GroupMemberInfo[];
diff --git a/apps/server/AliasVault.Api/Controllers/V2/GroupsController.cs b/apps/server/AliasVault.Api/Controllers/V2/GroupsController.cs
index f698d2371..d979c31fe 100644
--- a/apps/server/AliasVault.Api/Controllers/V2/GroupsController.cs
+++ b/apps/server/AliasVault.Api/Controllers/V2/GroupsController.cs
@@ -53,7 +53,7 @@ public class GroupsController(IAliasServerDbContextFactory dbContextFactory, Use
var memberships = await context.GroupMembers
.Where(gm => gm.UserId == me.Id && gm.Group.Type == GroupType.Shared)
- .Select(gm => new { gm.GroupId, gm.Group.Name, gm.Role })
+ .Select(gm => new { gm.GroupId, gm.Role })
.ToListAsync();
var response = new GroupOverviewResponse
@@ -97,7 +97,6 @@ public class GroupsController(IAliasServerDbContextFactory dbContextFactory, Use
response.Groups.Add(new GroupInfo
{
GroupId = membership.GroupId,
- Name = membership.Name,
Role = membership.Role.ToString(),
Manifests = [.. manifests
.Where(m => m.OwnerGroupId == membership.GroupId)
@@ -568,7 +567,6 @@ public class GroupsController(IAliasServerDbContextFactory dbContextFactory, Use
{
i.Id,
i.GroupId,
- GroupName = i.Group.Name,
ManifestId = i.VaultManifestId!.Value,
InviterUsername = i.Inviter.UserName ?? string.Empty,
i.CreatedAt,
@@ -593,7 +591,6 @@ public class GroupsController(IAliasServerDbContextFactory dbContextFactory, Use
{
Id = i.Id,
GroupId = i.GroupId,
- GroupName = i.GroupName,
ManifestId = i.ManifestId,
InviterUsername = i.InviterUsername,
CreatedAt = i.CreatedAt,
diff --git a/apps/server/Shared/AliasVault.Shared/Models/WebApi/V2/Groups/GroupInfo.cs b/apps/server/Shared/AliasVault.Shared/Models/WebApi/V2/Groups/GroupInfo.cs
index 507c543df..0e7695be2 100644
--- a/apps/server/Shared/AliasVault.Shared/Models/WebApi/V2/Groups/GroupInfo.cs
+++ b/apps/server/Shared/AliasVault.Shared/Models/WebApi/V2/Groups/GroupInfo.cs
@@ -17,11 +17,6 @@ public class GroupInfo
/// </summary>
public required Guid GroupId { get; set; }
- /// <summary>
- /// Gets or sets the group's display name.
- /// </summary>
- public required string Name { get; set; }
-
/// <summary>
/// Gets or sets the caller's own role in it.
/// </summary>
diff --git a/apps/server/Shared/AliasVault.Shared/Models/WebApi/V2/Groups/ReceivedManifestInvitation.cs b/apps/server/Shared/AliasVault.Shared/Models/WebApi/V2/Groups/ReceivedManifestInvitation.cs
index 991e704ab..99a5d82b8 100644
--- a/apps/server/Shared/AliasVault.Shared/Models/WebApi/V2/Groups/ReceivedManifestInvitation.cs
+++ b/apps/server/Shared/AliasVault.Shared/Models/WebApi/V2/Groups/ReceivedManifestInvitation.cs
@@ -18,9 +18,6 @@ public class ReceivedManifestInvitation
/// <summary>Gets or sets the group the vault belongs to.</summary>
public required Guid GroupId { get; set; }
- /// <summary>Gets or sets the group's display name.</summary>
- public required string GroupName { get; set; }
-
/// <summary>Gets or sets the vault being offered.</summary>
public required Guid ManifestId { get; set; }
diff --git a/core/models/src/webapi/Groups.ts b/core/models/src/webapi/Groups.ts
index 4422bd971..55fc39bb4 100644
--- a/core/models/src/webapi/Groups.ts
+++ b/core/models/src/webapi/Groups.ts
@@ -36,7 +36,6 @@ export type SentManifestInvitation = {
export type ReceivedManifestInvitation = {
id: string;
groupId: string;
- groupName: string;
manifestId: string;
inviterUsername: string;
createdAt: string;
@@ -58,7 +57,6 @@ export type SharedManifestInfo = {
*/
export type GroupInfo = {
groupId: string;
- name: string;
role: GroupRole;
manifests: SharedManifestInfo[];
members: GroupMemberInfo[];