Skip to content

Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.

Update password generator with non-ambigious char improvement (#1398)

Leendert de Borst4e0db87bc352
diff --git a/apps/browser-extension/src/utils/dist/shared/password-generator/index.d.ts b/apps/browser-extension/src/utils/dist/shared/password-generator/index.d.ts
index 723e4f172..ebfe93c7b 100644
--- a/apps/browser-extension/src/utils/dist/shared/password-generator/index.d.ts
+++ b/apps/browser-extension/src/utils/dist/shared/password-generator/index.d.ts
@@ -36,6 +36,20 @@ declare class PasswordGenerator {
private readonly uppercaseChars;
private readonly numberChars;
private readonly specialChars;
+ /**
+ * Ambiguous characters that look similar and are easy to confuse when typing:
+ * - I, l, 1, | (pipe) - all look like vertical lines
+ * - O, 0, o - all look like circles
+ * - Z, 2 - similar appearance
+ * - S, 5 - similar appearance
+ * - B, 8 - similar appearance
+ * - G, 6 - similar appearance
+ * - Brackets, braces, parentheses: [], {}, ()
+ * - Quotes: ', ", `
+ * - Punctuation pairs: ;:, .,
+ * - Dashes: -, _
+ * - Angle brackets: <>
+ */
private readonly ambiguousChars;
private length;
private useLowercase;
diff --git a/apps/browser-extension/src/utils/dist/shared/password-generator/index.js b/apps/browser-extension/src/utils/dist/shared/password-generator/index.js
index b456b2da8..bf5e27681 100644
--- a/apps/browser-extension/src/utils/dist/shared/password-generator/index.js
+++ b/apps/browser-extension/src/utils/dist/shared/password-generator/index.js
@@ -39,7 +39,21 @@ var PasswordGenerator = class {
this.uppercaseChars = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
this.numberChars = "0123456789";
this.specialChars = "!@#$%^&*()_+-=[]{}|;:,.<>?";
- this.ambiguousChars = "Il1O0o";
+ /**
+ * Ambiguous characters that look similar and are easy to confuse when typing:
+ * - I, l, 1, | (pipe) - all look like vertical lines
+ * - O, 0, o - all look like circles
+ * - Z, 2 - similar appearance
+ * - S, 5 - similar appearance
+ * - B, 8 - similar appearance
+ * - G, 6 - similar appearance
+ * - Brackets, braces, parentheses: [], {}, ()
+ * - Quotes: ', ", `
+ * - Punctuation pairs: ;:, .,
+ * - Dashes: -, _
+ * - Angle brackets: <>
+ */
+ this.ambiguousChars = "Il1O0oZzSsBbGg2568|[]{}()<>;:,.`'\"_-";
this.length = 18;
this.useLowercase = true;
this.useUppercase = true;
diff --git a/apps/browser-extension/src/utils/dist/shared/password-generator/index.mjs b/apps/browser-extension/src/utils/dist/shared/password-generator/index.mjs
index 87e2df235..9eaa3caa5 100644
--- a/apps/browser-extension/src/utils/dist/shared/password-generator/index.mjs
+++ b/apps/browser-extension/src/utils/dist/shared/password-generator/index.mjs
@@ -13,7 +13,21 @@ var PasswordGenerator = class {
this.uppercaseChars = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
this.numberChars = "0123456789";
this.specialChars = "!@#$%^&*()_+-=[]{}|;:,.<>?";
- this.ambiguousChars = "Il1O0o";
+ /**
+ * Ambiguous characters that look similar and are easy to confuse when typing:
+ * - I, l, 1, | (pipe) - all look like vertical lines
+ * - O, 0, o - all look like circles
+ * - Z, 2 - similar appearance
+ * - S, 5 - similar appearance
+ * - B, 8 - similar appearance
+ * - G, 6 - similar appearance
+ * - Brackets, braces, parentheses: [], {}, ()
+ * - Quotes: ', ", `
+ * - Punctuation pairs: ;:, .,
+ * - Dashes: -, _
+ * - Angle brackets: <>
+ */
+ this.ambiguousChars = "Il1O0oZzSsBbGg2568|[]{}()<>;:,.`'\"_-";
this.length = 18;
this.useLowercase = true;
this.useUppercase = true;
diff --git a/apps/mobile-app/utils/dist/shared/password-generator/index.d.ts b/apps/mobile-app/utils/dist/shared/password-generator/index.d.ts
index 723e4f172..ebfe93c7b 100644
--- a/apps/mobile-app/utils/dist/shared/password-generator/index.d.ts
+++ b/apps/mobile-app/utils/dist/shared/password-generator/index.d.ts
@@ -36,6 +36,20 @@ declare class PasswordGenerator {
private readonly uppercaseChars;
private readonly numberChars;
private readonly specialChars;
+ /**
+ * Ambiguous characters that look similar and are easy to confuse when typing:
+ * - I, l, 1, | (pipe) - all look like vertical lines
+ * - O, 0, o - all look like circles
+ * - Z, 2 - similar appearance
+ * - S, 5 - similar appearance
+ * - B, 8 - similar appearance
+ * - G, 6 - similar appearance
+ * - Brackets, braces, parentheses: [], {}, ()
+ * - Quotes: ', ", `
+ * - Punctuation pairs: ;:, .,
+ * - Dashes: -, _
+ * - Angle brackets: <>
+ */
private readonly ambiguousChars;
private length;
private useLowercase;
diff --git a/apps/mobile-app/utils/dist/shared/password-generator/index.js b/apps/mobile-app/utils/dist/shared/password-generator/index.js
index b456b2da8..bf5e27681 100644
--- a/apps/mobile-app/utils/dist/shared/password-generator/index.js
+++ b/apps/mobile-app/utils/dist/shared/password-generator/index.js
@@ -39,7 +39,21 @@ var PasswordGenerator = class {
this.uppercaseChars = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
this.numberChars = "0123456789";
this.specialChars = "!@#$%^&*()_+-=[]{}|;:,.<>?";
- this.ambiguousChars = "Il1O0o";
+ /**
+ * Ambiguous characters that look similar and are easy to confuse when typing:
+ * - I, l, 1, | (pipe) - all look like vertical lines
+ * - O, 0, o - all look like circles
+ * - Z, 2 - similar appearance
+ * - S, 5 - similar appearance
+ * - B, 8 - similar appearance
+ * - G, 6 - similar appearance
+ * - Brackets, braces, parentheses: [], {}, ()
+ * - Quotes: ', ", `
+ * - Punctuation pairs: ;:, .,
+ * - Dashes: -, _
+ * - Angle brackets: <>
+ */
+ this.ambiguousChars = "Il1O0oZzSsBbGg2568|[]{}()<>;:,.`'\"_-";
this.length = 18;
this.useLowercase = true;
this.useUppercase = true;
diff --git a/apps/mobile-app/utils/dist/shared/password-generator/index.mjs b/apps/mobile-app/utils/dist/shared/password-generator/index.mjs
index 87e2df235..9eaa3caa5 100644
--- a/apps/mobile-app/utils/dist/shared/password-generator/index.mjs
+++ b/apps/mobile-app/utils/dist/shared/password-generator/index.mjs
@@ -13,7 +13,21 @@ var PasswordGenerator = class {
this.uppercaseChars = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
this.numberChars = "0123456789";
this.specialChars = "!@#$%^&*()_+-=[]{}|;:,.<>?";
- this.ambiguousChars = "Il1O0o";
+ /**
+ * Ambiguous characters that look similar and are easy to confuse when typing:
+ * - I, l, 1, | (pipe) - all look like vertical lines
+ * - O, 0, o - all look like circles
+ * - Z, 2 - similar appearance
+ * - S, 5 - similar appearance
+ * - B, 8 - similar appearance
+ * - G, 6 - similar appearance
+ * - Brackets, braces, parentheses: [], {}, ()
+ * - Quotes: ', ", `
+ * - Punctuation pairs: ;:, .,
+ * - Dashes: -, _
+ * - Angle brackets: <>
+ */
+ this.ambiguousChars = "Il1O0oZzSsBbGg2568|[]{}()<>;:,.`'\"_-";
this.length = 18;
this.useLowercase = true;
this.useUppercase = true;
diff --git a/apps/server/AliasVault.Client/wwwroot/js/dist/shared/password-generator/index.d.ts b/apps/server/AliasVault.Client/wwwroot/js/dist/shared/password-generator/index.d.ts
index 723e4f172..ebfe93c7b 100644
--- a/apps/server/AliasVault.Client/wwwroot/js/dist/shared/password-generator/index.d.ts
+++ b/apps/server/AliasVault.Client/wwwroot/js/dist/shared/password-generator/index.d.ts
@@ -36,6 +36,20 @@ declare class PasswordGenerator {
private readonly uppercaseChars;
private readonly numberChars;
private readonly specialChars;
+ /**
+ * Ambiguous characters that look similar and are easy to confuse when typing:
+ * - I, l, 1, | (pipe) - all look like vertical lines
+ * - O, 0, o - all look like circles
+ * - Z, 2 - similar appearance
+ * - S, 5 - similar appearance
+ * - B, 8 - similar appearance
+ * - G, 6 - similar appearance
+ * - Brackets, braces, parentheses: [], {}, ()
+ * - Quotes: ', ", `
+ * - Punctuation pairs: ;:, .,
+ * - Dashes: -, _
+ * - Angle brackets: <>
+ */
private readonly ambiguousChars;
private length;
private useLowercase;
diff --git a/apps/server/AliasVault.Client/wwwroot/js/dist/shared/password-generator/index.js b/apps/server/AliasVault.Client/wwwroot/js/dist/shared/password-generator/index.js
index b456b2da8..bf5e27681 100644
--- a/apps/server/AliasVault.Client/wwwroot/js/dist/shared/password-generator/index.js
+++ b/apps/server/AliasVault.Client/wwwroot/js/dist/shared/password-generator/index.js
@@ -39,7 +39,21 @@ var PasswordGenerator = class {
this.uppercaseChars = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
this.numberChars = "0123456789";
this.specialChars = "!@#$%^&*()_+-=[]{}|;:,.<>?";
- this.ambiguousChars = "Il1O0o";
+ /**
+ * Ambiguous characters that look similar and are easy to confuse when typing:
+ * - I, l, 1, | (pipe) - all look like vertical lines
+ * - O, 0, o - all look like circles
+ * - Z, 2 - similar appearance
+ * - S, 5 - similar appearance
+ * - B, 8 - similar appearance
+ * - G, 6 - similar appearance
+ * - Brackets, braces, parentheses: [], {}, ()
+ * - Quotes: ', ", `
+ * - Punctuation pairs: ;:, .,
+ * - Dashes: -, _
+ * - Angle brackets: <>
+ */
+ this.ambiguousChars = "Il1O0oZzSsBbGg2568|[]{}()<>;:,.`'\"_-";
this.length = 18;
this.useLowercase = true;
this.useUppercase = true;
diff --git a/apps/server/AliasVault.Client/wwwroot/js/dist/shared/password-generator/index.mjs b/apps/server/AliasVault.Client/wwwroot/js/dist/shared/password-generator/index.mjs
index 87e2df235..9eaa3caa5 100644
--- a/apps/server/AliasVault.Client/wwwroot/js/dist/shared/password-generator/index.mjs
+++ b/apps/server/AliasVault.Client/wwwroot/js/dist/shared/password-generator/index.mjs
@@ -13,7 +13,21 @@ var PasswordGenerator = class {
this.uppercaseChars = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
this.numberChars = "0123456789";
this.specialChars = "!@#$%^&*()_+-=[]{}|;:,.<>?";
- this.ambiguousChars = "Il1O0o";
+ /**
+ * Ambiguous characters that look similar and are easy to confuse when typing:
+ * - I, l, 1, | (pipe) - all look like vertical lines
+ * - O, 0, o - all look like circles
+ * - Z, 2 - similar appearance
+ * - S, 5 - similar appearance
+ * - B, 8 - similar appearance
+ * - G, 6 - similar appearance
+ * - Brackets, braces, parentheses: [], {}, ()
+ * - Quotes: ', ", `
+ * - Punctuation pairs: ;:, .,
+ * - Dashes: -, _
+ * - Angle brackets: <>
+ */
+ this.ambiguousChars = "Il1O0oZzSsBbGg2568|[]{}()<>;:,.`'\"_-";
this.length = 18;
this.useLowercase = true;
this.useUppercase = true;