Skip to content

Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.

Add primary action color to browser extension header bar (#2287)

Leendert de Borst50e6ffae11f9
diff --git a/apps/browser-extension/src/entrypoints/popup/components/HeaderButton.tsx b/apps/browser-extension/src/entrypoints/popup/components/HeaderButton.tsx
index 11eb9d3f4..62786281b 100644
--- a/apps/browser-extension/src/entrypoints/popup/components/HeaderButton.tsx
+++ b/apps/browser-extension/src/entrypoints/popup/components/HeaderButton.tsx
@@ -26,26 +26,31 @@ const HeaderButton: React.FC<HeaderButtonProps> = ({
isLoading = false,
isActive = false
}) => {
- const colorClasses = {
- default: 'text-gray-500 hover:text-gray-700 dark:text-gray-400 dark:hover:text-gray-200 hover:bg-gray-100 dark:hover:bg-gray-700',
- primary: 'text-primary-600 hover:text-primary-700 dark:text-primary-400 dark:hover:text-primary-300 hover:bg-primary-100 dark:hover:bg-primary-900/20',
- danger: 'text-red-500 hover:text-red-600 hover:bg-red-100 dark:hover:bg-red-900/20'
- };
-
- const activeClasses = {
- default: 'bg-gray-100 dark:bg-gray-700 text-gray-700 dark:text-gray-200',
- primary: 'bg-primary-100 dark:bg-primary-900/20',
- danger: 'bg-red-100 dark:bg-red-900/20'
+ /** The `primary` variant is filled with the accent color to mark the main action of a screen. */
+ const variantClasses = {
+ default: {
+ base: 'text-gray-500 hover:text-gray-700 hover:bg-gray-100 dark:text-gray-400 dark:hover:text-gray-200 dark:hover:bg-gray-700',
+ active: 'text-gray-700 bg-gray-100 dark:text-gray-200 dark:bg-gray-700'
+ },
+ primary: {
+ base: 'text-white bg-primary-600 hover:bg-primary-700 shadow-sm',
+ active: 'text-white bg-primary-700 shadow-sm'
+ },
+ danger: {
+ base: 'text-red-500 hover:text-red-600 hover:bg-red-100 dark:hover:bg-red-900/20',
+ active: 'text-red-600 bg-red-100 dark:bg-red-900/20'
+ }
};
const isDisabled = disabled || isLoading;
+ const stateClasses = variantClasses[variant][isActive ? 'active' : 'base'];
return (
<button
id={id}
onClick={onClick}
disabled={isDisabled}
- className={`p-2 rounded-lg ${colorClasses[variant]} ${isActive ? activeClasses[variant] : ''} ${isDisabled ? 'opacity-50 cursor-not-allowed' : ''}`}
+ className={`p-2 rounded-lg transition-colors ${stateClasses} ${isDisabled ? 'opacity-50 cursor-not-allowed' : ''}`}
title={title}
>
{isLoading ? (
diff --git a/apps/browser-extension/src/entrypoints/popup/components/Items/AddItemDropdown.tsx b/apps/browser-extension/src/entrypoints/popup/components/Items/AddItemDropdown.tsx
index 1039e1951..7d72172f1 100644
--- a/apps/browser-extension/src/entrypoints/popup/components/Items/AddItemDropdown.tsx
+++ b/apps/browser-extension/src/entrypoints/popup/components/Items/AddItemDropdown.tsx
@@ -43,6 +43,7 @@ const AddItemDropdown: React.FC<AddItemDropdownProps> = ({ onSelect }) => {
onClick={() => (isOpen ? closeMenu() : setIsOpen(true))}
title={t('items.addNewItem')}
iconType={HeaderIconType.PLUS}
+ variant="primary"
isActive={isOpen}
/>
diff --git a/apps/browser-extension/src/entrypoints/popup/components/Items/ItemTypeSelector.tsx b/apps/browser-extension/src/entrypoints/popup/components/Items/ItemTypeSelector.tsx
index ccee8dbc1..6f9c3d1b9 100644
--- a/apps/browser-extension/src/entrypoints/popup/components/Items/ItemTypeSelector.tsx
+++ b/apps/browser-extension/src/entrypoints/popup/components/Items/ItemTypeSelector.tsx
@@ -88,17 +88,18 @@ const ItemTypeSelector: React.FC<ItemTypeSelectorProps> = ({
onClick={() => onDropdownToggle(!showDropdown)}
className="flex-1 flex items-center justify-between gap-2 min-w-0 hover:opacity-80 transition-opacity"
>
- {/* Inline label so it's clear the row is a picker, not just a status badge */}
- <span className="text-xs text-primary-600/80 dark:text-primary-400/80 truncate">
- {t('itemTypes.typeLabel')}
- </span>
- <span className="flex items-center gap-1.5 min-w-0">
+ <span className="flex items-center gap-2 min-w-0">
<span className="shrink-0 text-primary-600 dark:text-primary-400">
{selectedTypeOption?.iconSvg}
</span>
<span className="text-primary-700 dark:text-primary-300 font-medium text-sm truncate">
{selectedTypeOption ? t(selectedTypeOption.titleKey) : ''}
</span>
+ </span>
+ <span className="flex items-center gap-1 min-w-0">
+ <span className="text-xs text-primary-600/80 dark:text-primary-400/80 truncate">
+ {t('itemTypes.typeLabel')}
+ </span>
<svg
className={`w-4 h-4 shrink-0 text-primary-500 transition-transform ${showDropdown ? 'rotate-180' : ''}`}
fill="none"
diff --git a/apps/browser-extension/src/entrypoints/popup/pages/items/ItemAddEdit.tsx b/apps/browser-extension/src/entrypoints/popup/pages/items/ItemAddEdit.tsx
index 60cd536bc..7ce6915a8 100644
--- a/apps/browser-extension/src/entrypoints/popup/pages/items/ItemAddEdit.tsx
+++ b/apps/browser-extension/src/entrypoints/popup/pages/items/ItemAddEdit.tsx
@@ -1096,6 +1096,7 @@ const ItemAddEdit: React.FC = () => {
onClick={handleSave}
title={isSaving ? t('common.saving') : t('items.saveItem')}
iconType={HeaderIconType.SAVE}
+ variant="primary"
isLoading={isSaving}
disabled={isSaving}
/>
diff --git a/apps/browser-extension/src/entrypoints/popup/pages/items/ItemDetails.tsx b/apps/browser-extension/src/entrypoints/popup/pages/items/ItemDetails.tsx
index c9dee3c5c..9b1a839fe 100644
--- a/apps/browser-extension/src/entrypoints/popup/pages/items/ItemDetails.tsx
+++ b/apps/browser-extension/src/entrypoints/popup/pages/items/ItemDetails.tsx
@@ -89,6 +89,7 @@ const ItemDetails: React.FC = (): React.ReactElement => {
onClick={handleEdit}
title={t('items.editItem')}
iconType={HeaderIconType.EDIT}
+ variant="primary"
/>
</div>
);