Skip to content

Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.

Add sanity checks (#2159)

Leendert de Borst53d98145d1ea
diff --git a/apps/server/AliasVault.Client/Main/Components/Attachments/AttachmentUploader.razor b/apps/server/AliasVault.Client/Main/Components/Attachments/AttachmentUploader.razor
index ac3f1ca63..7f03e5662 100644
--- a/apps/server/AliasVault.Client/Main/Components/Attachments/AttachmentUploader.razor
+++ b/apps/server/AliasVault.Client/Main/Components/Attachments/AttachmentUploader.razor
@@ -81,6 +81,13 @@
using var ms = new MemoryStream();
await file.OpenReadStream(MaxFileSize).CopyToAsync(ms);
+ // The vault stores no attachment without bytes.
+ if (ms.Length == 0)
+ {
+ StatusMessage = $"Error uploading file: {file.Name} is empty.";
+ continue;
+ }
+
var attachment = new Attachment
{
Filename = file.Name,
diff --git a/apps/server/AliasVault.Client/Services/Database/VaultTableReader.cs b/apps/server/AliasVault.Client/Services/Database/VaultTableReader.cs
index 8693058f9..8f74b4b73 100644
--- a/apps/server/AliasVault.Client/Services/Database/VaultTableReader.cs
+++ b/apps/server/AliasVault.Client/Services/Database/VaultTableReader.cs
@@ -120,7 +120,7 @@ public static class VaultTableReader
public static async Task<string?> ReadActivePublicKeyAsync(SqliteConnection connection, Guid manifestId)
{
await using var command = connection.CreateCommand();
- command.CommandText = "SELECT PublicKey FROM EncryptionKeys WHERE UPPER(ManifestId) = UPPER(@manifestId) AND IsPrimary = 1 AND IsDeleted = 0 LIMIT 1";
+ command.CommandText = "SELECT PublicKey FROM EncryptionKeys WHERE ManifestId = @manifestId AND IsPrimary = 1 AND IsDeleted = 0 LIMIT 1";
command.Parameters.AddWithValue("@manifestId", manifestId.ToString());
return await command.ExecuteScalarAsync() as string;
}
diff --git a/apps/server/AliasVault.Client/Services/ItemService.cs b/apps/server/AliasVault.Client/Services/ItemService.cs
index eec8a07e6..de0a69670 100644
--- a/apps/server/AliasVault.Client/Services/ItemService.cs
+++ b/apps/server/AliasVault.Client/Services/ItemService.cs
@@ -1,4 +1,4 @@
-//-----------------------------------------------------------------------
+//-----------------------------------------------------------------------
// <copyright file="ItemService.cs" company="aliasvault">
// Copyright (c) aliasvault. All rights reserved.
// Licensed under the AGPLv3 license. See LICENSE.md file in the project root for full license information.