Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.
Add mobile app login request clear task to task runner (#1347)
Leendert de Borst582ab7d20a9d
diff --git a/apps/server/AliasVault.Admin/Main/Pages/MobileLoginHistory.razor b/apps/server/AliasVault.Admin/Main/Pages/MobileLoginHistory.razorindex f461f7577..040e0c542 100644--- a/apps/server/AliasVault.Admin/Main/Pages/MobileLoginHistory.razor+++ b/apps/server/AliasVault.Admin/Main/Pages/MobileLoginHistory.razor@@ -9,7 +9,7 @@<PageHeaderBreadcrumbItems="@BreadcrumbItems"Title="@(TotalRecords > 0 ? $"Mobile Login History ({TotalRecords:N0})" : "Mobile Login History")"- Description="View all mobile login requests with IP addresses, timestamps, and fulfillment status.">+ Description="View all 'login with mobile app' login requests, including IP addresses, timestamps, and whether they were fulfilled. Each record represents a single attempt to log in using the mobile app."><CustomActions><RefreshButton OnClick="() => RefreshData(CancellationToken.None)" ButtonText="Refresh" /></CustomActions>diff --git a/apps/server/AliasVault.Admin/Main/Pages/Settings/Server.razor b/apps/server/AliasVault.Admin/Main/Pages/Settings/Server.razorindex 3e964af90..a19dee2e8 100644--- a/apps/server/AliasVault.Admin/Main/Pages/Settings/Server.razor+++ b/apps/server/AliasVault.Admin/Main/Pages/Settings/Server.razor@@ -48,6 +48,12 @@<input type="number" @bind="Settings.AuthLogRetentionDays" id="authLogRetention" class="bg-gray-50 border border-gray-300 text-gray-900 text-sm rounded-lg focus:ring-primary-600 focus:border-primary-600 block w-full p-2.5 dark:bg-gray-700 dark:border-gray-600 dark:placeholder-gray-400 dark:text-white dark:focus:ring-primary-500 dark:focus:border-primary-500"><p class="mt-1 text-sm text-gray-500 dark:text-gray-400">Number of days to keep auth logs before deletion. Set to 0 to disable automatic cleanup.</p></div>+ <div>+ <label for="mobileLoginLogRetention" class="block mb-2 text-sm font-medium text-gray-900 dark:text-white">Mobile Login Log Retention (days)</label>+ <input type="number" @bind="Settings.MobileLoginLogRetentionDays" id="mobileLoginLogRetention" class="bg-gray-50 border border-gray-300 text-gray-900 text-sm rounded-lg focus:ring-primary-600 focus:border-primary-600 block w-full p-2.5 dark:bg-gray-700 dark:border-gray-600 dark:placeholder-gray-400 dark:text-white dark:focus:ring-primary-500 dark:focus:border-primary-500">+ <p class="mt-1 text-sm text-gray-500 dark:text-gray-400">+ Number of days to keep mobile login request logs before deletion. Set to 0 to disable automatic cleanup. </p>+ </div></div></div>diff --git a/apps/server/Databases/AliasServerDb/Migrations/20251117175358_AddMobileLoginRequest.Designer.cs b/apps/server/Databases/AliasServerDb/Migrations/20251117203100_AddMobileLoginRequest.Designer.cssimilarity index 99%rename from apps/server/Databases/AliasServerDb/Migrations/20251117175358_AddMobileLoginRequest.Designer.csrename to apps/server/Databases/AliasServerDb/Migrations/20251117203100_AddMobileLoginRequest.Designer.csindex 68a99934b..28263febe 100644--- a/apps/server/Databases/AliasServerDb/Migrations/20251117175358_AddMobileLoginRequest.Designer.cs+++ b/apps/server/Databases/AliasServerDb/Migrations/20251117203100_AddMobileLoginRequest.Designer.cs@@ -12,7 +12,7 @@ using Npgsql.EntityFrameworkCore.PostgreSQL.Metadata;namespace AliasServerDb.Migrations{[DbContext(typeof(AliasServerDbContext))]- [Migration("20251117175358_AddMobileLoginRequest")]+ [Migration("20251117203100_AddMobileLoginRequest")]partial class AddMobileLoginRequest{/// <inheritdoc />@@ -496,6 +496,9 @@ namespace AliasServerDb.Migrationsb.Property<string>("Id").HasColumnType("text");+ b.Property<DateTime?>("ClearedAt")+ .HasColumnType("timestamp with time zone");+b.Property<string>("ClientIpAddress").HasColumnType("text");@@ -539,11 +542,9 @@ namespace AliasServerDb.Migrationsb.HasIndex(new[] { "CreatedAt" }, "IX_CreatedAt");- b.HasIndex(new[] { "FulfilledAt" }, "IX_FulfilledAt");-b.HasIndex(new[] { "MobileIpAddress" }, "IX_MobileIpAddress");- b.HasIndex(new[] { "RetrievedAt" }, "IX_RetrievedAt");+ b.HasIndex(new[] { "RetrievedAt", "ClearedAt", "FulfilledAt" }, "IX_RetrievedAt_ClearedAt_FulfilledAt");b.HasIndex(new[] { "UserId" }, "IX_UserId");diff --git a/apps/server/Databases/AliasServerDb/Migrations/20251117175358_AddMobileLoginRequest.cs b/apps/server/Databases/AliasServerDb/Migrations/20251117203100_AddMobileLoginRequest.cssimilarity index 91%rename from apps/server/Databases/AliasServerDb/Migrations/20251117175358_AddMobileLoginRequest.csrename to apps/server/Databases/AliasServerDb/Migrations/20251117203100_AddMobileLoginRequest.csindex b9a4a54c4..6aa4b1194 100644--- a/apps/server/Databases/AliasServerDb/Migrations/20251117175358_AddMobileLoginRequest.cs+++ b/apps/server/Databases/AliasServerDb/Migrations/20251117203100_AddMobileLoginRequest.cs@@ -1,4 +1,5 @@-using System;+// <auto-generated />+using System;using Microsoft.EntityFrameworkCore.Migrations;#nullable disable@@ -25,6 +26,7 @@ namespace AliasServerDb.MigrationsCreatedAt = table.Column<DateTime>(type: "timestamp with time zone", nullable: false),FulfilledAt = table.Column<DateTime>(type: "timestamp with time zone", nullable: true),RetrievedAt = table.Column<DateTime>(type: "timestamp with time zone", nullable: true),+ ClearedAt = table.Column<DateTime>(type: "timestamp with time zone", nullable: true),ClientIpAddress = table.Column<string>(type: "text", nullable: true),MobileIpAddress = table.Column<string>(type: "text", nullable: true),UserId = table.Column<string>(type: "text", nullable: true)@@ -49,20 +51,15 @@ namespace AliasServerDb.Migrationstable: "MobileLoginRequests",column: "CreatedAt");- migrationBuilder.CreateIndex(- name: "IX_FulfilledAt",- table: "MobileLoginRequests",- column: "FulfilledAt");-migrationBuilder.CreateIndex(name: "IX_MobileIpAddress",table: "MobileLoginRequests",column: "MobileIpAddress");migrationBuilder.CreateIndex(- name: "IX_RetrievedAt",+ name: "IX_RetrievedAt_ClearedAt_FulfilledAt",table: "MobileLoginRequests",- column: "RetrievedAt");+ columns: new[] { "RetrievedAt", "ClearedAt", "FulfilledAt" });migrationBuilder.CreateIndex(name: "IX_UserId",diff --git a/apps/server/Databases/AliasServerDb/Migrations/AliasServerDbContextModelSnapshot.cs b/apps/server/Databases/AliasServerDb/Migrations/AliasServerDbContextModelSnapshot.csindex 6c39e5759..c598cb0c9 100644--- a/apps/server/Databases/AliasServerDb/Migrations/AliasServerDbContextModelSnapshot.cs+++ b/apps/server/Databases/AliasServerDb/Migrations/AliasServerDbContextModelSnapshot.cs@@ -493,6 +493,9 @@ namespace AliasServerDb.Migrationsb.Property<string>("Id").HasColumnType("text");+ b.Property<DateTime?>("ClearedAt")+ .HasColumnType("timestamp with time zone");+b.Property<string>("ClientIpAddress").HasColumnType("text");@@ -536,11 +539,9 @@ namespace AliasServerDb.Migrationsb.HasIndex(new[] { "CreatedAt" }, "IX_CreatedAt");- b.HasIndex(new[] { "FulfilledAt" }, "IX_FulfilledAt");-b.HasIndex(new[] { "MobileIpAddress" }, "IX_MobileIpAddress");- b.HasIndex(new[] { "RetrievedAt" }, "IX_RetrievedAt");+ b.HasIndex(new[] { "RetrievedAt", "ClearedAt", "FulfilledAt" }, "IX_RetrievedAt_ClearedAt_FulfilledAt");b.HasIndex(new[] { "UserId" }, "IX_UserId");diff --git a/apps/server/Databases/AliasServerDb/MobileLoginRequest.cs b/apps/server/Databases/AliasServerDb/MobileLoginRequest.csindex b2e14e6cc..af759eac0 100644--- a/apps/server/Databases/AliasServerDb/MobileLoginRequest.cs+++ b/apps/server/Databases/AliasServerDb/MobileLoginRequest.cs@@ -12,11 +12,10 @@ using Microsoft.EntityFrameworkCore;/// <summary>/// Mobile login request entity for storing temporary login requests./// </summary>+[Index(nameof(RetrievedAt), nameof(ClearedAt), nameof(FulfilledAt), Name = "IX_RetrievedAt_ClearedAt_FulfilledAt")][Index(nameof(ClientIpAddress), Name = "IX_ClientIpAddress")][Index(nameof(MobileIpAddress), Name = "IX_MobileIpAddress")][Index(nameof(CreatedAt), Name = "IX_CreatedAt")]-[Index(nameof(FulfilledAt), Name = "IX_FulfilledAt")]-[Index(nameof(RetrievedAt), Name = "IX_RetrievedAt")][Index(nameof(UserId), Name = "IX_UserId")]public class MobileLoginRequest{@@ -75,6 +74,13 @@ public class MobileLoginRequest/// </summary>public DateTime? RetrievedAt { get; set; }+ /// <summary>+ /// Gets or sets the timestamp when sensitive data was cleared from this record.+ /// Sensitive data (ClientPublicKey, EncryptedDecryptionKey, Salt, etc.) is cleared+ /// after a timeout period to minimize risk if server is compromised.+ /// </summary>+ public DateTime? ClearedAt { get; set; }+/// <summary>/// Gets or sets the IP address of the client that initiated the request./// </summary>diff --git a/apps/server/Services/AliasVault.TaskRunner/Tasks/LogCleanupTask.cs b/apps/server/Services/AliasVault.TaskRunner/Tasks/LogCleanupTask.csindex 48f17a9b0..5c8484663 100644--- a/apps/server/Services/AliasVault.TaskRunner/Tasks/LogCleanupTask.cs+++ b/apps/server/Services/AliasVault.TaskRunner/Tasks/LogCleanupTask.cs@@ -69,5 +69,44 @@ public class LogCleanupTask : IMaintenanceTask.ExecuteDeleteAsync(cancellationToken);_logger.LogInformation("Deleted {Count} auth log entries older than {Days} days", deletedCount, settings.AuthLogRetentionDays);}++ if (settings.MobileLoginLogRetentionDays > 0)+ {+ var cutoffDate = DateTime.UtcNow.AddDays(-settings.MobileLoginLogRetentionDays);+ var deletedCount = await dbContext.MobileLoginRequests+ .Where(x => x.CreatedAt < cutoffDate)+ .ExecuteDeleteAsync(cancellationToken);+ _logger.LogInformation("Deleted {Count} mobile login request entries older than {Days} days", deletedCount, settings.MobileLoginLogRetentionDays);+ }++ // Clear sensitive data from stale mobile login requests (fulfilled > 10 minutes ago but not retrieved)+ const int sensitiveDataTimeoutMinutes = 10;+ var cutoffTime = DateTime.UtcNow.AddMinutes(-sensitiveDataTimeoutMinutes);++ var staleRequests = await dbContext.MobileLoginRequests+ .Where(r =>+ r.FulfilledAt != null &&+ r.FulfilledAt < cutoffTime &&+ r.RetrievedAt == null &&+ r.ClearedAt == null)+ .ToListAsync(cancellationToken);++ if (staleRequests.Count > 0)+ {+ var now = DateTime.UtcNow;+ foreach (var request in staleRequests)+ {+ // Clear all sensitive data+ request.ClientPublicKey = string.Empty;+ request.EncryptedDecryptionKey = null;+ request.Salt = null;+ request.EncryptionType = null;+ request.EncryptionSettings = null;+ request.ClearedAt = now;+ }++ await dbContext.SaveChangesAsync(cancellationToken);+ _logger.LogInformation("Cleared encrypted data from {Count} fulfilled but not retrieved mobile login requests", staleRequests.Count);+ }}}diff --git a/apps/server/Shared/AliasVault.Shared.Server/Models/ServerSettingsModel.cs b/apps/server/Shared/AliasVault.Shared.Server/Models/ServerSettingsModel.csindex 3eab0434e..6cbe217f2 100644--- a/apps/server/Shared/AliasVault.Shared.Server/Models/ServerSettingsModel.cs+++ b/apps/server/Shared/AliasVault.Shared.Server/Models/ServerSettingsModel.cs@@ -22,6 +22,12 @@ public class ServerSettingsModel/// </summary>public int AuthLogRetentionDays { get; set; } = 30;+ /// <summary>+ /// Gets or sets the mobile login log retention days. Defaults to 30.+ /// Mobile login requests older than this will be permanently deleted.+ /// </summary>+ public int MobileLoginLogRetentionDays { get; set; } = 30;+/// <summary>/// Gets or sets the email retention days. Defaults to 0 (unlimited)./// </summary>diff --git a/apps/server/Tests/AliasVault.IntegrationTests/TaskRunner/TaskRunnerTests.cs b/apps/server/Tests/AliasVault.IntegrationTests/TaskRunner/TaskRunnerTests.csindex 46ac8c83d..f0c08ada1 100644--- a/apps/server/Tests/AliasVault.IntegrationTests/TaskRunner/TaskRunnerTests.cs+++ b/apps/server/Tests/AliasVault.IntegrationTests/TaskRunner/TaskRunnerTests.cs@@ -473,6 +473,168 @@ public class TaskRunnerTestsAssert.That(storedSetting.Value, Is.EqualTo("0"), "MarkUserInactiveAfterDays should be 0 (disabled)");}+ /// <summary>+ /// Tests the Mobile Login Log Cleanup task.+ /// </summary>+ /// <returns>Task.</returns>+ [Test]+ public async Task MobileLoginLogCleanup()+ {+ // Arrange+ await using var dbContext = await _testHostBuilder.GetDbContextAsync();++ // Set mobile login retention to 30 days+ var setting = new ServerSetting+ {+ Key = "MobileLoginLogRetentionDays",+ Value = "30",+ };+ dbContext.ServerSettings.Add(setting);+ await dbContext.SaveChangesAsync();++ // Create old mobile login requests (should be deleted)+ for (int i = 0; i < 20; i++)+ {+ var oldRequest = new MobileLoginRequest+ {+ Id = Guid.NewGuid().ToString(),+ ClientPublicKey = "old-test-key",+ CreatedAt = DateTime.UtcNow.AddDays(-40 - i), // 40+ days old+ ClientIpAddress = "192.168.1.1",+ };+ dbContext.MobileLoginRequests.Add(oldRequest);+ }++ // Create recent mobile login requests (should be kept)+ for (int i = 0; i < 30; i++)+ {+ var recentRequest = new MobileLoginRequest+ {+ Id = Guid.NewGuid().ToString(),+ ClientPublicKey = "recent-test-key",+ CreatedAt = DateTime.UtcNow.AddDays(-i), // 0-29 days old+ ClientIpAddress = "192.168.1.2",+ };+ dbContext.MobileLoginRequests.Add(recentRequest);+ }++ await dbContext.SaveChangesAsync();++ // Act+ await _testHost.StartAsync();+ await WaitForMaintenanceJobCompletion();++ // Assert+ var remainingRequests = await dbContext.MobileLoginRequests.ToListAsync();+ Assert.That(remainingRequests, Has.Count.EqualTo(30), "Only recent mobile login requests (last 30 days) should remain");+ }++ /// <summary>+ /// Tests the Mobile Login Sensitive Data Cleanup task (runs during nightly maintenance).+ /// Sensitive data is automatically cleared after 10 minutes (hardcoded).+ /// </summary>+ /// <returns>Task.</returns>+ [Test]+ public async Task MobileLoginSensitiveDataCleanup()+ {+ // Arrange+ await using var dbContext = await _testHostBuilder.GetDbContextAsync();++ // Create fulfilled-but-not-retrieved request that's old enough to be cleared (> 10 minutes)+ var staleRequest = new MobileLoginRequest+ {+ Id = Guid.NewGuid().ToString(),+ ClientPublicKey = "stale-public-key",+ EncryptedDecryptionKey = "encrypted-key-data",+ Username = "testuser",+ Salt = "test-salt",+ EncryptionType = "Argon2id",+ EncryptionSettings = "{\"iterations\":3}",+ CreatedAt = DateTime.UtcNow.AddMinutes(-15),+ FulfilledAt = DateTime.UtcNow.AddMinutes(-12), // Fulfilled 12 minutes ago (exceeds 10 min timeout)+ RetrievedAt = null, // Not yet retrieved+ ClearedAt = null, // Not yet cleared+ ClientIpAddress = "192.168.1.1",+ MobileIpAddress = "10.0.0.1",+ };+ dbContext.MobileLoginRequests.Add(staleRequest);++ // Create fulfilled-but-not-retrieved request that's too recent to clear (< 10 minutes)+ var recentRequest = new MobileLoginRequest+ {+ Id = Guid.NewGuid().ToString(),+ ClientPublicKey = "recent-public-key",+ EncryptedDecryptionKey = "encrypted-key-data",+ Username = "testuser2",+ Salt = "test-salt",+ EncryptionType = "Argon2id",+ EncryptionSettings = "{\"iterations\":3}",+ CreatedAt = DateTime.UtcNow.AddMinutes(-6),+ FulfilledAt = DateTime.UtcNow.AddMinutes(-5), // Fulfilled 5 minutes ago (under 10 min timeout)+ RetrievedAt = null,+ ClearedAt = null,+ ClientIpAddress = "192.168.1.2",+ MobileIpAddress = "10.0.0.2",+ };+ dbContext.MobileLoginRequests.Add(recentRequest);++ // Create completed request (already retrieved)+ var completedRequest = new MobileLoginRequest+ {+ Id = Guid.NewGuid().ToString(),+ ClientPublicKey = "completed-public-key",+ EncryptedDecryptionKey = "encrypted-key-data",+ Username = "testuser3",+ CreatedAt = DateTime.UtcNow.AddMinutes(-15),+ FulfilledAt = DateTime.UtcNow.AddMinutes(-12),+ RetrievedAt = DateTime.UtcNow.AddMinutes(-11), // Already retrieved+ ClearedAt = DateTime.UtcNow.AddMinutes(-11), // Already cleared when retrieved+ ClientIpAddress = "192.168.1.3",+ MobileIpAddress = "10.0.0.3",+ };+ dbContext.MobileLoginRequests.Add(completedRequest);++ await dbContext.SaveChangesAsync();++ // Act - Run the nightly maintenance cleanup+ await _testHost.StartAsync();+ await WaitForMaintenanceJobCompletion();++ // Assert - Reload entities from database to get updated values+ await dbContext.Entry(staleRequest).ReloadAsync();+ await dbContext.Entry(recentRequest).ReloadAsync();+ await dbContext.Entry(completedRequest).ReloadAsync();++ var staleAfterCleanup = staleRequest;+ Assert.Multiple(() =>+ {+ // Stale request should have sensitive data cleared+ Assert.That(staleAfterCleanup.ClientPublicKey, Is.Empty, "Stale request ClientPublicKey should be cleared");+ Assert.That(staleAfterCleanup.EncryptedDecryptionKey, Is.Null, "Stale request EncryptedDecryptionKey should be cleared");+ Assert.That(staleAfterCleanup.Salt, Is.Null, "Stale request Salt should be cleared");+ Assert.That(staleAfterCleanup.EncryptionType, Is.Null, "Stale request EncryptionType should be cleared");+ Assert.That(staleAfterCleanup.EncryptionSettings, Is.Null, "Stale request EncryptionSettings should be cleared");+ Assert.That(staleAfterCleanup.ClearedAt, Is.Not.Null, "Stale request ClearedAt should be set");++ // Metadata should be preserved for abuse tracking+ Assert.That(staleAfterCleanup.ClientIpAddress, Is.EqualTo("192.168.1.1"), "Client IP should be preserved");+ Assert.That(staleAfterCleanup.MobileIpAddress, Is.EqualTo("10.0.0.1"), "Mobile IP should be preserved");+ Assert.That(staleAfterCleanup.Username, Is.EqualTo("testuser"), "Username should be preserved");+ });++ var recentAfterCleanup = recentRequest;+ Assert.Multiple(() =>+ {+ // Recent request should still have sensitive data (not old enough)+ Assert.That(recentAfterCleanup.ClientPublicKey, Is.EqualTo("recent-public-key"), "Recent request should retain sensitive data");+ Assert.That(recentAfterCleanup.EncryptedDecryptionKey, Is.Not.Null, "Recent request should retain encrypted key");+ Assert.That(recentAfterCleanup.ClearedAt, Is.Null, "Recent request should not be cleared yet");+ });++ var completedAfterCleanup = completedRequest;+ Assert.That(completedAfterCleanup.ClearedAt, Is.Not.Null, "Completed request should remain cleared");+ }+/// <summary>/// Creates a base email with static required fields./// </summary>