Skip to content

Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.

Update tests (#2075)

Leendert de Borst678eb52488bb
diff --git a/apps/browser-extension/src/entrypoints/popup/hooks/useListKeyboardNav.ts b/apps/browser-extension/src/entrypoints/popup/hooks/useListKeyboardNav.ts
index 4ae77acb7..aaff12425 100644
--- a/apps/browser-extension/src/entrypoints/popup/hooks/useListKeyboardNav.ts
+++ b/apps/browser-extension/src/entrypoints/popup/hooks/useListKeyboardNav.ts
@@ -18,7 +18,6 @@ interface IUseListKeyboardNavReturn {
itemIdFor: (index: number) => string;
folderIdFor: (index: number) => string;
activeDescendantId: string | undefined;
- listboxId: string;
}
const ID_PREFIX = 'kb-nav';
@@ -204,6 +203,5 @@ export const useListKeyboardNav = (params: IUseListKeyboardNavParams): IUseListK
itemIdFor,
folderIdFor,
activeDescendantId,
- listboxId: `${ID_PREFIX}-listbox`,
};
};
diff --git a/apps/browser-extension/src/entrypoints/popup/pages/items/ItemsList.tsx b/apps/browser-extension/src/entrypoints/popup/pages/items/ItemsList.tsx
index 285e40f41..5a7aa6085 100644
--- a/apps/browser-extension/src/entrypoints/popup/pages/items/ItemsList.tsx
+++ b/apps/browser-extension/src/entrypoints/popup/pages/items/ItemsList.tsx
@@ -720,7 +720,7 @@ const ItemsList: React.FC = () => {
}
}, [currentFolderId, dbContext, navigate]);
- const { activeKind, activeIndex, itemIdFor, folderIdFor, activeDescendantId, listboxId } = useListKeyboardNav({
+ const { activeKind, activeIndex, itemIdFor, folderIdFor, activeDescendantId } = useListKeyboardNav({
folderCount: folders.length,
itemCount: sortedItems.length,
searchInputRef,
@@ -996,7 +996,7 @@ const ItemsList: React.FC = () => {
placeholder={`${t('content.searchVault')}`}
autoFocus
role="combobox"
- aria-controls={listboxId}
+ aria-controls="items-list"
aria-expanded={sortedItems.length > 0 || folders.length > 0}
aria-activedescendant={activeDescendantId}
aria-autocomplete="list"
@@ -1152,7 +1152,7 @@ const ItemsList: React.FC = () => {
{/* Items */}
{sortedItems.length > 0 && (
- <ul id={listboxId} role="listbox" className="space-y-2">
+ <ul id="items-list" role="listbox" className="space-y-2">
{sortedItems.map((item, index) => (
<ItemCard
key={item.Id}
diff --git a/apps/browser-extension/tests/e2e/08-credential-matcher.spec.ts b/apps/browser-extension/tests/e2e/08-credential-matcher.spec.ts
index f450e9907..7800180ea 100644
--- a/apps/browser-extension/tests/e2e/08-credential-matcher.spec.ts
+++ b/apps/browser-extension/tests/e2e/08-credential-matcher.spec.ts
@@ -180,12 +180,10 @@ test.describe.serial('8. Credential Matcher Integration', () => {
// Verify the autofill popup is visible
const popupVisible = await isAutofillPopupVisible(testPage);
- console.log('Autofill popup visible on example.com:', popupVisible);
expect(popupVisible).toBe(true);
// Get credentials shown in the popup
const credentials = await getAutofillPopupCredentials(testPage);
- console.log('Credentials matched for example.com:', credentials);
// Should match the Example Site Login
expect(credentials).toContain('Example Site Login');
@@ -216,12 +214,10 @@ test.describe.serial('8. Credential Matcher Integration', () => {
// Verify the autofill popup is visible
const popupVisible = await isAutofillPopupVisible(testPage);
- console.log('Autofill popup visible on another-example.com:', popupVisible);
expect(popupVisible).toBe(true);
// Get credentials shown in the popup
const credentials = await getAutofillPopupCredentials(testPage);
- console.log('Credentials matched for another-example.com:', credentials);
// Should match only Another Site Login
expect(credentials).toContain('Another Site Login');